From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1DDA5426D3; Fri, 6 Oct 2023 17:58:31 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A30BD402C8; Fri, 6 Oct 2023 17:58:30 +0200 (CEST) Received: from mail-pj1-f49.google.com (mail-pj1-f49.google.com [209.85.216.49]) by mails.dpdk.org (Postfix) with ESMTP id 48ED8402B9 for ; Fri, 6 Oct 2023 17:58:29 +0200 (CEST) Received: by mail-pj1-f49.google.com with SMTP id 98e67ed59e1d1-278fde50024so2699408a91.1 for ; Fri, 06 Oct 2023 08:58:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1696607908; x=1697212708; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=9cB7spRv3HoRqvYfKFyVeov+iEivQTj0hMNRpWEi8iA=; b=Dx6GJyWNAUNieyJ3j+LTO3rnG1+2KIiSfx4nqgEsBQ42W5Ye1Lz9gzcXDQJVUq5wqc ZPadQkyrn1sv6PRvzYjEFWJGSSuQwpHtsKJqYbC/P8rvTTZjQjH+7l7bFQLosYp3xvdZ DYJUaQ2u+j9Ujwl8/aJl/HoT1DLPCjCxNNKJRY4iCYRyKTXXTKty4kT/AQs1z0ME1IZN z5vx9HWEswh57aZTSR1lG99RpQmunp4Ss7tFxoFaAYtuIaRubCXHhIUf1SuLAynWBZAP U41uN1PdHZb1w0+9AycdpjhvM1SgCSpgJE/9FRsHOZvW1c7g0olL2K3qqnjkdLpgaJvr S2PA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696607908; x=1697212708; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=9cB7spRv3HoRqvYfKFyVeov+iEivQTj0hMNRpWEi8iA=; b=N1sHMhB+zjbsnr80odEPb5AveiL5/xmJOPUEldncuS/Uoi3+M+4dMgadmybzp/ZbBf 2JzF/EQilyA7VpfF1sVZgzCv9G4kOy9Z9bjrMwOVYvGB2SA/wzkSvfTVIf0vT/GmVzU2 XDGIIX8MpXKHLMxRMh+Ef0un2zzHELzJjMzbBTEBs395ImrdEl0RT6+9e+uRMtnJaKTS JihFf/8rkWqLqV8nivMiE1vUKIJCgTL4Irm/npO/o4Cou03Bui70EKsF0JfwkWvCGB2w ZhgU2hSDBbluZCTUFtCjHhHm8qCMHLXoMCetAso41npKcc9OpWR/kxuirUiRMXQeYW1I F8bQ== X-Gm-Message-State: AOJu0YwvhRnJmjvpzFxbxafFinj0jP2x7+xlP8sBXpXD7g1sTnTSqHOF pVzZVYDopW9hYgYtagi2TCqTjg== X-Google-Smtp-Source: AGHT+IHcp1uXyTmVOQ3KiMAcRIJUEsuMRcfeeG6buAUVM/t6zSLO/vJ7GepeQXhR8AXVdui3+LAXvA== X-Received: by 2002:a17:90b:3810:b0:26f:ac36:623a with SMTP id mq16-20020a17090b381000b0026fac36623amr7095007pjb.3.1696607908272; Fri, 06 Oct 2023 08:58:28 -0700 (PDT) Received: from hermes.local (204-195-126-68.wavecable.com. [204.195.126.68]) by smtp.gmail.com with ESMTPSA id nm13-20020a17090b19cd00b0027758c7f585sm3710110pjb.52.2023.10.06.08.58.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Oct 2023 08:58:27 -0700 (PDT) Date: Fri, 6 Oct 2023 08:58:24 -0700 From: Stephen Hemminger To: Mattias =?UTF-8?B?UsO2bm5ibG9t?= Cc: David Marchand , Mattias =?UTF-8?B?UsO2bm5i?= =?UTF-8?B?bG9t?= , dev@dpdk.org, Morten =?UTF-8?B?QnLDuHJ1cA==?= Subject: Re: [PATCH] random: clarify PRNG MT safety guarantees Message-ID: <20231006085824.002a5c4b@hermes.local> In-Reply-To: <23c66954-b560-4cf0-bc50-bab4248b2f8b@lysator.liu.se> References: <20231004105449.367667-1-mattias.ronnblom@ericsson.com> <23c66954-b560-4cf0-bc50-bab4248b2f8b@lysator.liu.se> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, 6 Oct 2023 14:18:25 +0200 Mattias R=C3=B6nnblom wrote: > On 2023-10-06 11:13, David Marchand wrote: > > On Wed, Oct 4, 2023 at 1:00=E2=80=AFPM Mattias R=C3=B6nnblom > > wrote: =20 > >> > >> Clarify MT safety guarantees for unregistered non-EAL threads calling > >> PRNG functions in rte_random.h. > >> > >> Clarify that rte_srand() is not MT safe in regards to calls to > >> rte_rand_max() and rte_drand(). > >> > >> Suggested-by: Stephen Hemminger > >> Signed-off-by: Mattias R=C3=B6nnblom = =20 > >=20 > > Should it be backported along 3a4e21301c7a ("random: initialize state > > for unregistered non-EAL threads") ? > >=20 > > =20 >=20 > I don't think that's worth the trouble, but if someone has a different=20 > opinion, I also don't mind if it is. Agree. The initialization patch should be backported, but not this one.