DPDK patches and discussions
 help / color / mirror / Atom feed
From: Chaoyong He <chaoyong.he@corigine.com>
To: dev@dpdk.org
Cc: oss-drivers@corigine.com, Long Wu <long.wu@corigine.com>,
	James Hershaw <james.hershaw@corigine.com>,
	Chaoyong He <chaoyong.he@corigine.com>
Subject: [PATCH v3 3/8] net/bonding: modify interface comment format
Date: Sun,  8 Oct 2023 09:50:36 +0800	[thread overview]
Message-ID: <20231008015041.1551165-4-chaoyong.he@corigine.com> (raw)
In-Reply-To: <20231008015041.1551165-1-chaoyong.he@corigine.com>

From: Long Wu <long.wu@corigine.com>

Most of the previous interface comment format does not meet the
current standards and were not uniform.

Modify them to meet current standards.

Signed-off-by: Long Wu <long.wu@corigine.com>
Reviewed-by: James Hershaw <james.hershaw@corigine.com>
Reviewed-by: Chaoyong He <chaoyong.he@corigine.com>
---
 drivers/net/bonding/eth_bond_8023ad_private.h |  52 +++---
 drivers/net/bonding/rte_eth_bond.h            | 150 +++++++++++-------
 drivers/net/bonding/rte_eth_bond_8023ad.h     |  76 ++++++---
 drivers/net/bonding/rte_eth_bond_alb.h        |  34 ++--
 4 files changed, 199 insertions(+), 113 deletions(-)

diff --git a/drivers/net/bonding/eth_bond_8023ad_private.h b/drivers/net/bonding/eth_bond_8023ad_private.h
index ab7d15f81a..29ee8700c3 100644
--- a/drivers/net/bonding/eth_bond_8023ad_private.h
+++ b/drivers/net/bonding/eth_bond_8023ad_private.h
@@ -196,10 +196,13 @@ struct bond_dev_private;
  *
  * Set mode 4 configuration of bonding interface.
  *
- * @pre Bonding interface must be stopped.
+ * @pre
+ *   Bonding interface must be stopped.
  *
- * @param dev Bonding interface
- * @param conf new configuration. If NULL set default configuration.
+ * @param dev
+ *   Bonding interface
+ * @param conf
+ *   new configuration. If NULL set default configuration.
  */
 void
 bond_mode_8023ad_setup(struct rte_eth_dev *dev,
@@ -210,9 +213,11 @@ bond_mode_8023ad_setup(struct rte_eth_dev *dev,
  *
  * Enables 802.1AX mode and all active members on bonding interface.
  *
- * @param dev Bonding interface
+ * @param dev
+ *   Bonding interface
+ *
  * @return
- *  0 on success, negative value otherwise.
+ *   0 on success, negative value otherwise.
  */
 int
 bond_mode_8023ad_enable(struct rte_eth_dev *dev);
@@ -222,7 +227,8 @@ bond_mode_8023ad_enable(struct rte_eth_dev *dev);
  *
  * Disables 802.1AX mode of the bonding interface and members.
  *
- * @param dev Bonding interface
+ * @param dev
+ *   Bonding interface
  * @return
  *   0 on success, negative value otherwise.
  */
@@ -232,7 +238,8 @@ int bond_mode_8023ad_disable(struct rte_eth_dev *dev);
  * @internal
  *
  * Starts 802.3AX state machines management logic.
- * @param dev Bonding interface
+ * @param dev
+ *   Bonding interface
  * @return
  *   0 if machines was started, 1 if machines was already running,
  *   negative value otherwise.
@@ -244,7 +251,8 @@ bond_mode_8023ad_start(struct rte_eth_dev *dev);
  * @internal
  *
  * Stops 802.3AX state machines management logic.
- * @param dev Bonding interface
+ * @param dev
+ *   Bonding interface
  * @return
  *   0 if this call stopped state machines, -ENOENT if alarm was not set.
  */
@@ -255,9 +263,12 @@ bond_mode_8023ad_stop(struct rte_eth_dev *dev);
  * @internal
  *
  * Passes given slow packet to state machines management logic.
- * @param internals Bonding device private data.
- * @param member_id Member port id.
- * @param slot_pkt Slow packet.
+ * @param internals
+ *   Bonding device private data.
+ * @param member_id
+ *   Member port id.
+ * @param slot_pkt
+ *   Slow packet.
  */
 void
 bond_mode_8023ad_handle_slow_pkt(struct bond_dev_private *internals,
@@ -268,11 +279,13 @@ bond_mode_8023ad_handle_slow_pkt(struct bond_dev_private *internals,
  *
  * Appends given member used member
  *
- * @param dev       Bonding interface.
- * @param port_id   Member port ID to be added
+ * @param dev
+ *   Bonding interface.
+ * @param port_id
+ *   Member port ID to be added
  *
  * @return
- *  0 on success, negative value otherwise.
+ *   0 on success, negative value otherwise.
  */
 void
 bond_mode_8023ad_activate_member(struct rte_eth_dev *dev, uint16_t port_id);
@@ -282,18 +295,21 @@ bond_mode_8023ad_activate_member(struct rte_eth_dev *dev, uint16_t port_id);
  *
  * Denitializes and removes given member from 802.1AX mode.
  *
- * @param dev       Bonding interface.
- * @param member_num Position of member in active_members array
+ * @param dev
+ *   Bonding interface.
+ * @param member_num
+ *   Position of member in active_members array
  *
  * @return
- *  0 on success, negative value otherwise.
+ *   0 on success, negative value otherwise.
  */
 int
 bond_mode_8023ad_deactivate_member(struct rte_eth_dev *dev, uint16_t member_pos);
 
 /**
  * Updates state when MAC was changed on bonding device or one of its members.
- * @param bond_dev Bonding device
+ * @param bond_dev
+ *   Bonding device
  */
 void
 bond_mode_8023ad_mac_address_update(struct rte_eth_dev *bond_dev);
diff --git a/drivers/net/bonding/rte_eth_bond.h b/drivers/net/bonding/rte_eth_bond.h
index 6be5e46deb..28aa341d2f 100644
--- a/drivers/net/bonding/rte_eth_bond.h
+++ b/drivers/net/bonding/rte_eth_bond.h
@@ -95,12 +95,15 @@ extern "C" {
 /**
  * Create a bonding rte_eth_dev device
  *
- * @param name			Name of new link bonding device.
- * @param mode			Mode to initialize bonding device in.
- * @param socket_id		Socket Id on which to allocate eth_dev resources.
+ * @param name
+ *   Name of new link bonding device.
+ * @param mode
+ *   Mode to initialize bonding device in.
+ * @param socket_id
+ *   Socket Id on which to allocate eth_dev resources.
  *
  * @return
- *	Port Id of created rte_eth_dev on success, negative value otherwise
+ *   Port Id of created rte_eth_dev on success, negative value otherwise
  */
 int
 rte_eth_bond_create(const char *name, uint8_t mode, uint8_t socket_id);
@@ -108,10 +111,11 @@ rte_eth_bond_create(const char *name, uint8_t mode, uint8_t socket_id);
 /**
  * Free a bonding rte_eth_dev device
  *
- * @param name			Name of the link bonding device.
+ * @param name
+ *   Name of the link bonding device.
  *
  * @return
- *	0 on success, negative value otherwise
+ *   0 on success, negative value otherwise
  */
 int
 rte_eth_bond_free(const char *name);
@@ -119,11 +123,13 @@ rte_eth_bond_free(const char *name);
 /**
  * Add a rte_eth_dev device as a member to the bonding device
  *
- * @param bonding_port_id	Port ID of bonding device.
- * @param member_port_id		Port ID of member device.
+ * @param bonding_port_id
+ *   Port ID of bonding device.
+ * @param member_port_id
+ *   Port ID of member device.
  *
  * @return
- *	0 on success, negative value otherwise
+ *   0 on success, negative value otherwise
  */
 __rte_experimental
 int
@@ -132,11 +138,13 @@ rte_eth_bond_member_add(uint16_t bonding_port_id, uint16_t member_port_id);
 /**
  * Remove a member rte_eth_dev device from the bonding device
  *
- * @param bonding_port_id	Port ID of bonding device.
- * @param member_port_id		Port ID of member device.
+ * @param bonding_port_id
+ *   Port ID of bonding device.
+ * @param member_port_id
+ *   Port ID of member device.
  *
  * @return
- *	0 on success, negative value otherwise
+ *   0 on success, negative value otherwise
  */
 __rte_experimental
 int
@@ -145,11 +153,13 @@ rte_eth_bond_member_remove(uint16_t bonding_port_id, uint16_t member_port_id);
 /**
  * Set link bonding mode of bonding device
  *
- * @param bonding_port_id	Port ID of bonding device.
- * @param mode				Bonding mode to set
+ * @param bonding_port_id
+ *   Port ID of bonding device.
+ * @param mode
+ *   Bonding mode to set
  *
  * @return
- *	0 on success, negative value otherwise
+ *   0 on success, negative value otherwise
  */
 int
 rte_eth_bond_mode_set(uint16_t bonding_port_id, uint8_t mode);
@@ -157,10 +167,11 @@ rte_eth_bond_mode_set(uint16_t bonding_port_id, uint8_t mode);
 /**
  * Get link bonding mode of bonding device
  *
- * @param bonding_port_id	Port ID of bonding device.
+ * @param bonding_port_id
+ *   Port ID of bonding device.
  *
  * @return
- *	link bonding mode on success, negative value otherwise
+ *   link bonding mode on success, negative value otherwise
  */
 int
 rte_eth_bond_mode_get(uint16_t bonding_port_id);
@@ -168,11 +179,13 @@ rte_eth_bond_mode_get(uint16_t bonding_port_id);
 /**
  * Set member rte_eth_dev as primary member of bonding device
  *
- * @param bonding_port_id	Port ID of bonding device.
- * @param member_port_id		Port ID of member device.
+ * @param bonding_port_id
+ *   Port ID of bonding device.
+ * @param member_port_id
+ *   Port ID of member device.
  *
  * @return
- *	0 on success, negative value otherwise
+ *   0 on success, negative value otherwise
  */
 int
 rte_eth_bond_primary_set(uint16_t bonding_port_id, uint16_t member_port_id);
@@ -180,10 +193,11 @@ rte_eth_bond_primary_set(uint16_t bonding_port_id, uint16_t member_port_id);
 /**
  * Get primary member of bonding device
  *
- * @param bonding_port_id	Port ID of bonding device.
+ * @param bonding_port_id
+ *   Port ID of bonding device.
  *
  * @return
- *	Port Id of primary member on success, -1 on failure
+ *   Port Id of primary member on success, -1 on failure
  */
 int
 rte_eth_bond_primary_get(uint16_t bonding_port_id);
@@ -191,13 +205,16 @@ rte_eth_bond_primary_get(uint16_t bonding_port_id);
 /**
  * Populate an array with list of the members port id's of the bonding device
  *
- * @param bonding_port_id	Port ID of bonding eth_dev to interrogate
- * @param members			Array to be populated with the current active members
- * @param len				Length of members array
+ * @param bonding_port_id
+ *   Port ID of bonding eth_dev to interrogate
+ * @param members
+ *   Array to be populated with the current active members
+ * @param len
+ *   Length of members array
  *
  * @return
- *	Number of members associated with bonding device on success,
- *	negative value otherwise
+ *   Number of members associated with bonding device on success,
+ *   negative value otherwise
  */
 __rte_experimental
 int
@@ -208,13 +225,16 @@ rte_eth_bond_members_get(uint16_t bonding_port_id, uint16_t members[],
  * Populate an array with list of the active members port id's of the bonding
  * device.
  *
- * @param bonding_port_id	Port ID of bonding eth_dev to interrogate
- * @param members			Array to be populated with the current active members
- * @param len				Length of members array
+ * @param bonding_port_id
+ *   Port ID of bonding eth_dev to interrogate
+ * @param members
+ *   Array to be populated with the current active members
+ * @param len
+ *   Length of members array
  *
  * @return
- *	Number of active members associated with bonding device on success,
- *	negative value otherwise
+ *   Number of active members associated with bonding device on success,
+ *   negative value otherwise
  */
 __rte_experimental
 int
@@ -224,12 +244,13 @@ rte_eth_bond_active_members_get(uint16_t bonding_port_id, uint16_t members[],
 /**
  * Set explicit MAC address to use on bonding device and it's members.
  *
- * @param bonding_port_id	Port ID of bonding device.
- * @param mac_addr			MAC Address to use on bonding device overriding
- *							members MAC addresses
+ * @param bonding_port_id
+ *   Port ID of bonding device.
+ * @param mac_addr
+ *   MAC Address to use on bonding device overriding members MAC addresses
  *
  * @return
- *	0 on success, negative value otherwise
+ *   0 on success, negative value otherwise
  */
 int
 rte_eth_bond_mac_address_set(uint16_t bonding_port_id,
@@ -239,10 +260,11 @@ rte_eth_bond_mac_address_set(uint16_t bonding_port_id,
  * Reset bonding device to use MAC from primary member on bonding device and it's
  * members.
  *
- * @param bonding_port_id	Port ID of bonding device.
+ * @param bonding_port_id
+ *   Port ID of bonding device.
  *
  * @return
- *	0 on success, negative value otherwise
+ *   0 on success, negative value otherwise
  */
 int
 rte_eth_bond_mac_address_reset(uint16_t bonding_port_id);
@@ -252,11 +274,13 @@ rte_eth_bond_mac_address_reset(uint16_t bonding_port_id);
  * balance mode, this parameter is otherwise ignored in other modes of
  * operation.
  *
- * @param bonding_port_id	Port ID of bonding device.
- * @param policy			Balance mode transmission policy.
+ * @param bonding_port_id
+ *   Port ID of bonding device.
+ * @param policy
+ *   Balance mode transmission policy.
  *
  * @return
- *	0 on success, negative value otherwise.
+ *   0 on success, negative value otherwise.
  */
 int
 rte_eth_bond_xmit_policy_set(uint16_t bonding_port_id, uint8_t policy);
@@ -264,10 +288,11 @@ rte_eth_bond_xmit_policy_set(uint16_t bonding_port_id, uint8_t policy);
 /**
  * Get the transmit policy set on bonding device for balance mode operation
  *
- * @param bonding_port_id	Port ID of bonding device.
+ * @param bonding_port_id
+ *   Port ID of bonding device.
  *
  * @return
- *	Balance transmit policy on success, negative value otherwise.
+ *   Balance transmit policy on success, negative value otherwise.
  */
 int
 rte_eth_bond_xmit_policy_get(uint16_t bonding_port_id);
@@ -276,11 +301,13 @@ rte_eth_bond_xmit_policy_get(uint16_t bonding_port_id);
  * Set the link monitoring frequency (in ms) for monitoring the link status of
  * member devices
  *
- * @param bonding_port_id	Port ID of bonding device.
- * @param internal_ms		Monitoring interval in milliseconds
+ * @param bonding_port_id
+ *   Port ID of bonding device.
+ * @param internal_ms
+ *   Monitoring interval in milliseconds
  *
  * @return
- *	0 on success, negative value otherwise.
+ *   0 on success, negative value otherwise.
  */
 
 int
@@ -290,10 +317,11 @@ rte_eth_bond_link_monitoring_set(uint16_t bonding_port_id, uint32_t internal_ms)
  * Get the current link monitoring frequency (in ms) for monitoring of the link
  * status of member devices
  *
- * @param bonding_port_id	Port ID of bonding device.
+ * @param bonding_port_id
+ *   Port ID of bonding device.
  *
  * @return
- *	Monitoring interval on success, negative value otherwise.
+ *   Monitoring interval on success, negative value otherwise.
  */
 int
 rte_eth_bond_link_monitoring_get(uint16_t bonding_port_id);
@@ -303,11 +331,13 @@ rte_eth_bond_link_monitoring_get(uint16_t bonding_port_id);
  * Set the period in milliseconds for delaying the disabling of a bonding link
  * when the link down status has been detected
  *
- * @param bonding_port_id	Port ID of bonding device.
- * @param delay_ms			Delay period in milliseconds.
+ * @param bonding_port_id
+ *   Port ID of bonding device.
+ * @param delay_ms
+ *   Delay period in milliseconds.
  *
  * @return
- *  0 on success, negative value otherwise.
+ *   0 on success, negative value otherwise.
  */
 int
 rte_eth_bond_link_down_prop_delay_set(uint16_t bonding_port_id,
@@ -317,10 +347,11 @@ rte_eth_bond_link_down_prop_delay_set(uint16_t bonding_port_id,
  * Get the period in milliseconds set for delaying the disabling of a bonding
  * link when the link down status has been detected
  *
- * @param bonding_port_id	Port ID of bonding device.
+ * @param bonding_port_id
+ *   Port ID of bonding device.
  *
  * @return
- *  Delay period on success, negative value otherwise.
+ *   Delay period on success, negative value otherwise.
  */
 int
 rte_eth_bond_link_down_prop_delay_get(uint16_t bonding_port_id);
@@ -329,11 +360,13 @@ rte_eth_bond_link_down_prop_delay_get(uint16_t bonding_port_id);
  * Set the period in milliseconds for delaying the enabling of a bonding link
  * when the link up status has been detected
  *
- * @param bonding_port_id	Port ID of bonding device.
- * @param delay_ms			Delay period in milliseconds.
+ * @param bonding_port_id
+ *   Port ID of bonding device.
+ * @param delay_ms
+ *   Delay period in milliseconds.
  *
  * @return
- *  0 on success, negative value otherwise.
+ *   0 on success, negative value otherwise.
  */
 int
 rte_eth_bond_link_up_prop_delay_set(uint16_t bonding_port_id,
@@ -343,10 +376,11 @@ rte_eth_bond_link_up_prop_delay_set(uint16_t bonding_port_id,
  * Get the period in milliseconds set for delaying the enabling of a bonding
  * link when the link up status has been detected
  *
- * @param bonding_port_id	Port ID of bonding device.
+ * @param bonding_port_id
+ *   Port ID of bonding device.
  *
  * @return
- *  Delay period on success, negative value otherwise.
+ *   Delay period on success, negative value otherwise.
  */
 int
 rte_eth_bond_link_up_prop_delay_get(uint16_t bonding_port_id);
diff --git a/drivers/net/bonding/rte_eth_bond_8023ad.h b/drivers/net/bonding/rte_eth_bond_8023ad.h
index 4c280c7565..4936d7fc0c 100644
--- a/drivers/net/bonding/rte_eth_bond_8023ad.h
+++ b/drivers/net/bonding/rte_eth_bond_8023ad.h
@@ -155,8 +155,10 @@ struct rte_eth_bond_8023ad_member_info {
  *
  * Function returns current configuration of 802.3AX mode.
  *
- * @param port_id   Bonding device id
- * @param conf		Pointer to timeout structure.
+ * @param port_id
+ *   Bonding device id
+ * @param conf
+ *   Pointer to timeout structure.
  *
  * @return
  *   0 - if ok
@@ -171,8 +173,10 @@ rte_eth_bond_8023ad_conf_get(uint16_t port_id,
  *
  * Function set new configuration of 802.3AX mode.
  *
- * @param port_id   Bonding device id
- * @param conf		Configuration, if NULL set default configuration.
+ * @param port_id
+ *   Bonding device id
+ * @param conf
+ *   Configuration, if NULL set default configuration.
  * @return
  *   0 - if ok
  *   -EINVAL if configuration is invalid.
@@ -186,8 +190,10 @@ rte_eth_bond_8023ad_setup(uint16_t port_id,
  *
  * Function returns current state of given member device.
  *
- * @param member_id  Port id of valid member.
- * @param conf		buffer for configuration
+ * @param member_id
+ *   Port id of valid member.
+ * @param conf
+ *   buffer for configuration
  * @return
  *   0 - if ok
  *   -EINVAL if conf is NULL or member id is invalid (not a member of given
@@ -201,9 +207,12 @@ rte_eth_bond_8023ad_member_info(uint16_t port_id, uint16_t member_id,
 /**
  * Configure a member port to start collecting.
  *
- * @param port_id	Bonding device id
- * @param member_id	Port id of valid member.
- * @param enabled	Non-zero when collection enabled.
+ * @param port_id
+ *   Bonding device id
+ * @param member_id
+ *   Port id of valid member.
+ * @param enabled
+ *   Non-zero when collection enabled.
  * @return
  *   0 - if ok
  *   -EINVAL if member is not valid.
@@ -215,8 +224,10 @@ rte_eth_bond_8023ad_ext_collect(uint16_t port_id, uint16_t member_id,
 /**
  * Get COLLECTING flag from member port actor state.
  *
- * @param port_id	Bonding device id
- * @param member_id	Port id of valid member.
+ * @param port_id
+ *   Bonding device id
+ * @param member_id
+ *   Port id of valid member.
  * @return
  *   0 - if not set
  *   1 - if set
@@ -228,9 +239,12 @@ rte_eth_bond_8023ad_ext_collect_get(uint16_t port_id, uint16_t member_id);
 /**
  * Configure a member port to start distributing.
  *
- * @param port_id	Bonding device id
- * @param member_id	Port id of valid member.
- * @param enabled	Non-zero when distribution enabled.
+ * @param port_id
+ *   Bonding device id
+ * @param member_id
+ *   Port id of valid member.
+ * @param enabled
+ *   Non-zero when distribution enabled.
  * @return
  *   0 - if ok
  *   -EINVAL if member is not valid.
@@ -242,8 +256,10 @@ rte_eth_bond_8023ad_ext_distrib(uint16_t port_id, uint16_t member_id,
 /**
  * Get DISTRIBUTING flag from member port actor state.
  *
- * @param port_id	Bonding device id
- * @param member_id	Port id of valid member.
+ * @param port_id
+ *   Bonding device id
+ * @param member_id
+ *   Port id of valid member.
  * @return
  *   0 - if not set
  *   1 - if set
@@ -256,9 +272,12 @@ rte_eth_bond_8023ad_ext_distrib_get(uint16_t port_id, uint16_t member_id);
  * LACPDU transmit path for external 802.3ad state machine.  Caller retains
  * ownership of the packet on failure.
  *
- * @param port_id	Bonding device id
- * @param member_id	Port ID of valid member device.
- * @param lacp_pkt	mbuf containing LACPDU.
+ * @param port_id
+ *   Bonding device id
+ * @param member_id
+ *   Port ID of valid member device.
+ * @param lacp_pkt
+ *   mbuf containing LACPDU.
  *
  * @return
  *   0 on success, negative value otherwise.
@@ -284,7 +303,8 @@ rte_eth_bond_8023ad_ext_slowtx(uint16_t port_id, uint16_t member_id,
  *
  * Bonding port must be stopped to change this configuration.
  *
- * @param port_id      Bonding device id
+ * @param port_id
+ *   Bonding device id
  *
  * @return
  *   0 on success, negative value otherwise.
@@ -299,9 +319,11 @@ rte_eth_bond_8023ad_dedicated_queues_enable(uint16_t port_id);
  *
  * Bonding port must be stopped to change this configuration.
  *
- * @see rte_eth_bond_8023ad_slow_pkt_hw_filter_enable
+ * @see
+ *   rte_eth_bond_8023ad_slow_pkt_hw_filter_enable
  *
- * @param port_id      Bonding device id
+ * @param port_id
+ *   Bonding device id
  * @return
  *   0 on success, negative value otherwise.
  *
@@ -309,9 +331,11 @@ rte_eth_bond_8023ad_dedicated_queues_enable(uint16_t port_id);
 int
 rte_eth_bond_8023ad_dedicated_queues_disable(uint16_t port_id);
 
-/*
+/**
  * Get aggregator mode for 8023ad
- * @param port_id Bonding device id
+ *
+ * @param port_id
+ *   Bonding device id
  *
  * @return
  *   aggregator mode on success, negative value otherwise
@@ -321,7 +345,9 @@ rte_eth_bond_8023ad_agg_selection_get(uint16_t port_id);
 
 /**
  * Set aggregator mode for 8023ad
- * @param port_id Bonding device id
+ * @param port_id
+ *   Bonding device id
+ *
  * @return
  *   0 on success, negative value otherwise
  */
diff --git a/drivers/net/bonding/rte_eth_bond_alb.h b/drivers/net/bonding/rte_eth_bond_alb.h
index f51c355d36..3cf0d87750 100644
--- a/drivers/net/bonding/rte_eth_bond_alb.h
+++ b/drivers/net/bonding/rte_eth_bond_alb.h
@@ -63,9 +63,12 @@ bond_mode_alb_enable(struct rte_eth_dev *bond_dev);
  * forwarded to application without changes. If it is ARP reply, client table
  * is updated.
  *
- * @param eth_h			ETH header of received packet.
- * @param offset		Vlan header offset.
- * @param internals		Bonding data.
+ * @param eth_h
+ *   ETH header of received packet.
+ * @param offset
+ *   Vlan header offset.
+ * @param internals
+ *   Bonding data.
  */
 void
 bond_mode_alb_arp_recv(struct rte_ether_hdr *eth_h, uint16_t offset,
@@ -77,12 +80,15 @@ bond_mode_alb_arp_recv(struct rte_ether_hdr *eth_h, uint16_t offset,
  * If it is ARP Reply, it is send on member stored in client table for that
  * connection. On Reply function also updates data in client table.
  *
- * @param eth_h			ETH header of transmitted packet.
- * @param offset		Vlan header offset.
- * @param internals		Bonding data.
+ * @param eth_h
+ *   ETH header of transmitted packet.
+ * @param offset
+ *   Vlan header offset.
+ * @param internals
+ *   Bonding data.
  *
  * @return
- * Index of member on which packet should be sent.
+ *   Index of member on which packet should be sent.
  */
 uint16_t
 bond_mode_alb_arp_xmit(struct rte_ether_hdr *eth_h, uint16_t offset,
@@ -91,12 +97,15 @@ bond_mode_alb_arp_xmit(struct rte_ether_hdr *eth_h, uint16_t offset,
 /**
  * Function fills packet with ARP data from client_info.
  *
- * @param client_info	Data of client to which packet is sent.
- * @param pkt			Pointer to packet which is sent.
- * @param internals		Bonding data.
+ * @param client_info
+ *   Data of client to which packet is sent.
+ * @param pkt
+ *   Pointer to packet which is sent.
+ * @param internals
+ *   Bonding data.
  *
  * @return
- * Index of member on which packet should be sent.
+ *   Index of member on which packet should be sent.
  */
 uint16_t
 bond_mode_alb_arp_upd(struct client_data *client_info,
@@ -105,7 +114,8 @@ bond_mode_alb_arp_upd(struct client_data *client_info,
 /**
  * Function updates member indexes of active connections.
  *
- * @param bond_dev		Pointer to bonding device struct.
+ * @param bond_dev
+ *   Pointer to bonding device struct.
  */
 void
 bond_mode_alb_client_list_upd(struct rte_eth_dev *bond_dev);
-- 
2.39.1


  parent reply	other threads:[~2023-10-08  1:51 UTC|newest]

Thread overview: 80+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-05  2:40 [PATCH 0/8] Enhance the bond framework to support offload Chaoyong He
2023-10-05  2:40 ` [PATCH 1/8] ethdev: add member notification for bonding port Chaoyong He
2023-10-05  2:40 ` [PATCH 2/8] ethdev: add API to get hardware creation of " Chaoyong He
2023-10-05  2:40 ` [PATCH 3/8] net/bonding: modify interface comment format Chaoyong He
2023-10-05  2:40 ` [PATCH 4/8] net/bonding: add bonding port arguments Chaoyong He
2023-10-05  2:40 ` [PATCH 5/8] net/bonding: support add port by data name Chaoyong He
2023-10-05  2:40 ` [PATCH 6/8] net/bonding: create new rte flow header file Chaoyong He
2023-10-05  2:40 ` [PATCH 7/8] net/bonding: support checking valid bonding port ID Chaoyong He
2023-10-05  2:40 ` [PATCH 8/8] net/bonding: add commands for bonding port notification Chaoyong He
2023-10-07  1:34 ` [PATCH v2 0/8] Enhance the bond framework to support offload Chaoyong He
2023-10-07  1:34   ` [PATCH v2 1/8] ethdev: add member notification for bonding port Chaoyong He
2023-10-07 15:49     ` Stephen Hemminger
2023-10-08  1:37       ` Chaoyong He
2023-10-07  1:34   ` [PATCH v2 2/8] ethdev: add API to get hardware creation of " Chaoyong He
2023-10-07  1:34   ` [PATCH v2 3/8] net/bonding: modify interface comment format Chaoyong He
2023-10-07  1:34   ` [PATCH v2 4/8] net/bonding: add bonding port arguments Chaoyong He
2023-10-07  1:34   ` [PATCH v2 5/8] net/bonding: support add port by data name Chaoyong He
2023-10-07  1:34   ` [PATCH v2 6/8] net/bonding: create new rte flow header file Chaoyong He
2023-10-07  1:34   ` [PATCH v2 7/8] net/bonding: support checking valid bonding port ID Chaoyong He
2023-10-07  1:34   ` [PATCH v2 8/8] net/bonding: add commands for bonding port notification Chaoyong He
2023-10-08  1:50   ` [PATCH v3 0/8] Enhance the bond framework to support offload Chaoyong He
2023-10-08  1:50     ` [PATCH v3 1/8] ethdev: add member notification for bonding port Chaoyong He
2023-10-08  2:49       ` lihuisong (C)
2023-10-09  3:11         ` 回复: " Long Wu
2023-10-17  8:27           ` lihuisong (C)
2023-10-18  2:16             ` Chaoyong He
2023-10-08  1:50     ` [PATCH v3 2/8] ethdev: add API to get hardware creation of " Chaoyong He
2023-10-08  1:50     ` Chaoyong He [this message]
2023-10-08  1:50     ` [PATCH v3 4/8] net/bonding: add bonding port arguments Chaoyong He
2023-10-08  1:50     ` [PATCH v3 5/8] net/bonding: support add port by data name Chaoyong He
2023-10-08  1:50     ` [PATCH v3 6/8] net/bonding: create new rte flow header file Chaoyong He
2023-10-08  1:50     ` [PATCH v3 7/8] net/bonding: support checking valid bonding port ID Chaoyong He
2023-10-17  8:33       ` lihuisong (C)
2023-10-17  9:25         ` Chaoyong He
2023-10-17 11:34           ` lihuisong (C)
2023-10-18  1:53             ` Chaoyong He
2023-10-17 15:56         ` Stephen Hemminger
2023-10-08  1:50     ` [PATCH v3 8/8] net/bonding: add commands for bonding port notification Chaoyong He
2023-10-13  2:22     ` [PATCH v3 0/8] Enhance the bond framework to support offload Chaoyong He
2023-10-13 12:53       ` Ferruh Yigit
2023-10-18  7:48     ` [PATCH v4 0/6] " Chaoyong He
2023-10-18  7:48       ` [PATCH v4 1/6] ethdev: add member notification for bonding port Chaoyong He
2023-10-18  7:48       ` [PATCH v4 2/6] ethdev: add API to get hardware creation of " Chaoyong He
2023-10-18  7:48       ` [PATCH v4 3/6] net/bonding: add bonding port arguments Chaoyong He
2023-10-18  7:48       ` [PATCH v4 4/6] net/bonding: support add port by data name Chaoyong He
2023-10-18  7:48       ` [PATCH v4 5/6] net/bonding: support checking valid bonding port ID Chaoyong He
2023-10-18  7:48       ` [PATCH v4 6/6] net/bonding: add commands for bonding port notification Chaoyong He
2023-11-15 16:01       ` [PATCH v4 0/6] Enhance the bond framework to support offload Ferruh Yigit
2023-11-16  1:45         ` Chaoyong He
2023-12-26  2:37       ` [PATCH v5 00/14] " Chaoyong He
2023-12-26  2:37         ` [PATCH v5 01/14] ethdev: add member notification for bonding port Chaoyong He
2023-12-26  2:37         ` [PATCH v5 02/14] ethdev: add API to get firmware creation of " Chaoyong He
2023-12-26  2:37         ` [PATCH v5 03/14] net/bonding: add bonding port arguments Chaoyong He
2023-12-26  2:37         ` [PATCH v5 04/14] net/bonding: support add port by data name Chaoyong He
2023-12-26  2:37         ` [PATCH v5 05/14] net/bonding: support checking valid bonding port ID Chaoyong He
2023-12-26  2:37         ` [PATCH v5 06/14] net/bonding: add commands for bonding port notification Chaoyong He
2023-12-26  2:37         ` [PATCH v5 07/14] net/bonding: create new rte flow header file Chaoyong He
2023-12-26  2:37         ` [PATCH v5 08/14] net/nfp: add bond firmware creation initialization Chaoyong He
2023-12-26  2:37         ` [PATCH v5 09/14] net/nfp: reset bond configuration of firmware Chaoyong He
2023-12-26  2:37         ` [PATCH v5 10/14] net/nfp: handle link event of bond firmware creation Chaoyong He
2023-12-26  2:37         ` [PATCH v5 11/14] net/nfp: support bond member notification Chaoyong He
2023-12-26  2:37         ` [PATCH v5 12/14] net/nfp: handle bond packets from firmware Chaoyong He
2023-12-26  2:37         ` [PATCH v5 13/14] net/nfp: support getting bond firmware creation Chaoyong He
2023-12-26  2:37         ` [PATCH v5 14/14] net/nfp: support offloading bond-flow Chaoyong He
2023-12-26  7:28         ` [PATCH v6 00/14] Enhance the bond framework to support offload Chaoyong He
2023-12-26  7:28           ` [PATCH v6 01/14] ethdev: add member notification for bonding port Chaoyong He
2023-12-26  7:28           ` [PATCH v6 02/14] ethdev: add API to get firmware creation of " Chaoyong He
2023-12-26  7:28           ` [PATCH v6 03/14] net/bonding: add bonding port arguments Chaoyong He
2023-12-26  7:28           ` [PATCH v6 04/14] net/bonding: support add port by data name Chaoyong He
2023-12-26  7:28           ` [PATCH v6 05/14] net/bonding: support checking valid bonding port ID Chaoyong He
2023-12-26  7:28           ` [PATCH v6 06/14] net/bonding: add commands for bonding port notification Chaoyong He
2023-12-26  7:28           ` [PATCH v6 07/14] net/bonding: create new rte flow header file Chaoyong He
2023-12-26  7:28           ` [PATCH v6 08/14] net/nfp: add bond firmware creation initialization Chaoyong He
2023-12-26  7:28           ` [PATCH v6 09/14] net/nfp: reset bond configuration of firmware Chaoyong He
2023-12-26  7:28           ` [PATCH v6 10/14] net/nfp: handle link event of bond firmware creation Chaoyong He
2023-12-26  7:28           ` [PATCH v6 11/14] net/nfp: support bond member notification Chaoyong He
2023-12-26  7:28           ` [PATCH v6 12/14] net/nfp: handle bond packets from firmware Chaoyong He
2023-12-26  7:28           ` [PATCH v6 13/14] net/nfp: support getting bond firmware creation Chaoyong He
2023-12-26  7:28           ` [PATCH v6 14/14] net/nfp: support offloading bond-flow Chaoyong He
2024-09-22 22:30           ` [PATCH v6 00/14] Enhance the bond framework to support offload Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231008015041.1551165-4-chaoyong.he@corigine.com \
    --to=chaoyong.he@corigine.com \
    --cc=dev@dpdk.org \
    --cc=james.hershaw@corigine.com \
    --cc=long.wu@corigine.com \
    --cc=oss-drivers@corigine.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).