From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id ECBB84233C; Mon, 9 Oct 2023 17:17:41 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BA280402C2; Mon, 9 Oct 2023 17:17:41 +0200 (CEST) Received: from mail-pl1-f177.google.com (mail-pl1-f177.google.com [209.85.214.177]) by mails.dpdk.org (Postfix) with ESMTP id 8885F402A3 for ; Mon, 9 Oct 2023 17:17:40 +0200 (CEST) Received: by mail-pl1-f177.google.com with SMTP id d9443c01a7336-1c5db4925f9so34051745ad.1 for ; Mon, 09 Oct 2023 08:17:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1696864660; x=1697469460; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=WCrv+VxxgAVLRdqf8BvTgz3h4mMk9S/z9qJufWK41x0=; b=YzjKuQ2roprJ1YUrJ2oQaKf1Gyp8UDTN1sSUq5guADtof+Fh0nO4GC/N0LmPiC+px7 nOwJn1HOerMelgjCHMiggwIQnzh+tYrJGM841wtRzvdhfCHv8LHB+5h8u/z76beWGkpr kt2VRysGxmrgggavrrrg53an+likLMZtxsCkDt+t4Ny/aMnB/G5CLc67Tf6LT8w0/ECx hS+jOmfr2+BEPgXVfX8gfBZfUXPsxKrzV8n3F/dva16wcy13V5XTSqU8tTImrTXACZKu Js84QEoiSqYgLrwRC1v/Ev0iAjeny9KPnQrQxk6wpi0SD74n8gBdrTygkniDv7qQjzM5 8DGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696864660; x=1697469460; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=WCrv+VxxgAVLRdqf8BvTgz3h4mMk9S/z9qJufWK41x0=; b=r9Y/A/U/zcr9Os8DDqGqobftu5CJJ2oYOAik6C4y4WKyeS8Bb747Qnqcuk329i0iCK NUoUe2ayy9GpAVNiaUYqFYAu5Y5kH4f43MERv+AyF7CuUjXbtrnxu+d/kd2t7xjphN2e MWQXE4YgFVmgTBg8kDzGIq+CJZVQQ6wk3iEafofR8SlNOqfeNCcN97dKnM21L/YSrYz0 jbfnd9g7F28gqHH815Re/3esxjWc9/Md3I/Nhw18BureWhzfRviVfx5YmFwGPDBZE9za ZqGpXN5Dhm3YXLLqDRm8QS4Xmt6qmbNEigtnZW7k9WzzekpZ8GwPjiC1ENqB+5lR3T0W HkPg== X-Gm-Message-State: AOJu0YxHZMNHOyDuqGQKgKviqICvjkSk+mundPYcE0ijp/pmTVVOKR9y zGbslnatNsBYfUXsOGbaY1HYgg== X-Google-Smtp-Source: AGHT+IGRsErg2IZ8cRrw/tsZbiPLD27pnTqs4ZW8MjNzjXhuCCjAZP32jdhUgzn4A8OnaD1hDQaKww== X-Received: by 2002:a17:902:d490:b0:1c6:de7:add9 with SMTP id c16-20020a170902d49000b001c60de7add9mr21521374plg.19.1696864659637; Mon, 09 Oct 2023 08:17:39 -0700 (PDT) Received: from hermes.local (204-195-126-68.wavecable.com. [204.195.126.68]) by smtp.gmail.com with ESMTPSA id b14-20020a170903228e00b001c61acd5bd2sm9737853plh.112.2023.10.09.08.17.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Oct 2023 08:17:39 -0700 (PDT) Date: Mon, 9 Oct 2023 08:17:37 -0700 From: Stephen Hemminger To: Sam Andrew Cc: "dev@dpdk.org" , Long Li Subject: Re: [PATCH] net/netvsc: add support for mtu_set Message-ID: <20231009081737.3b64131e@hermes.local> In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, 5 Oct 2023 23:17:28 +0000 Sam Andrew wrote: > + > +static int > +hn_dev_mtu_set(struct rte_eth_dev *dev, uint16_t mtu) > +{ > + struct hn_data *hv = dev->data->dev_private; > + unsigned int orig_mtu = dev->data->mtu; > + uint32_t rndis_mtu; > + int ret = 0; > + int i; > + > + if (dev->data->dev_started) { > + PMD_DRV_LOG(ERR, "Device must be stopped before changing MTU"); > + return -EIO; > + } > + It looks like this proposed patch does not have the accelerated networking virtual device case. The driver needs to first update the MTU of the underlying VF device (and handle errors), then reinit the vmbus device.