From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A17B542347; Tue, 10 Oct 2023 08:03:46 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6C03F4027B; Tue, 10 Oct 2023 08:03:46 +0200 (CEST) Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2117.outbound.protection.outlook.com [40.107.223.117]) by mails.dpdk.org (Postfix) with ESMTP id 47E6A40278; Tue, 10 Oct 2023 08:03:45 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=S7e2i7zcIm8zgZEhn1LzlbvCLhy3Szjr4oE0LP3oRSKoEOEoPCfAXULa6LibPQLKItdRE0c0Lb/X3ta7ae8T3E8HvXynkZCzz2FiZoaKKPjvfCqO8AYh1nMbBqu9gPpH/2MD6mDQlA0lgIOwsoydb+o46T+pFH9EgGHbAQB+SJJlFvNVZiDheuHhD3QYDqVrWbVgit4o5q0KigohO9VTCSe2yX59R4aewDucDgxTWTlqbJ6e76IkjmZCzLLF+w8+qd0kUdn0K2XkMWCE9ZI8wdOg+/cMEWTpnxvO7FyQfvrBQkUgHVAy0qAeKk+3LeiHvTFMscdHGGWg/tCOuR+oyw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xG8n5si5CCB99mgmOKeph07+36gOcfR2YWntWeBeXqY=; b=QjYYKyM1+GovMLlGVLkkUzwc/2Ce1ycloUQqC3/4nCLdyMyiyCRyzy+Uh96TdD0X3UpYAIrPoXEBwL/BaEZ9sqB2YDIOY+xgOoThSSWIhz9chsUu17glig7jdwlZPMRmHF/v2Fxm2WmDxCXS9uhtN09gf+h8ZzuQKZGnzSYo7ZP0LFQa+168LG2tu2T0Eijq08RvlkvSaD7X8NFZ/NQZq4RahsKoYDUF1AZPD/Q644P6Wxv/ISC5nyQhlp1OtjeR5aeMJB41HoceUvx8YW2oQ94m3+B1fIVD3NYERaX3jm4sXqaJzJLPmcQsyljnIa0g0bOGN/o5s+mDXKS3CyWK6w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=corigine.com; dmarc=pass action=none header.from=corigine.com; dkim=pass header.d=corigine.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=corigine.onmicrosoft.com; s=selector2-corigine-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xG8n5si5CCB99mgmOKeph07+36gOcfR2YWntWeBeXqY=; b=KQ+faCdqpxf1CB0h5xMLnbqm09U/Pj/bOoxiV0HIwZsO726kolfUqukmgxx3cy3i4AAqSoAPL/2RpGuDmvvkbk895hkWUZ2YuZW9Z5bhAZTtShR37Kj+ehOTqzoQPG1ETJlEp07Pk3+l9dMG2nvsjl210uvr4sQuunMw/l+FVvs= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=corigine.com; Received: from SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5) by SA1PR13MB4959.namprd13.prod.outlook.com (2603:10b6:806:18b::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6863.38; Tue, 10 Oct 2023 06:03:43 +0000 Received: from SJ0PR13MB5545.namprd13.prod.outlook.com ([fe80::2d5:f7d6:ecde:c93a]) by SJ0PR13MB5545.namprd13.prod.outlook.com ([fe80::2d5:f7d6:ecde:c93a%4]) with mapi id 15.20.6863.032; Tue, 10 Oct 2023 06:03:43 +0000 From: Chaoyong He To: dev@dpdk.org Cc: oss-drivers@corigine.com, Zerun Fu , chaoyong.he@corigine.com, stable@dpdk.org, Long Wu , Peng Zhang Subject: [PATCH] net/nfp: fix the initialization of physical representors Date: Tue, 10 Oct 2023 14:03:12 +0800 Message-Id: <20231010060312.205777-1-chaoyong.he@corigine.com> X-Mailer: git-send-email 2.39.1 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-ClientProxiedBy: SJ0PR03CA0349.namprd03.prod.outlook.com (2603:10b6:a03:39c::24) To SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR13MB5545:EE_|SA1PR13MB4959:EE_ X-MS-Office365-Filtering-Correlation-Id: 51cbf8b2-c501-40e1-2c6c-08dbc956a7fe X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: A9soX+67VVbCLW0XdmbRBFGaUGRXoaun7ilHfnpm3ZpVhwKIpMjDUNMEJ2kYQjuyDdtXzflvemc4QWzYGjQ/IIcCQqkvvF9872EZvNI5ZjWGs8GiGdT4bt8iwvhdWzqAMDT5a/NvGCO+M0gT35PB23Wcjw1Z4utBvDOmSFU3+47R23+c0m4P576EBAqp0gw11HA0/L50TC5Uj7b2t+4v8RCrgX1F5QuTtchBt0aKMf/+BLForYk+0emqGSmNCEdtEJRRsdZ3ehTxUVfNJQHzDa0gDMfY9IFrvyX4FPy//DGtRau8TpghKBL5biaRZVBYnlF+cy+BXN4FOzjNyq125cpS0rOIqKVY42cn3dL8TNfXMVwX3tB1LuFHnf9ILeV7vfP+mQ1Rinfbvvk+DYTw5TB7hSk6ROYB3fBC1gCjeGjsHt7S8fIvVxL7ckAqaxd0FMOVzSe5tn+WFIHtEFkb3L5DOPgKuGAKOwNTY+KFayjg8ByiUFXLpmUgHy6WsuTSuzSJjf4IpUSblSKk/5/TqH4rwYGonxUVwfVVhnZ4K57J7ohChme6ptvAwPJWMnmS/q8ONmlLXcLStlHPjfnfP68IST5KnRjtQRAKhbbZ4NPgYAZkUauuwMs34xr1NShrPRBW7YmzVrQdR5qriOJrsz5V4iCn2+nN2yonp20uYss= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR13MB5545.namprd13.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(396003)(376002)(366004)(39830400003)(346002)(136003)(230922051799003)(1800799009)(186009)(64100799003)(451199024)(52116002)(1076003)(107886003)(6512007)(36756003)(86362001)(38350700002)(38100700002)(26005)(44832011)(2906002)(83380400001)(6486002)(6666004)(2616005)(6506007)(478600001)(6916009)(8936002)(8676002)(4326008)(450100002)(41300700001)(316002)(5660300002)(66476007)(66946007)(66556008)(54906003); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?68Uf8vXy3G7d88uqWQq/u+8xfgoNqtWVcUR065+lH+Rl5DTSw4J8JxCrjytw?= =?us-ascii?Q?/TZrvJoEUwAxW/YUAlXsyiCU0Fro5B6Y0WpqdeYaKz8tgC8JFN2aWSlo3PjH?= =?us-ascii?Q?9eDvryimnAR30pvp86oxLUCBk9YbVYbqi+hXt70JZEqM/XnKMz/ik2lmWjyh?= =?us-ascii?Q?d9TLt+Hk1OqpsCi2jxG0D+UxGIL37Iy9Qo+OPXYJLWlU5J1MnmG09sFPO7tl?= =?us-ascii?Q?3srAWmHTToML3qYxttCmiCuz+7af8SvPXyrHJuffiePAIytVMGqtNOAHaijQ?= =?us-ascii?Q?V/Tzjoz/gyaWG+TQQTc5s0mcKd3fZpUxmgJaOonAk5EyaQkNoD2Yh1gjuPy1?= =?us-ascii?Q?G4sZOzuJF+IGENs27ShPfOJqpA8P2Ywu0nAP82lzYsJioWzYUItRwCwg7VsV?= =?us-ascii?Q?ItiwY/rVAGWKJyqcJdP+8N45HoWvT/zG4Revmn1Iu2ZLSxAEC2LwKIcgIQdU?= =?us-ascii?Q?0QPTgWv22IcJ374Wp1NZsZzxRNrSIvF2BgB09FD9T4DR5Kxlg5FQnluHSmHb?= =?us-ascii?Q?wfjddVkkx5rM4Hd9z9XaZsF0eEpwVfb4M47HnKgcIha13+pVlXEvLG6kUsD0?= =?us-ascii?Q?sDYklqmNR1i0uXONxO6fC1uynD+lmKE4AutSaGycFJ0sHMMZn9ngOmPBS/n4?= =?us-ascii?Q?84B8fxMi77krpLLF7dhqTGGICKagnsoLDGTWWsUzZJj2Herg5bNMDPPaRN6k?= =?us-ascii?Q?wXUc3ensTNtb4EL6tGcJLLRlER36JncuvwpxMRxZOggLmSJ+nSm7DV6msYno?= =?us-ascii?Q?R7eUR3gU42u9OM8sID5lOC3Ilvwmu1DuT7+UEC7wvKX7ISG/38Ar+EFUehmA?= =?us-ascii?Q?HquCpOXAXo9j5Z0jP851teO1QmNoSNttyhD6JUax7rx6NzPkQbHQ9eysmfoj?= =?us-ascii?Q?yMxaNnOTrab5Os9jtx2T9s5k39vA8Nvg3x35NyEFLfTd7HPfJlrOPcIDtkd+?= =?us-ascii?Q?3DiJhiTwPJB4oxM4lQ82aWF/D8eOkHuZPEXBnc6pVBB/DepKH/3TBd9ySnaP?= =?us-ascii?Q?PDzl50yMK2/yeWHPWA43gQuAwnHW5du4nXg1pUi+2ovMbozLhzcrTDphDCOx?= =?us-ascii?Q?ERdSD4dkGs5gGg3x0oGTIoMZ14oeP5hskBkYW6rki2rtBaHySEuwniC825rZ?= =?us-ascii?Q?blEGhNRlB/5O0NH7IW9gWPKx4EVdVQKOrVynHYznUop7PNnuUJJihLCAroz8?= =?us-ascii?Q?oJ12QqS+O6lMeP9luL9Y4jSoxOybRSnnNFl8dDT/lTreNqNGOWLJKgJSsGiZ?= =?us-ascii?Q?Vr59Dy+JSqGwFCYcsdZRQQ4MoCnmDAj8eifMI9wIdbnAmiHlr0+IIR6nrFYc?= =?us-ascii?Q?o9c2VAmPMNc/JhOanQzN9V1LCbceo3Q7DpQkyNSU0qar1OP+Mfrvp8bKnJmo?= =?us-ascii?Q?5hofRVhasDWbvKeIeFSrvcXVjCa/qMOUE2CUp66nPlNUWK4i/hejKhS+Nd1p?= =?us-ascii?Q?oCvJIma3RtLItjSMmLXZWsze/JydzZO8oaPn6nRLLPV+DMfC0wPvUvp0RxDk?= =?us-ascii?Q?vd7M3lus6bhyJiLKZVzluRtF7CqqIzqF979r9BVW7ciyoYmM8VPweqI1bh3Q?= =?us-ascii?Q?zRJ5xIfab+R9w9Bbhf6xwn6yB6l1C1FqDxiSGM1rPNDKUnuQtiVzpebep3Ps?= =?us-ascii?Q?fw=3D=3D?= X-OriginatorOrg: corigine.com X-MS-Exchange-CrossTenant-Network-Message-Id: 51cbf8b2-c501-40e1-2c6c-08dbc956a7fe X-MS-Exchange-CrossTenant-AuthSource: SJ0PR13MB5545.namprd13.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Oct 2023 06:03:42.9055 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 0/EBRHxE8q9c2TvOsEi9J4iVlYvG13zoNMASeEv6NYJ4PzpEauuGAJFNMkQVaLrYhDxcMbG3aAEDqOK1Vb/dZveKPlT8PxhgKkY+H2WfVmc= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR13MB4959 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Zerun Fu The former logic of initializing the array of physical port representors is according to 'nfp_idx', but referencing based on 'port_id'. This is a potential bug and will cause segment fault when these two values are not equal. Fix it by using the 'port_id' as index at all time. Fixes: e1124c4f8a45 ("net/nfp: add flower representor framework") Cc: chaoyong.he@corigine.com Cc: stable@dpdk.org Signed-off-by: Zerun Fu Reviewed-by: Long Wu Reviewed-by: Peng Zhang Reviewed-by: Chaoyong He --- drivers/net/nfp/flower/nfp_flower_representor.c | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/drivers/net/nfp/flower/nfp_flower_representor.c b/drivers/net/nfp/flower/nfp_flower_representor.c index 55ca3e6db0..e4c5d765e7 100644 --- a/drivers/net/nfp/flower/nfp_flower_representor.c +++ b/drivers/net/nfp/flower/nfp_flower_representor.c @@ -646,6 +646,7 @@ nfp_flower_repr_init(struct rte_eth_dev *eth_dev, void *init_params) { int ret; + uint16_t index; unsigned int numa_node; char ring_name[RTE_ETH_NAME_MAX_LEN]; struct nfp_app_fw_flower *app_fw_flower; @@ -719,10 +720,13 @@ nfp_flower_repr_init(struct rte_eth_dev *eth_dev, } /* Add repr to correct array */ - if (repr->repr_type == NFP_REPR_TYPE_PHYS_PORT) - app_fw_flower->phy_reprs[repr->nfp_idx] = repr; - else - app_fw_flower->vf_reprs[repr->vf_id] = repr; + if (repr->repr_type == NFP_REPR_TYPE_PHYS_PORT) { + index = NFP_FLOWER_CMSG_PORT_PHYS_PORT_NUM(repr->port_id); + app_fw_flower->phy_reprs[index] = repr; + } else { + index = repr->vf_id; + app_fw_flower->vf_reprs[index] = repr; + } return 0; -- 2.39.1