From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D6E5342348; Tue, 10 Oct 2023 08:23:32 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4FDF3402F1; Tue, 10 Oct 2023 08:23:30 +0200 (CEST) Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2095.outbound.protection.outlook.com [40.107.92.95]) by mails.dpdk.org (Postfix) with ESMTP id 0A65740041; Tue, 10 Oct 2023 08:23:28 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=U4j26MQPMC4C8OxuyqNAMqg60j884Fnhqhc49IaOEZBMIul4Lftedo4S1HMgQnL222xMrBMoVIM05/osS5mvnRfR9x+2YEJiozJKpYSjMg7w3dWkOo+w3g9kaC5YsRZ9JrCMIm5R4WU4aJoxAGBa7V4DebHYxqhz5ukhATsOwRcdEzJpSeQsSsM8BNbYnfazCLz5XkAYb9AYng99CIRTE23MFHfbmcfCT9wIM7DI6/aV9z1XgacGXo6GNGaAd8La+/VmdQeBr+frTb4zvoNboXADcI9JBZYNahkScRkYeL8c7xND+kYoDR60KLG2APZKnpYUmQB2D67nZZ3R0OSkVA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=mWo1BSy68Infql9OOFMLYisq4A6rG4YdAyyqSzoGOls=; b=I/6ExdLXweYWIYu8TtecfEzc5OSZGKx5UebGOGi1iQBYmTRzP6RYUtq+QYg5lCvazuksh3Au/RPWV0tuYs4iUYjMbQ6FLwV2o11X3EAlCwLDzKWxYrmAF+TG6Zf2GFZaK6x53AgeiV5NBbbLoKC0njGC/F8Wc0iSIdWmvsit06xbuMHS+dBVBJkoEMU9WKV5cicbRh4vAAHoI67JQsVtiYM1bbHkcMRAbYHXYgBU8xUdn+NIN3qfhNHrxTRQRhiEX1xuLGw85XWYUHSiVDV64y0aIKGSOFF4nS6hrQSIy0wJVBFEiKq3Ug9D3OlHt0kt8tnG0eyC8OTPtiLJxK27YQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=corigine.com; dmarc=pass action=none header.from=corigine.com; dkim=pass header.d=corigine.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=corigine.onmicrosoft.com; s=selector2-corigine-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mWo1BSy68Infql9OOFMLYisq4A6rG4YdAyyqSzoGOls=; b=Joq6af6mfDODY5Qtdo2aVRqyybEHMJUBOl7Aj/s4RjMEerUUj9ErDj8bL5b0tdceObhwm3qrz1mNQC6iU5ytYEZy3fS6ga435khlYLocD9kRbJnP5GSpA3DOO2vQK5plLDME5Wn8Tfvy6vkiNjLop6/OpujWYOlkdanQg+RlvbA= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=corigine.com; Received: from SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5) by DM6PR13MB3802.namprd13.prod.outlook.com (2603:10b6:5:24e::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6838.43; Tue, 10 Oct 2023 06:23:26 +0000 Received: from SJ0PR13MB5545.namprd13.prod.outlook.com ([fe80::2d5:f7d6:ecde:c93a]) by SJ0PR13MB5545.namprd13.prod.outlook.com ([fe80::2d5:f7d6:ecde:c93a%4]) with mapi id 15.20.6863.032; Tue, 10 Oct 2023 06:23:26 +0000 From: Chaoyong He To: dev@dpdk.org Cc: oss-drivers@corigine.com, Long Wu , tomaszx.kulasek@intel.com, stable@dpdk.org, Chaoyong He , Peng Zhang Subject: [PATCH 1/3] app/test: fix control flow issue Date: Tue, 10 Oct 2023 14:23:02 +0800 Message-Id: <20231010062304.205933-2-chaoyong.he@corigine.com> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20231010062304.205933-1-chaoyong.he@corigine.com> References: <20231010062304.205933-1-chaoyong.he@corigine.com> Content-Transfer-Encoding: 8bit Content-Type: text/plain X-ClientProxiedBy: BYAPR07CA0057.namprd07.prod.outlook.com (2603:10b6:a03:60::34) To SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR13MB5545:EE_|DM6PR13MB3802:EE_ X-MS-Office365-Filtering-Correlation-Id: 56090a8b-f800-4013-9785-08dbc9596971 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: c6U4FGFWhqSj4q6zgLtHOJTyTA4Z6nv01fkuj39NUQtPzIR7nPaJmEUUK+E6IEGMUhM3Y6oUfjONg8Ulb43plo/bhH0WLaHSIwBbFolWINvT9m7lUgmAld5TXtyxh4PhdIHwRZEhS8nPtf4rdkae8EJqOyHz93zn4ozf+zJogZZVMXJRBc7PU9X+38pck8HKFbqC4psfKm0uYI6de1nmK5SJrFQ+n4Ot2VVPSd1RAfyvHJBDJh+xxxQEpV6fdDXKm61JnhqKMxaozACXPPQjz81Dx3y+9dkdadxbHQqJFL2ANESuLpyowalbasBbCksjsuGwPOaNTf6Bo2e2KcRRbLjvc9xdCDIkFtQFYAVPImiaQfPEtJiHBcAEK5uMjT3KCsACWBBxaVod8yOmARHKLPM0tFZfnTEeI3mMnR4DcF64iRm9DDhg3KH8IW9Yx+qiv4F9xR+p6j+O3QTge4vfXQEeNLDlNF6sTi/kSFKOeeDz7q+BrP3gdBSOAPJ20gcSAlqxJEEmxS0ImBGExmbuKSjwndggrJptCLaE0ToT817IwdrC6XAoIhEZaARktYuKaYG+yjnEScoLkhe7cnifufv8/LPl/8GmNrDn0i9RC9ffffgs3cz/H/fKKH1DKwvxE5wef5WT9jcj5SXa9ScwoTpWDx9Y35MZb6wNrweiKNA= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR13MB5545.namprd13.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(376002)(346002)(366004)(396003)(136003)(39830400003)(230922051799003)(186009)(451199024)(1800799009)(64100799003)(86362001)(36756003)(38350700002)(38100700002)(1076003)(52116002)(2616005)(6512007)(26005)(8936002)(4326008)(44832011)(6486002)(8676002)(5660300002)(6666004)(6506007)(41300700001)(2906002)(83380400001)(66946007)(107886003)(54906003)(66556008)(6916009)(316002)(66476007)(478600001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?MudSCdEgNBhDcndUjiiF5oYOEkLxcKBX6fIwzcy5Hl/gs8iHqh+GJz5OX3mD?= =?us-ascii?Q?ZhKuCMSq+nGLZjFbSBfQ72zwps/23DfTZH8aQPLSHGYF24PK8NYL5fPqSSDh?= =?us-ascii?Q?TV9K3tkKahsX7Q9EfGpvL8EERXtf3tqSNCnF7G1YIj70hPUp1C7axqloXkrd?= =?us-ascii?Q?Ril19b1D5NUI9XZps1FM8mrVK/X1MW5m1cwIjU51PtheAgjWuB5K/x+rnzKL?= =?us-ascii?Q?UOot5xdcN+iPYjEPT+6ZuCxy3yXCwlDhw368hApA3qz05OEa1kVMx5C48etz?= =?us-ascii?Q?zw1+cG2KFTa3NaswPepWfY1+6dESQHFcXpcJDBdEJ6FCk5YlXqE8jUcA7YNQ?= =?us-ascii?Q?ykcIYRVsMd38gqV65X/Dub/ZTjnuQy0kClNUwMEU0pdnJmXVS1e/WrDXm+0Z?= =?us-ascii?Q?w59Wa6ZvzRc/WZAG2PIYrpVZzacRczznLExZnwZZG2kolODDAzQWrbXRtNer?= =?us-ascii?Q?s4I/SV9E7ZI7GWqabtizqlIrBbTDeFBfwIQ1YMVtfLqHXj+mPZFAB2IGLjbv?= =?us-ascii?Q?mmoqEfwfYQqIijw8yMrtv+9xznFkDa5Pc6FyXscqVnIOpSLjrv7Gur6wOQ+X?= =?us-ascii?Q?TOHmvV87/1i5beP3M55r6Q5WtMKa1oScMin+yDaiaI3T0J3pTn431ZXjgmRK?= =?us-ascii?Q?6ul1ira2w2Nx0qea/DEJ73KRgNdEGiUTbQaRkJ4B6aamNkPciMqM9x5ErMDe?= =?us-ascii?Q?zgs5jyN2Xc1qT924FRBug5g/wTisKiNpSHPClCSznF/3YRItsKfOT7PX5gG3?= =?us-ascii?Q?wDzmgurUS+ROgBslQSwL4CBtpodwoQ3zkN758VT+MNSMdLkibd0cPrkxkCkM?= =?us-ascii?Q?LqYGHsS3C4Pu6Czvmr59HmDGOr56Af491rYQXeeuizwLFdCj1DWjvim+bEed?= =?us-ascii?Q?CE8sAZPCMy/aQtAqyBa2olmbTQpEyWCsSIen8LmWqu81xjCL66iv37zyLB6a?= =?us-ascii?Q?NNIvD/KSAXMQxq9g35moXlrzzd18O99FmD7C8t/k8hr5To4LjoJmliktRmFl?= =?us-ascii?Q?GM+Js4g8W8iU09ytWPs1M8KfXG2Px0+G9wW0hAI84aqnwbL12i7Qu+4obBa3?= =?us-ascii?Q?WQr7jlJJNIDJeBze6yzwoBT0rDXNS0PXJzLpFazAKi3x0/W9AWIrr3cns1Jc?= =?us-ascii?Q?kbMlaFaSJ6Js2maTsTtr+IwVGV6D3/mk4qV4R+0qcPSFyn4EpZ5h8vxzr/N1?= =?us-ascii?Q?YlGYXO//GBFI2tDl8FLjkflLH1GqVUX5eBX8fgzaNamNygY3k7xHh/jDG//b?= =?us-ascii?Q?E0xmV83GmURDvtQUN1cTGVBQocQkQdWR7ait61AZr/TE4aumRvhncque1jA6?= =?us-ascii?Q?Zdq38ATvF3vYzoMh0DlHrDJtI85qVwHabmkJnJjN8MQx+6QXbJkG+OKk7XAy?= =?us-ascii?Q?5IEgCPQVpi13luV+luG9Wegs5CXBfUNO2G7qMZiTph4Ymv398jYjnO4mBaJX?= =?us-ascii?Q?vXqM2M4mBctOz353BOy9j/YcwttlSSQSNLJs2VvqZjSO3yc2Fp+TsZfGD3OY?= =?us-ascii?Q?0jO1lXHV/2sI6RVF398Non1Z2It0Okk95zITxXdskZ9C7L6eaEV7uT/4f8fP?= =?us-ascii?Q?ZBvq6WJT1GAE+ZxIYtGOxtTiDSkcXE5YSP2ijxM6qfNA3eREVpVZ7w7aNf4w?= =?us-ascii?Q?vg=3D=3D?= X-OriginatorOrg: corigine.com X-MS-Exchange-CrossTenant-Network-Message-Id: 56090a8b-f800-4013-9785-08dbc9596971 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR13MB5545.namprd13.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Oct 2023 06:23:26.4769 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: TPOFhUBLIk3/JWfGLZRVzps1opfhxJrzbempI2DBSVlYptoHJpZa28fYuvEw9e1s4NP5KIvk/99CYD0sP+cODO9t17pPsbyLD3wBouH554k= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR13MB3802 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Long Wu CI found that execution cannot reach the expression "-1" inside this statement. Coverity issue: 403097 Fixes: 5e41ab250dfa ("app/test: unit tests for bonding mode 4") Cc: tomaszx.kulasek@intel.com Cc: stable@dpdk.org Signed-off-by: Long Wu Reviewed-by: Chaoyong He Reviewed-by: Peng Zhang --- app/test/test_link_bonding_mode4.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/app/test/test_link_bonding_mode4.c b/app/test/test_link_bonding_mode4.c index 645fc1e0d4..ff13dbed93 100644 --- a/app/test/test_link_bonding_mode4.c +++ b/app/test/test_link_bonding_mode4.c @@ -641,8 +641,7 @@ bond_handshake(void) /* If response didn't send - report failure */ TEST_ASSERT_EQUAL(all_members_done, 1, "Bond handshake failed\n"); - /* If flags doesn't match - report failure */ - return all_members_done == 1 ? TEST_SUCCESS : TEST_FAILED; + return TEST_SUCCESS; } #define TEST_LACP_MEMBER_COUT RTE_DIM(test_params.member_ports) -- 2.39.1