From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0FF774235E; Wed, 11 Oct 2023 11:33:07 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 71F6440EE5; Wed, 11 Oct 2023 11:31:50 +0200 (CEST) Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by mails.dpdk.org (Postfix) with ESMTP id B3F9B40DCB for ; Wed, 11 Oct 2023 11:31:36 +0200 (CEST) Received: from kwepemi500020.china.huawei.com (unknown [172.30.72.56]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4S56qv31kqzLqKc for ; Wed, 11 Oct 2023 17:27:39 +0800 (CST) Received: from localhost.localdomain (10.67.165.2) by kwepemi500020.china.huawei.com (7.221.188.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.31; Wed, 11 Oct 2023 17:31:35 +0800 From: Jie Hai To: , Ziyang Xuan , Xiaoyun Wang , Guoyang Zhou CC: , , Subject: [PATCH v5 16/40] net/hinic: check RSS hash algorithms Date: Wed, 11 Oct 2023 17:27:41 +0800 Message-ID: <20231011092805.693171-17-haijie1@huawei.com> X-Mailer: git-send-email 2.30.0 In-Reply-To: <20231011092805.693171-1-haijie1@huawei.com> References: <20230908080030.3837515-1-haijie1@huawei.com> <20231011092805.693171-1-haijie1@huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.67.165.2] X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To kwepemi500020.china.huawei.com (7.221.188.8) X-CFilter-Loop: Reflected X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org A new field 'algorithm' has been added to rss_conf, check it in case of ignoring unsupported values. Signed-off-by: Jie Hai --- drivers/net/hinic/hinic_pmd_ethdev.c | 3 +++ drivers/net/hinic/hinic_pmd_rx.c | 3 +++ 2 files changed, 6 insertions(+) diff --git a/drivers/net/hinic/hinic_pmd_ethdev.c b/drivers/net/hinic/hinic_pmd_ethdev.c index 7aa5e7d8e929..e818dc939073 100644 --- a/drivers/net/hinic/hinic_pmd_ethdev.c +++ b/drivers/net/hinic/hinic_pmd_ethdev.c @@ -1937,6 +1937,9 @@ static int hinic_rss_hash_update(struct rte_eth_dev *dev, return HINIC_OK; } + if (rss_conf->algorithm != RTE_ETH_HASH_FUNCTION_DEFAULT) + return HINIC_ERROR; + if (rss_conf->rss_key_len > HINIC_RSS_KEY_SIZE) { PMD_DRV_LOG(ERR, "Invalid rss key, rss_key_len: %d", rss_conf->rss_key_len); diff --git a/drivers/net/hinic/hinic_pmd_rx.c b/drivers/net/hinic/hinic_pmd_rx.c index 7adb6e365993..7736b61c0b0f 100644 --- a/drivers/net/hinic/hinic_pmd_rx.c +++ b/drivers/net/hinic/hinic_pmd_rx.c @@ -670,6 +670,9 @@ int hinic_rx_configure(struct rte_eth_dev *dev) goto rss_config_err; } + if (rss_conf.algorithm != RTE_ETH_HASH_FUNCTION_DEFAULT) + goto rss_config_err; + err = hinic_rss_init(nic_dev, NULL, &rss_conf); if (err) { PMD_DRV_LOG(ERR, "Init rss failed"); -- 2.30.0