From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C4AC44235E; Wed, 11 Oct 2023 11:34:41 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E71EB42D6B; Wed, 11 Oct 2023 11:32:10 +0200 (CEST) Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by mails.dpdk.org (Postfix) with ESMTP id EA2CF40ED6 for ; Wed, 11 Oct 2023 11:31:44 +0200 (CEST) Received: from kwepemi500020.china.huawei.com (unknown [172.30.72.56]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4S56sd4KgTzrTb6 for ; Wed, 11 Oct 2023 17:29:09 +0800 (CST) Received: from localhost.localdomain (10.67.165.2) by kwepemi500020.china.huawei.com (7.221.188.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.31; Wed, 11 Oct 2023 17:31:43 +0800 From: Jie Hai To: CC: , , Subject: [PATCH v5 33/40] net/tap: check RSS hash algorithms Date: Wed, 11 Oct 2023 17:27:58 +0800 Message-ID: <20231011092805.693171-34-haijie1@huawei.com> X-Mailer: git-send-email 2.30.0 In-Reply-To: <20231011092805.693171-1-haijie1@huawei.com> References: <20230908080030.3837515-1-haijie1@huawei.com> <20231011092805.693171-1-haijie1@huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.67.165.2] X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To kwepemi500020.china.huawei.com (7.221.188.8) X-CFilter-Loop: Reflected X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org A new field 'algorithm' has been added to rss_conf, check it in case of ignoring unsupported values. Signed-off-by: Jie Hai --- drivers/net/tap/rte_eth_tap.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c index b25a52655fa2..5e4813637f0b 100644 --- a/drivers/net/tap/rte_eth_tap.c +++ b/drivers/net/tap/rte_eth_tap.c @@ -1038,6 +1038,10 @@ tap_dev_configure(struct rte_eth_dev *dev) TAP_LOG(INFO, "%s: %s: RX configured queues number: %u", dev->device->name, pmd->name, dev->data->nb_rx_queues); + if (dev->data->dev_conf.rx_adv_conf.rss_conf.algorithm != + RTE_ETH_HASH_FUNCTION_DEFAULT) + return -EINVAL; + return 0; } @@ -1894,6 +1898,10 @@ tap_rss_hash_update(struct rte_eth_dev *dev, rte_errno = EINVAL; return -rte_errno; } + if (rss_conf->algorithm != RTE_ETH_HASH_FUNCTION_DEFAULT) { + rte_errno = EINVAL; + return -rte_errno; + } if (rss_conf->rss_key && rss_conf->rss_key_len) { /* * Currently TAP RSS key is hard coded -- 2.30.0