From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2407F4236A; Thu, 12 Oct 2023 03:39:00 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B19D1402BA; Thu, 12 Oct 2023 03:38:59 +0200 (CEST) Received: from mail-pf1-f169.google.com (mail-pf1-f169.google.com [209.85.210.169]) by mails.dpdk.org (Postfix) with ESMTP id 2792C40279 for ; Thu, 12 Oct 2023 03:38:58 +0200 (CEST) Received: by mail-pf1-f169.google.com with SMTP id d2e1a72fcca58-692779f583fso389259b3a.0 for ; Wed, 11 Oct 2023 18:38:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1697074737; x=1697679537; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=+pxzADw8pkAafYwpzbQVDklJIGzDCd4HxVjZF9X941E=; b=e/mNmfdCZW0QiG7bxebEOyXJ4Xah1qh5+qa5KeJ14il0ZpCO+0IRinV8urZeXKrB77 tb5eI+oFnqhkro3OptsovDveU2JdQs6ihbX/3Fzub6EYISJQeJq7xb3ZmmSd506wRoYW LDstMjqA7UbX7E4mbwcJCTOqH1itRoo5wlMqPV9fZwk9+sgKEtYIQ4UV45AvVAp/vkJw GBCbYkzdwqsM5VmNqSQM2m6aGo+3NNPHumbOky5qD4wisNPQrTSl3fcUTKf15sjEFiSk c1qLP6vL0/gvGEjOhx+NDG8uoPxdeYabQdGwbcnrY41GGRaLaj5IIiFMBMkr9u3jCpEb CxvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697074737; x=1697679537; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=+pxzADw8pkAafYwpzbQVDklJIGzDCd4HxVjZF9X941E=; b=N1q9PXiO/R9qTaOYPwD5p2A7CF+OJ5ORDtq8f1Du1sQ7AjYMSmOHMpKJUAZOXycOFO X3TJZaAqN1LItR8ktz9Pgde8KuXdm+tUlEaOkjEc88JT/RkWei53gD5g10mtOem1ydQU Xqwi1mRjblGRzTbYjEOU1UluHzk/3CHqgr5GTVS8JgK0JWfPNMBETqi0lAYdLd+5kixM mLIHy4VsUlVlrZ+Q4SbaHZiDKDZLOoZEuUD01U/LaiQLTBKTNxWfsa+qPb1ny0WqpqnB pFKpuOCIsAr8faWR4aKtZw9+QoVsVf6BaEHnC78nQ1+0/pDBwWCiiz7LcH5sJl0tl09W KPRA== X-Gm-Message-State: AOJu0YwZs2Nvre9DmiIwHDyBm2v4q1626/P/llNZzlGa3TgRJqM/Akdz 56W6UNs+B+DFtryd1KtHE1kZDg== X-Google-Smtp-Source: AGHT+IHMsgYd7dHBVHLHithn6f2t1IWAoaCyj7mqWvZW8VcacbwDrnj6z935t5WGXIHINHd0HpT6tg== X-Received: by 2002:a05:6a00:3904:b0:693:3783:4a29 with SMTP id fh4-20020a056a00390400b0069337834a29mr23654765pfb.20.1697074737199; Wed, 11 Oct 2023 18:38:57 -0700 (PDT) Received: from hermes.local (204-195-126-68.wavecable.com. [204.195.126.68]) by smtp.gmail.com with ESMTPSA id z18-20020aa791d2000000b0068ff0a633fdsm10703708pfa.131.2023.10.11.18.38.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Oct 2023 18:38:57 -0700 (PDT) Date: Wed, 11 Oct 2023 18:38:55 -0700 From: Stephen Hemminger To: Chaoyong He Cc: dev@dpdk.org, oss-drivers@corigine.com, Long Wu , Peng Zhang Subject: Re: [PATCH v2 05/11] net/nfp: adjust the log statement Message-ID: <20231011183855.2d97c582@hermes.local> In-Reply-To: <20231012012704.483828-6-chaoyong.he@corigine.com> References: <20231007023339.1546659-1-chaoyong.he@corigine.com> <20231012012704.483828-1-chaoyong.he@corigine.com> <20231012012704.483828-6-chaoyong.he@corigine.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, 12 Oct 2023 09:26:58 +0800 Chaoyong He wrote: > + PMD_RX_LOG(ERR, "mbuf overflow likely due to the RX offset.\n" > + "\t\tYour mbuf size should have extra space for" > + " RX offset=%u bytes.\n" > + "\t\tCurrently you just have %u bytes available" > + " but the received packet is %u bytes long", > + hw->rx_offset, > + rxq->mbuf_size - hw->rx_offset, > + mb->data_len); Multi-line log messages with tabs look good on command line (developer) but don't work well when application is run as a service and logging is going to syslog. Syslog doesn't like messages with newlines in them. The message is way to long. Make it shorter, and put any other notes in a comment please..