From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 99F4442355; Thu, 12 Oct 2023 17:23:31 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2BB0E4029F; Thu, 12 Oct 2023 17:23:31 +0200 (CEST) Received: from mail-ot1-f54.google.com (mail-ot1-f54.google.com [209.85.210.54]) by mails.dpdk.org (Postfix) with ESMTP id 233E74028A for ; Thu, 12 Oct 2023 17:23:30 +0200 (CEST) Received: by mail-ot1-f54.google.com with SMTP id 46e09a7af769-6c4c594c0eeso690507a34.0 for ; Thu, 12 Oct 2023 08:23:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1697124209; x=1697729009; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=E5VyqZVjfHu0mAO4OxA7Crzyhf/JS6guekq/+DJtA0U=; b=LaMBcyxLxIHFWmteGoOfB+9nPjNsyIwi81DA3i0Cf8cnqD7GLWPEbWWIv3G+BTGegr hy9qL4xV0PMxmob+V2WOdDKHaBR/PZhJmzGVIgfl0IGqbpNu87tTYvFA/nBSgU1rdZlZ TtrCdnQpM0rNgRElfOfRbTcv8jv6+CMtkcR7s4xfzeXBG7f3VpkgXlbsB8/3DkrBk7mZ 9kfxnaRXFdYO8Qt0fakQsKL5Pkt4ibuaAZ9DFfq7X6qet83wj5c8k38IT2M+VXD1iuhD j8zPmCTsbYe25aT7tedwYWJZBv+hTSBfsi6SDOom4rH0mrmMzmDUMEQ4vgxYBxxn1QZf CE5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697124209; x=1697729009; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=E5VyqZVjfHu0mAO4OxA7Crzyhf/JS6guekq/+DJtA0U=; b=aKvIxMz0A6ANwXwtvv5nNTx+rDAJcLlo5pCfEihke5H4LNgbkvuzz1SiQ6BIlkyiBZ v0HIq5L0HH5RRInXrn5wgFb5cnh90o+pi2W6SAZLYUymIcr4ciykq7t0Fusb7E3cTRrK Uvv0aM+GHRQWhwypKkbtIVo+8UHxGiceX1WcYhcA/Z5lBkQs1zCWRV7ELLebPN3ts8NU 2Cr29+jm0f9XT0/V8FI7VMURfrqHWMwquO5XjB0nGoXjxy7j1ixr2cWEH1tBfKNkNkMi CJHmGn6kCRmSf3E9CLdYCj6KyTOJt3kHnn48LgqJk1oLzxHrEKdET3Nml1h57oRUlK7P h0Fg== X-Gm-Message-State: AOJu0YwUNQ0a4BOKnu21JJDL4G8g8kTrWygY+FhAFF3DSLV5VVEED7uy wSYesIi5hD+qlAty1OB7zrmOVg== X-Google-Smtp-Source: AGHT+IGwIZjOV15+2wYKKVn7dp1GvAvScaYNuSwgStRPi9qs4qN4q7mSpuK2Dl5FLP7Kl3J+KDh2eA== X-Received: by 2002:a9d:7a42:0:b0:6b9:4216:c209 with SMTP id z2-20020a9d7a42000000b006b94216c209mr25327912otm.12.1697124209277; Thu, 12 Oct 2023 08:23:29 -0700 (PDT) Received: from hermes.local (204-195-126-68.wavecable.com. [204.195.126.68]) by smtp.gmail.com with ESMTPSA id c12-20020aa78e0c000000b006933866fd21sm12014712pfr.117.2023.10.12.08.23.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Oct 2023 08:23:28 -0700 (PDT) Date: Thu, 12 Oct 2023 08:23:27 -0700 From: Stephen Hemminger To: fengchengwen Cc: Jie Hai , , Thomas Monjalon , Ferruh Yigit , Andrew Rybchenko , Ori Kam , , Subject: Re: [PATCH v5 02/40] ethdev: support setting and querying RSS algorithm Message-ID: <20231012082327.7e61878c@hermes.local> In-Reply-To: References: <20230908080030.3837515-1-haijie1@huawei.com> <20231011092805.693171-1-haijie1@huawei.com> <20231011092805.693171-3-haijie1@huawei.com> <20231011103936.5ffcdd73@hermes.local> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, 12 Oct 2023 10:21:51 +0800 fengchengwen wrote: > > Rather than having every driver check the algorithm, why not handle this like > > other features in DPDK (which may mean API/ABI changes). > > > > Add a field rss_algo_capa which is bit field of available RSS functions. > > Then the check for algorithm can be done in generic code. There a couple > > of reserved fields that could be used. > > +1 for add a field > > But there are two ways to config rss: ethdev-ops, ethdev-rteflow-ops, should distinguish them ? or just define for ethdev-ops ? One field is likely to be enough. I would expect that if driver accepts RSS for rte flow, it would also take same RSS setting for non flow case.