* [PATCH] net/virtio: fixed missing next flag when sending packets in packed mode
@ 2023-10-09 13:06 liufengjiang.0426
2023-10-10 2:08 ` [PATCH v2] " liufengjiang.0426
0 siblings, 1 reply; 10+ messages in thread
From: liufengjiang.0426 @ 2023-10-09 13:06 UTC (permalink / raw)
To: dev; +Cc: maxime.coquelin, chenbo.xia, zhangziqian.1
When the packets is sent in packed mode, and the packets data and
virtio-header are divided into two desc, set the next flag of virtio-header desc
Bugzilla ID: 1295
Fixes: 892dc798fa9c ("net/virtio: implement Tx path for packed queues")
Signed-off-by: liufengjiang.0426 <liufengjiang.0426@bytedance.com>
---
drivers/net/virtio/virtqueue.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/virtio/virtqueue.h b/drivers/net/virtio/virtqueue.h
index 9d4aba11a3..4e9f2d0358 100644
--- a/drivers/net/virtio/virtqueue.h
+++ b/drivers/net/virtio/virtqueue.h
@@ -672,6 +672,7 @@ virtqueue_enqueue_xmit_packed(struct virtnet_tx *txvq, struct rte_mbuf *cookie,
*/
start_dp[idx].addr = txvq->hdr_mem + RTE_PTR_DIFF(&txr[idx].tx_hdr, txr);
start_dp[idx].len = vq->hw->vtnet_hdr_size;
+ head_flags |= VRING_DESC_F_NEXT;
hdr = (struct virtio_net_hdr *)&txr[idx].tx_hdr;
idx++;
if (idx >= vq->vq_nentries) {
--
2.37.0.windows.1
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH v2] net/virtio: fixed missing next flag when sending packets in packed mode
2023-10-09 13:06 [PATCH] net/virtio: fixed missing next flag when sending packets in packed mode liufengjiang.0426
@ 2023-10-10 2:08 ` liufengjiang.0426
2023-10-10 7:12 ` Maxime Coquelin
2023-10-17 6:01 ` [PATCH] " liufengjiang.0426
0 siblings, 2 replies; 10+ messages in thread
From: liufengjiang.0426 @ 2023-10-10 2:08 UTC (permalink / raw)
To: dev; +Cc: maxime.coquelin, chenbo.xia, zhangziqian.1
When the packets is sent in packed mode, and the packets data and
virtio-header are divided into two desc, set the next flag of
virtio-header desc
>> Fix the warning that a single line of commit log exceeds 75 chars
Bugzilla ID: 1295
Fixes: 892dc798fa9c ("net/virtio: implement Tx path for packed queues")
Signed-off-by: liufengjiang.0426 <liufengjiang.0426@bytedance.com>
---
drivers/net/virtio/virtqueue.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/virtio/virtqueue.h b/drivers/net/virtio/virtqueue.h
index 9d4aba11a3..4e9f2d0358 100644
--- a/drivers/net/virtio/virtqueue.h
+++ b/drivers/net/virtio/virtqueue.h
@@ -672,6 +672,7 @@ virtqueue_enqueue_xmit_packed(struct virtnet_tx *txvq, struct rte_mbuf *cookie,
*/
start_dp[idx].addr = txvq->hdr_mem + RTE_PTR_DIFF(&txr[idx].tx_hdr, txr);
start_dp[idx].len = vq->hw->vtnet_hdr_size;
+ head_flags |= VRING_DESC_F_NEXT;
hdr = (struct virtio_net_hdr *)&txr[idx].tx_hdr;
idx++;
if (idx >= vq->vq_nentries) {
--
2.37.0.windows.1
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v2] net/virtio: fixed missing next flag when sending packets in packed mode
2023-10-10 2:08 ` [PATCH v2] " liufengjiang.0426
@ 2023-10-10 7:12 ` Maxime Coquelin
2023-10-12 13:56 ` Maxime Coquelin
2023-10-17 6:01 ` [PATCH] " liufengjiang.0426
1 sibling, 1 reply; 10+ messages in thread
From: Maxime Coquelin @ 2023-10-10 7:12 UTC (permalink / raw)
To: liufengjiang.0426, dev; +Cc: chenbo.xia, zhangziqian.1
Hi,
Thanks for investigating the issue and proposing a fix!
On 10/10/23 04:08, liufengjiang.0426 wrote:
> When the packets is sent in packed mode, and the packets data and
> virtio-header are divided into two desc, set the next flag of
> virtio-header desc
>
>>> Fix the warning that a single line of commit log exceeds 75 chars
The changelog should not be part of the commit message.
>
> Bugzilla ID: 1295
> Fixes: 892dc798fa9c ("net/virtio: implement Tx path for packed queues")
>
> Signed-off-by: liufengjiang.0426 <liufengjiang.0426@bytedance.com>
Could you please sign-off with your full name?
> ---
The changelog should be placed here.
> drivers/net/virtio/virtqueue.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/virtio/virtqueue.h b/drivers/net/virtio/virtqueue.h
> index 9d4aba11a3..4e9f2d0358 100644
> --- a/drivers/net/virtio/virtqueue.h
> +++ b/drivers/net/virtio/virtqueue.h
> @@ -672,6 +672,7 @@ virtqueue_enqueue_xmit_packed(struct virtnet_tx *txvq, struct rte_mbuf *cookie,
> */
> start_dp[idx].addr = txvq->hdr_mem + RTE_PTR_DIFF(&txr[idx].tx_hdr, txr);
> start_dp[idx].len = vq->hw->vtnet_hdr_size;
> + head_flags |= VRING_DESC_F_NEXT;
> hdr = (struct virtio_net_hdr *)&txr[idx].tx_hdr;
> idx++;
> if (idx >= vq->vq_nentries) {
Otherwise, the fix look good to me.
With above small changes, it will be good for me.
Thanks,
Maxime
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v2] net/virtio: fixed missing next flag when sending packets in packed mode
2023-10-10 7:12 ` Maxime Coquelin
@ 2023-10-12 13:56 ` Maxime Coquelin
0 siblings, 0 replies; 10+ messages in thread
From: Maxime Coquelin @ 2023-10-12 13:56 UTC (permalink / raw)
To: liufengjiang.0426, dev; +Cc: chenbo.xia, zhangziqian.1
Hi,
On 10/10/23 09:12, Maxime Coquelin wrote:
> Hi,
>
> Thanks for investigating the issue and proposing a fix!
>
> On 10/10/23 04:08, liufengjiang.0426 wrote:
>> When the packets is sent in packed mode, and the packets data and
>> virtio-header are divided into two desc, set the next flag of
>> virtio-header desc
>>
>>>> Fix the warning that a single line of commit log exceeds 75 chars
>
> The changelog should not be part of the commit message.
>
>>
>> Bugzilla ID: 1295
>> Fixes: 892dc798fa9c ("net/virtio: implement Tx path for packed queues")
>>
>> Signed-off-by: liufengjiang.0426 <liufengjiang.0426@bytedance.com>
>
> Could you please sign-off with your full name?
Gentle reminder. No need to resubmit, just reply here with your full
name.
Thanks!
Maxime
>
>
>> ---
>
> The changelog should be placed here.
>
>> drivers/net/virtio/virtqueue.h | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/net/virtio/virtqueue.h
>> b/drivers/net/virtio/virtqueue.h
>> index 9d4aba11a3..4e9f2d0358 100644
>> --- a/drivers/net/virtio/virtqueue.h
>> +++ b/drivers/net/virtio/virtqueue.h
>> @@ -672,6 +672,7 @@ virtqueue_enqueue_xmit_packed(struct virtnet_tx
>> *txvq, struct rte_mbuf *cookie,
>> */
>> start_dp[idx].addr = txvq->hdr_mem +
>> RTE_PTR_DIFF(&txr[idx].tx_hdr, txr);
>> start_dp[idx].len = vq->hw->vtnet_hdr_size;
>> + head_flags |= VRING_DESC_F_NEXT;
>> hdr = (struct virtio_net_hdr *)&txr[idx].tx_hdr;
>> idx++;
>> if (idx >= vq->vq_nentries) {
>
> Otherwise, the fix look good to me.
> With above small changes, it will be good for me.
>
> Thanks,
> Maxime
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH] net/virtio: fixed missing next flag when sending packets in packed mode
2023-10-10 2:08 ` [PATCH v2] " liufengjiang.0426
2023-10-10 7:12 ` Maxime Coquelin
@ 2023-10-17 6:01 ` liufengjiang.0426
2023-10-17 7:04 ` Fengjiang Liu
1 sibling, 1 reply; 10+ messages in thread
From: liufengjiang.0426 @ 2023-10-17 6:01 UTC (permalink / raw)
To: chenbo.xia, dev, maxime.coquelin; +Cc: zhangziqian.1, Fengjiang Liu
When the packets is sent in packed mode, and the packets data and
virtio-header are divided into two desc, set the next flag of
virtio-header desc
Bugzilla ID: 1295
Fixes: 892dc798fa9c ("net/virtio: implement Tx path for packed queues")
Signed-off-by: Fengjiang Liu <liufengjiang.0426@bytedance.com>
---
drivers/net/virtio/virtqueue.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/virtio/virtqueue.h b/drivers/net/virtio/virtqueue.h
index 9d4aba11a3..4e9f2d0358 100644
--- a/drivers/net/virtio/virtqueue.h
+++ b/drivers/net/virtio/virtqueue.h
@@ -672,6 +672,7 @@ virtqueue_enqueue_xmit_packed(struct virtnet_tx *txvq, struct rte_mbuf *cookie,
*/
start_dp[idx].addr = txvq->hdr_mem + RTE_PTR_DIFF(&txr[idx].tx_hdr, txr);
start_dp[idx].len = vq->hw->vtnet_hdr_size;
+ head_flags |= VRING_DESC_F_NEXT;
hdr = (struct virtio_net_hdr *)&txr[idx].tx_hdr;
idx++;
if (idx >= vq->vq_nentries) {
--
2.37.0.windows.1
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH] net/virtio: fixed missing next flag when sending packets in packed mode
2023-10-17 6:01 ` [PATCH] " liufengjiang.0426
@ 2023-10-17 7:04 ` Fengjiang Liu
0 siblings, 0 replies; 10+ messages in thread
From: Fengjiang Liu @ 2023-10-17 7:04 UTC (permalink / raw)
To: chenbo.xia, dev, maxime.coquelin; +Cc: zhangziqian.1, liufengjiang.0426
From: "liufengjiang.0426" <liufengjiang.0426@bytedance.com>
When the packets is sent in packed mode, and the packets data and
virtio-header are divided into two desc, set the next flag of
virtio-header desc
Bugzilla ID: 1295
Fixes: 892dc798fa9c ("net/virtio: implement Tx path for packed queues")
Signed-off-by: Fengjiang Liu <liufengjiang.0426@bytedance.com>
---
drivers/net/virtio/virtqueue.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/virtio/virtqueue.h b/drivers/net/virtio/virtqueue.h
index 9d4aba11a3..4e9f2d0358 100644
--- a/drivers/net/virtio/virtqueue.h
+++ b/drivers/net/virtio/virtqueue.h
@@ -672,6 +672,7 @@ virtqueue_enqueue_xmit_packed(struct virtnet_tx *txvq, struct rte_mbuf *cookie,
*/
start_dp[idx].addr = txvq->hdr_mem + RTE_PTR_DIFF(&txr[idx].tx_hdr, txr);
start_dp[idx].len = vq->hw->vtnet_hdr_size;
+ head_flags |= VRING_DESC_F_NEXT;
hdr = (struct virtio_net_hdr *)&txr[idx].tx_hdr;
idx++;
if (idx >= vq->vq_nentries) {
--
2.37.0.windows.1
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] net/virtio: fixed missing next flag when sending packets in packed mode
2023-10-17 7:26 Fengjiang Liu
2023-10-17 7:32 ` Maxime Coquelin
@ 2023-10-25 12:24 ` Maxime Coquelin
1 sibling, 0 replies; 10+ messages in thread
From: Maxime Coquelin @ 2023-10-25 12:24 UTC (permalink / raw)
To: Fengjiang Liu, dev; +Cc: zhangziqian.1
On 10/17/23 09:26, Fengjiang Liu wrote:
> When the packets is sent in packed mode, and the packets data and
> virtio-header are divided into two desc, set the next flag of
> virtio-header desc
>
> Bugzilla ID: 1295
> Fixes: 892dc798fa9c ("net/virtio: implement Tx path for packed queues")
>
> Signed-off-by: Fengjiang Liu <liufengjiang.0426@bytedance.com>
> ---
> drivers/net/virtio/virtqueue.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/virtio/virtqueue.h b/drivers/net/virtio/virtqueue.h
> index 9d4aba11a3..4e9f2d0358 100644
> --- a/drivers/net/virtio/virtqueue.h
> +++ b/drivers/net/virtio/virtqueue.h
> @@ -672,6 +672,7 @@ virtqueue_enqueue_xmit_packed(struct virtnet_tx *txvq, struct rte_mbuf *cookie,
> */
> start_dp[idx].addr = txvq->hdr_mem + RTE_PTR_DIFF(&txr[idx].tx_hdr, txr);
> start_dp[idx].len = vq->hw->vtnet_hdr_size;
> + head_flags |= VRING_DESC_F_NEXT;
> hdr = (struct virtio_net_hdr *)&txr[idx].tx_hdr;
> idx++;
> if (idx >= vq->vq_nentries) {
Applied to next-virtio/for-next-net
Thanks,
Maxime
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] net/virtio: fixed missing next flag when sending packets in packed mode
2023-10-17 7:26 Fengjiang Liu
@ 2023-10-17 7:32 ` Maxime Coquelin
2023-10-25 12:24 ` Maxime Coquelin
1 sibling, 0 replies; 10+ messages in thread
From: Maxime Coquelin @ 2023-10-17 7:32 UTC (permalink / raw)
To: Fengjiang Liu, dev; +Cc: zhangziqian.1
Hi,
On 10/17/23 09:26, Fengjiang Liu wrote:
> When the packets is sent in packed mode, and the packets data and
> virtio-header are divided into two desc, set the next flag of
> virtio-header desc
>
> Bugzilla ID: 1295
> Fixes: 892dc798fa9c ("net/virtio: implement Tx path for packed queues")
>
> Signed-off-by: Fengjiang Liu <liufengjiang.0426@bytedance.com>
> ---
> drivers/net/virtio/virtqueue.h | 1 +
> 1 file changed, 1 insertion(+)
>
No need to resend so many new versions :)
(For new patches, don't forget to increase the revision number).
Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
Thanks,
Maxime
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH] net/virtio: fixed missing next flag when sending packets in packed mode
@ 2023-10-17 7:26 Fengjiang Liu
2023-10-17 7:32 ` Maxime Coquelin
2023-10-25 12:24 ` Maxime Coquelin
0 siblings, 2 replies; 10+ messages in thread
From: Fengjiang Liu @ 2023-10-17 7:26 UTC (permalink / raw)
To: dev; +Cc: maxime.coquelin, zhangziqian.1
When the packets is sent in packed mode, and the packets data and
virtio-header are divided into two desc, set the next flag of
virtio-header desc
Bugzilla ID: 1295
Fixes: 892dc798fa9c ("net/virtio: implement Tx path for packed queues")
Signed-off-by: Fengjiang Liu <liufengjiang.0426@bytedance.com>
---
drivers/net/virtio/virtqueue.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/virtio/virtqueue.h b/drivers/net/virtio/virtqueue.h
index 9d4aba11a3..4e9f2d0358 100644
--- a/drivers/net/virtio/virtqueue.h
+++ b/drivers/net/virtio/virtqueue.h
@@ -672,6 +672,7 @@ virtqueue_enqueue_xmit_packed(struct virtnet_tx *txvq, struct rte_mbuf *cookie,
*/
start_dp[idx].addr = txvq->hdr_mem + RTE_PTR_DIFF(&txr[idx].tx_hdr, txr);
start_dp[idx].len = vq->hw->vtnet_hdr_size;
+ head_flags |= VRING_DESC_F_NEXT;
hdr = (struct virtio_net_hdr *)&txr[idx].tx_hdr;
idx++;
if (idx >= vq->vq_nentries) {
--
2.37.0.windows.1
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH] net/virtio: fixed missing next flag when sending packets in packed mode
@ 2023-10-17 7:11 Fengjiang Liu
0 siblings, 0 replies; 10+ messages in thread
From: Fengjiang Liu @ 2023-10-17 7:11 UTC (permalink / raw)
To: dev; +Cc: maxime.coquelin, zhangziqian.1, liufengjiang.0426
From: "liufengjiang.0426" <liufengjiang.0426@bytedance.com>
When the packets is sent in packed mode, and the packets data and
virtio-header are divided into two desc, set the next flag of
virtio-header desc
Bugzilla ID: 1295
Fixes: 892dc798fa9c ("net/virtio: implement Tx path for packed queues")
Signed-off-by: Fengjiang Liu <liufengjiang.0426@bytedance.com>
---
drivers/net/virtio/virtqueue.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/virtio/virtqueue.h b/drivers/net/virtio/virtqueue.h
index 9d4aba11a3..4e9f2d0358 100644
--- a/drivers/net/virtio/virtqueue.h
+++ b/drivers/net/virtio/virtqueue.h
@@ -672,6 +672,7 @@ virtqueue_enqueue_xmit_packed(struct virtnet_tx *txvq, struct rte_mbuf *cookie,
*/
start_dp[idx].addr = txvq->hdr_mem + RTE_PTR_DIFF(&txr[idx].tx_hdr, txr);
start_dp[idx].len = vq->hw->vtnet_hdr_size;
+ head_flags |= VRING_DESC_F_NEXT;
hdr = (struct virtio_net_hdr *)&txr[idx].tx_hdr;
idx++;
if (idx >= vq->vq_nentries) {
--
2.37.0.windows.1
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2023-10-25 12:24 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-10-09 13:06 [PATCH] net/virtio: fixed missing next flag when sending packets in packed mode liufengjiang.0426
2023-10-10 2:08 ` [PATCH v2] " liufengjiang.0426
2023-10-10 7:12 ` Maxime Coquelin
2023-10-12 13:56 ` Maxime Coquelin
2023-10-17 6:01 ` [PATCH] " liufengjiang.0426
2023-10-17 7:04 ` Fengjiang Liu
2023-10-17 7:11 Fengjiang Liu
2023-10-17 7:26 Fengjiang Liu
2023-10-17 7:32 ` Maxime Coquelin
2023-10-25 12:24 ` Maxime Coquelin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).