* [PATCH] eal: remove return from functions declared void return type
@ 2023-10-17 13:03 Tyler Retzlaff
2023-10-17 13:14 ` Morten Brørup
0 siblings, 1 reply; 5+ messages in thread
From: Tyler Retzlaff @ 2023-10-17 13:03 UTC (permalink / raw)
To: dev; +Cc: Anatoly Burakov, Tyler Retzlaff
Remove return from rte_free and eal_free_no_trace both functions are
declared to have a return type of void so they shouldn't return a value.
Signed-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>
---
lib/eal/common/rte_malloc.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/eal/common/rte_malloc.c b/lib/eal/common/rte_malloc.c
index ebafef3..9db0c39 100644
--- a/lib/eal/common/rte_malloc.c
+++ b/lib/eal/common/rte_malloc.c
@@ -41,13 +41,13 @@
void
rte_free(void *addr)
{
- return mem_free(addr, true);
+ mem_free(addr, true);
}
void
eal_free_no_trace(void *addr)
{
- return mem_free(addr, false);
+ mem_free(addr, false);
}
static void *
--
1.8.3.1
^ permalink raw reply [flat|nested] 5+ messages in thread* RE: [PATCH] eal: remove return from functions declared void return type
2023-10-17 13:03 [PATCH] eal: remove return from functions declared void return type Tyler Retzlaff
@ 2023-10-17 13:14 ` Morten Brørup
2023-10-17 17:51 ` Patrick Robb
2023-10-26 8:42 ` David Marchand
0 siblings, 2 replies; 5+ messages in thread
From: Morten Brørup @ 2023-10-17 13:14 UTC (permalink / raw)
To: Tyler Retzlaff, dev; +Cc: Anatoly Burakov
> From: Tyler Retzlaff [mailto:roretzla@linux.microsoft.com]
> Sent: Tuesday, 17 October 2023 15.04
>
> Remove return from rte_free and eal_free_no_trace both functions are
> declared to have a return type of void so they shouldn't return a value.
>
> Signed-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>
> ---
Reviewed-by: Morten Brørup <mb@smartsharesystems.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] eal: remove return from functions declared void return type
2023-10-17 13:14 ` Morten Brørup
@ 2023-10-17 17:51 ` Patrick Robb
2023-10-17 19:29 ` Tyler Retzlaff
2023-10-26 8:42 ` David Marchand
1 sibling, 1 reply; 5+ messages in thread
From: Patrick Robb @ 2023-10-17 17:51 UTC (permalink / raw)
To: Morten Brørup; +Cc: Tyler Retzlaff, dev, Anatoly Burakov
[-- Attachment #1: Type: text/plain, Size: 101 bytes --]
Recheck-request: iol-broadcom-Functional
Sorry, this series was affected by an infra failure today.
[-- Attachment #2: Type: text/html, Size: 611 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] eal: remove return from functions declared void return type
2023-10-17 17:51 ` Patrick Robb
@ 2023-10-17 19:29 ` Tyler Retzlaff
0 siblings, 0 replies; 5+ messages in thread
From: Tyler Retzlaff @ 2023-10-17 19:29 UTC (permalink / raw)
To: Patrick Robb; +Cc: Morten Brørup, dev, Anatoly Burakov
On Tue, Oct 17, 2023 at 01:51:39PM -0400, Patrick Robb wrote:
> Recheck-request: iol-broadcom-Functional
>
> Sorry, this series was affected by an infra failure today.
No big deal, I haven't got a lot of concerns over the correctness of
this particular series. :)
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] eal: remove return from functions declared void return type
2023-10-17 13:14 ` Morten Brørup
2023-10-17 17:51 ` Patrick Robb
@ 2023-10-26 8:42 ` David Marchand
1 sibling, 0 replies; 5+ messages in thread
From: David Marchand @ 2023-10-26 8:42 UTC (permalink / raw)
To: Tyler Retzlaff; +Cc: dev, Anatoly Burakov, Morten Brørup
On Tue, Oct 17, 2023 at 3:15 PM Morten Brørup <mb@smartsharesystems.com> wrote:
>
> > From: Tyler Retzlaff [mailto:roretzla@linux.microsoft.com]
> > Sent: Tuesday, 17 October 2023 15.04
> >
> > Remove return from rte_free and eal_free_no_trace both functions are
> > declared to have a return type of void so they shouldn't return a value.
> >
> > Signed-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>
> Reviewed-by: Morten Brørup <mb@smartsharesystems.com>
Applied, thanks.
--
David Marchand
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-10-26 8:42 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-10-17 13:03 [PATCH] eal: remove return from functions declared void return type Tyler Retzlaff
2023-10-17 13:14 ` Morten Brørup
2023-10-17 17:51 ` Patrick Robb
2023-10-17 19:29 ` Tyler Retzlaff
2023-10-26 8:42 ` David Marchand
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).