* [PATCH] ethdev: fix incorrect function name in comment
@ 2023-10-20 13:05 Bruce Richardson
2023-10-20 15:12 ` Ferruh Yigit
0 siblings, 1 reply; 4+ messages in thread
From: Bruce Richardson @ 2023-10-20 13:05 UTC (permalink / raw)
To: dev; +Cc: Ferruh Yigit, Bruce Richardson, stable
For those using the function comments as a guide, provide the name of
the correct callback function to use when wanting to count dropped
packets from the ethdev tx buffering system.
Fixes: d6c99e62c852 ("ethdev: add buffered Tx")
Cc: stable@dpdk.org
Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
---
lib/ethdev/rte_ethdev.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/ethdev/rte_ethdev.h b/lib/ethdev/rte_ethdev.h
index 85b9af7a02..2fd3cd808d 100644
--- a/lib/ethdev/rte_ethdev.h
+++ b/lib/ethdev/rte_ethdev.h
@@ -3732,7 +3732,7 @@ rte_eth_tx_buffer_init(struct rte_eth_dev_tx_buffer *buffer, uint16_t size);
* for example, to count dropped packets, or to retry transmission of packets
* which cannot be sent, this function should be used to register a suitable
* callback function to implement the desired behaviour.
- * The example callback "rte_eth_count_unsent_packet_callback()" is also
+ * The example callback "rte_eth_tx_buffer_count_callback()" is also
* provided as reference.
*
* @param buffer
--
2.39.2
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ethdev: fix incorrect function name in comment
2023-10-20 13:05 [PATCH] ethdev: fix incorrect function name in comment Bruce Richardson
@ 2023-10-20 15:12 ` Ferruh Yigit
2023-10-21 4:10 ` lihuisong (C)
0 siblings, 1 reply; 4+ messages in thread
From: Ferruh Yigit @ 2023-10-20 15:12 UTC (permalink / raw)
To: Bruce Richardson, dev; +Cc: stable
On 10/20/2023 2:05 PM, Bruce Richardson wrote:
> For those using the function comments as a guide, provide the name of
> the correct callback function to use when wanting to count dropped
> packets from the ethdev tx buffering system.
>
> Fixes: d6c99e62c852 ("ethdev: add buffered Tx")
> Cc: stable@dpdk.org
>
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
>
Acked-by: Ferruh Yigit <ferruh.yigit@amd.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ethdev: fix incorrect function name in comment
2023-10-20 15:12 ` Ferruh Yigit
@ 2023-10-21 4:10 ` lihuisong (C)
2023-10-26 15:23 ` Ferruh Yigit
0 siblings, 1 reply; 4+ messages in thread
From: lihuisong (C) @ 2023-10-21 4:10 UTC (permalink / raw)
To: Ferruh Yigit, Bruce Richardson, dev; +Cc: stable
在 2023/10/20 23:12, Ferruh Yigit 写道:
> On 10/20/2023 2:05 PM, Bruce Richardson wrote:
>> For those using the function comments as a guide, provide the name of
>> the correct callback function to use when wanting to count dropped
>> packets from the ethdev tx buffering system.
>>
>> Fixes: d6c99e62c852 ("ethdev: add buffered Tx")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
>>
> Acked-by: Ferruh Yigit <ferruh.yigit@amd.com>
correct, rte_eth_count_unsent_packet_callback is not even exist.
Acked-by: Huisong Li <lihuisong@huawei.com>
>
> .
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ethdev: fix incorrect function name in comment
2023-10-21 4:10 ` lihuisong (C)
@ 2023-10-26 15:23 ` Ferruh Yigit
0 siblings, 0 replies; 4+ messages in thread
From: Ferruh Yigit @ 2023-10-26 15:23 UTC (permalink / raw)
To: lihuisong (C), Bruce Richardson, dev; +Cc: stable
On 10/21/2023 5:10 AM, lihuisong (C) wrote:
>
> 在 2023/10/20 23:12, Ferruh Yigit 写道:
>> On 10/20/2023 2:05 PM, Bruce Richardson wrote:
>>> For those using the function comments as a guide, provide the name of
>>> the correct callback function to use when wanting to count dropped
>>> packets from the ethdev tx buffering system.
>>>
>>> Fixes: d6c99e62c852 ("ethdev: add buffered Tx")
>>> Cc: stable@dpdk.org
>>>
>>> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
>>>
>> Acked-by: Ferruh Yigit <ferruh.yigit@amd.com>
>
> correct, rte_eth_count_unsent_packet_callback is not even exist.
>
> Acked-by: Huisong Li <lihuisong@huawei.com>
>
Applied to dpdk-next-net/main, thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-10-26 15:23 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-10-20 13:05 [PATCH] ethdev: fix incorrect function name in comment Bruce Richardson
2023-10-20 15:12 ` Ferruh Yigit
2023-10-21 4:10 ` lihuisong (C)
2023-10-26 15:23 ` Ferruh Yigit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).