From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B23AA43208; Thu, 26 Oct 2023 15:43:44 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id ADA4342E25; Thu, 26 Oct 2023 15:43:39 +0200 (CEST) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by mails.dpdk.org (Postfix) with ESMTP id 0E6874003C for ; Thu, 26 Oct 2023 15:43:24 +0200 (CEST) Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id A544E5C0297; Thu, 26 Oct 2023 09:43:22 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Thu, 26 Oct 2023 09:43:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm3; t=1698327802; x= 1698414202; bh=tJsoq4osbhl3cBjkpLzoGK3txAEtcCtD4Bqu//R44yc=; b=E wYHq6HWdzKJHMzJR/fCnQXDgI9HDvjwxCJ95+xN6ab4VU5ly0w/5sJxfZtMI+Gfr kTFySAJ+n7TeFwcHMWtqsCG6CVF89QmQrCLILARqqDf2usyf4WhVIAoQepzxuCDX HUNNPrOKlN2cDUrvLZAvaDFD9+yiNoAxUrejtrkNrwZrML/EMAh/S2OibitS8Y/m vXnCiu9aqVOUm9Rb3N8yBzWledVllThw21XpyLVNXuPPQ/uCOmcQ190IMzdKrA9v oARuV6/ga+Ig/frxmNlm7ONwCdsYumQRXhWHClaE6ENr1DASrHn6zKMdWHzEQfHj KqKzhh/4KuMzU0NkIgk1Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1698327802; x= 1698414202; bh=tJsoq4osbhl3cBjkpLzoGK3txAEtcCtD4Bqu//R44yc=; b=S JZ5NOTQ1E6bF1awf0okioEQzq+Yjl4b3BLFgxTl/IoOXe+upxGi4JcK3l31P76jD M/d08Sca10etSB8MJvEf8w6RqpaeN+f2iXT3FuAPOpdq3jVUMryGCD5X4NzgXsUm GofNNh+tQNXo6o/5zk2DEhSTZjCLRa/uDWMALxeVlpPG0YvQf+yzm96LMH1Uh+rl 8BQEHsPRoTu27jm3EGDFj8caHteIu5zqtdVEWfrkn6b0QOjgaEiscLtlZXRqbcBh MpTEppv4Na1yZe3oUe6T4hbxW+0GDTTMM50hU57/GU+S3GcRvBnXuEC9oF3Da4Ns 5Ugn1aud5ludEN57DlMvw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrledvgdeikecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvfevufffkffojghfggfgsedtkeertdertddtnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepvdejhfdugeehvddtieejieegteeuudfgjeeukeeiledthfetveek hefhieelhfdtnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 26 Oct 2023 09:43:21 -0400 (EDT) From: Thomas Monjalon To: dev@dpdk.org Cc: David Marchand , Dmitry Kozlyuk , Narcisa Ana Maria Vasile , Dmitry Malloy , Pallavi Kadam Subject: [PATCH v4 1/2] eal: add thread yield functions Date: Thu, 26 Oct 2023 15:37:41 +0200 Message-ID: <20231026134313.1165954-2-thomas@monjalon.net> X-Mailer: git-send-email 2.42.0 In-Reply-To: <20231026134313.1165954-1-thomas@monjalon.net> References: <20231024125416.798897-1-thomas@monjalon.net> <20231026134313.1165954-1-thomas@monjalon.net> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org When running real-time threads, we may need to force scheduling kernel threads or other real-time threads. New functions are added to address these cases. The yield functions should not have any interest for normal threads. Note: other purposes may be addressed with rte_pause() or rte_delay_*(). Signed-off-by: Thomas Monjalon --- lib/eal/include/rte_thread.h | 25 +++++++++++++++++++++++++ lib/eal/unix/rte_thread.c | 17 +++++++++++++++++ lib/eal/version.map | 4 ++++ lib/eal/windows/rte_thread.c | 15 +++++++++++++++ 4 files changed, 61 insertions(+) diff --git a/lib/eal/include/rte_thread.h b/lib/eal/include/rte_thread.h index 8da9d4d3fb..f2581fe152 100644 --- a/lib/eal/include/rte_thread.h +++ b/lib/eal/include/rte_thread.h @@ -183,6 +183,31 @@ int rte_thread_join(rte_thread_t thread_id, uint32_t *value_ptr); */ int rte_thread_detach(rte_thread_t thread_id); +/** + * Allow another thread to run on the same CPU core. + * + * This is a scheduler request, with minimum latency. + * Lower priority threads may not be scheduled. + * + * Especially useful in real-time thread priority + * to schedule other real-time threads. + * @see RTE_THREAD_PRIORITY_REALTIME_CRITICAL + */ +__rte_experimental +void rte_thread_yield(void); + +/** + * Unblock a CPU core running busy in a real-time thread. + * + * This is a sleep call, giving priority to all other threads. + * + * Especially useful in real-time thread priority + * to avoid a busy loop blocking vital threads on a core. + * @see RTE_THREAD_PRIORITY_REALTIME_CRITICAL + */ +__rte_experimental +void rte_thread_yield_realtime(void); + /** * Get the id of the calling thread. * diff --git a/lib/eal/unix/rte_thread.c b/lib/eal/unix/rte_thread.c index 36a21ab2f9..d0758f23bb 100644 --- a/lib/eal/unix/rte_thread.c +++ b/lib/eal/unix/rte_thread.c @@ -5,9 +5,11 @@ #include #include +#include #include #include #include +#include #include #include @@ -227,6 +229,21 @@ rte_thread_detach(rte_thread_t thread_id) return pthread_detach((pthread_t)thread_id.opaque_id); } +void +rte_thread_yield(void) +{ + sched_yield(); +} + +void +rte_thread_yield_realtime(void) +{ + /* A simple yield may not be enough to schedule kernel threads. */ + struct timespec wait = {.tv_nsec = 1000}; + nanosleep(&wait, NULL); + usleep +} + int rte_thread_equal(rte_thread_t t1, rte_thread_t t2) { diff --git a/lib/eal/version.map b/lib/eal/version.map index e00a844805..b81ac3e3af 100644 --- a/lib/eal/version.map +++ b/lib/eal/version.map @@ -413,6 +413,10 @@ EXPERIMENTAL { # added in 23.07 rte_memzone_max_get; rte_memzone_max_set; + + # added in 23.11 + rte_thread_yield; + rte_thread_yield_realtime; }; INTERNAL { diff --git a/lib/eal/windows/rte_thread.c b/lib/eal/windows/rte_thread.c index acf648456c..ea17b5de3d 100644 --- a/lib/eal/windows/rte_thread.c +++ b/lib/eal/windows/rte_thread.c @@ -304,6 +304,21 @@ rte_thread_detach(rte_thread_t thread_id) return 0; } +void +rte_thread_yield(void) +{ + SwitchToThread(); +} + +void +rte_thread_yield_realtime(void) +{ + /* Real-time threads are not causing problems on Windows. + * A simple sleep should be more than enough. + */ + Sleep(0); +} + int rte_thread_equal(rte_thread_t t1, rte_thread_t t2) { -- 2.42.0