From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2EF9943209; Thu, 26 Oct 2023 16:22:32 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A92CA42E04; Thu, 26 Oct 2023 16:22:18 +0200 (CEST) Received: from smtp-fw-52005.amazon.com (smtp-fw-52005.amazon.com [52.119.213.156]) by mails.dpdk.org (Postfix) with ESMTP id D3FF342E04 for ; Thu, 26 Oct 2023 16:22:13 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.com; i=@amazon.com; q=dns/txt; s=amazon201209; t=1698330134; x=1729866134; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version; bh=OTWALkS8VHfO1CBfzNNZeHioLxDdt6df8GSAUyNqCXc=; b=KRqcBwzf4ixZU/IyE44xp3pYhokcWPg55U+S+qXCe7B/n+FdjQZC+21i LMKM82HzzdlW2qlYsWBHIJNc4jFVdW4EWQcu1hISG9lLHvoEPf4VDyWAt njT/graaWpmvG36Agj92b6VxIHKkYhFrox43/oU8x80LtS5wFP9rGZqeF c=; X-IronPort-AV: E=Sophos;i="6.03,253,1694736000"; d="scan'208";a="612470166" Received: from iad12-co-svc-p1-lb1-vlan3.amazon.com (HELO email-inbound-relay-pdx-2c-m6i4x-d2040ec1.us-west-2.amazon.com) ([10.43.8.6]) by smtp-border-fw-52005.iad7.amazon.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Oct 2023 14:22:11 +0000 Received: from smtpout.prod.us-west-2.prod.farcaster.email.amazon.dev (pdx2-ws-svc-p26-lb5-vlan2.pdx.amazon.com [10.39.38.66]) by email-inbound-relay-pdx-2c-m6i4x-d2040ec1.us-west-2.amazon.com (Postfix) with ESMTPS id 0DF9540D46; Thu, 26 Oct 2023 14:22:11 +0000 (UTC) Received: from EX19MTAEUB002.ant.amazon.com [10.0.17.79:30658] by smtpin.naws.eu-west-1.prod.farcaster.email.amazon.dev [10.0.21.0:2525] with esmtp (Farcaster) id 33abecb8-da78-48db-982c-3786a3c3d06d; Thu, 26 Oct 2023 14:22:10 +0000 (UTC) X-Farcaster-Flow-ID: 33abecb8-da78-48db-982c-3786a3c3d06d Received: from EX19D017EUA001.ant.amazon.com (10.252.50.71) by EX19MTAEUB002.ant.amazon.com (10.252.51.79) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.39; Thu, 26 Oct 2023 14:22:09 +0000 Received: from EX19MTAUWC001.ant.amazon.com (10.250.64.145) by EX19D017EUA001.ant.amazon.com (10.252.50.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.39; Thu, 26 Oct 2023 14:22:09 +0000 Received: from HFA15-CG15235BS.amazon.com (10.85.143.173) by mail-relay.amazon.com (10.250.64.145) with Microsoft SMTP Server id 15.2.1118.39 via Frontend Transport; Thu, 26 Oct 2023 14:22:07 +0000 From: To: CC: , , , , Subject: [PATCH v3 3/5] net/ena: report Rx overrun errors in xstats Date: Thu, 26 Oct 2023 17:21:33 +0300 Message-ID: <20231026142135.19967-4-shaibran@amazon.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20231026142135.19967-1-shaibran@amazon.com> References: <20231026142135.19967-1-shaibran@amazon.com> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Shai Brandes RX overrun error occur when a packet arrives but there are not enough free buffers in the RX ring to receive it. The driver publishes the extended statistics with the RX buffer overrun errors as reported by the device. Signed-off-by: Shai Brandes Reviewed-by: Amit Bernstein --- doc/guides/rel_notes/release_23_11.rst | 1 + drivers/net/ena/ena_ethdev.c | 4 ++++ drivers/net/ena/ena_ethdev.h | 1 + 3 files changed, 6 insertions(+) diff --git a/doc/guides/rel_notes/release_23_11.rst b/doc/guides/rel_notes/release_23_11.rst index 77731fbf6a..2666371ccd 100644 --- a/doc/guides/rel_notes/release_23_11.rst +++ b/doc/guides/rel_notes/release_23_11.rst @@ -126,6 +126,7 @@ New Features * Upgraded ENA HAL to latest version. * Added support for connection tracking allowance utilization metric. + * Added support for reporting rx overrun errors in xstats. * **Updated Intel cpfl driver.** diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c index 3e79a58541..bd9d7c6249 100644 --- a/drivers/net/ena/ena_ethdev.c +++ b/drivers/net/ena/ena_ethdev.c @@ -90,6 +90,7 @@ static const struct ena_stats ena_stats_global_strings[] = { ENA_STAT_GLOBAL_ENTRY(dev_start), ENA_STAT_GLOBAL_ENTRY(dev_stop), ENA_STAT_GLOBAL_ENTRY(tx_drops), + ENA_STAT_GLOBAL_ENTRY(rx_overruns), }; /* @@ -3906,15 +3907,18 @@ static void ena_keep_alive(void *adapter_data, struct ena_admin_aenq_keep_alive_desc *desc; uint64_t rx_drops; uint64_t tx_drops; + uint64_t rx_overruns; adapter->timestamp_wd = rte_get_timer_cycles(); desc = (struct ena_admin_aenq_keep_alive_desc *)aenq_e; rx_drops = ((uint64_t)desc->rx_drops_high << 32) | desc->rx_drops_low; tx_drops = ((uint64_t)desc->tx_drops_high << 32) | desc->tx_drops_low; + rx_overruns = ((uint64_t)desc->rx_overruns_high << 32) | desc->rx_overruns_low; adapter->drv_stats->rx_drops = rx_drops; adapter->dev_stats.tx_drops = tx_drops; + adapter->dev_stats.rx_overruns = rx_overruns; } /** diff --git a/drivers/net/ena/ena_ethdev.h b/drivers/net/ena/ena_ethdev.h index 9268d44dde..3f29764ca6 100644 --- a/drivers/net/ena/ena_ethdev.h +++ b/drivers/net/ena/ena_ethdev.h @@ -219,6 +219,7 @@ struct ena_stats_dev { * As a workaround it is being published as an extended statistic. */ u64 tx_drops; + u64 rx_overruns; }; struct ena_stats_metrics { -- 2.17.1