From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B1E0C43252; Tue, 31 Oct 2023 17:59:51 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3ED6B40284; Tue, 31 Oct 2023 17:59:51 +0100 (CET) Received: from mail-pf1-f176.google.com (mail-pf1-f176.google.com [209.85.210.176]) by mails.dpdk.org (Postfix) with ESMTP id 5FA6F400EF for ; Tue, 31 Oct 2023 17:59:50 +0100 (CET) Received: by mail-pf1-f176.google.com with SMTP id d2e1a72fcca58-6b1d1099a84so5916629b3a.1 for ; Tue, 31 Oct 2023 09:59:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1698771589; x=1699376389; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=5FDMZIQEpPRH3GxWAQtWS18Hm3oNhiVDnHL6dtV2FT0=; b=aDeLJ1dQ29W7tHxZ5UmmGjYFqhCUZ5ltBljo0S80S3VAaGDI2kpkMwCQwMZ7t9SAQ2 WNuVXtJ0KCckBY36847bmJWehtLS2zOe3TXzyr9Q+rsEC9ychCetjzVKkqQ1fs/Fqmw1 4sPfpN6CqyLZ+1VHCNxyYB0POnqHmNSUDxMamX9XnH0J4O4KXGO/lliIGrSSNt1qS5Rs 4cXA17aNeHZS5yUl6IuZ5+ja4pU+Dfhysa18d7m9CSzh+LeZF7B2qXCGP9xekzV9LSJs TCn1enhtcg8gAuLZTSR7gle/V5Olzx9r/Mw6waFR9aAUzACaW46aaL14MPmTXJuwdr8u N3mQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698771589; x=1699376389; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=5FDMZIQEpPRH3GxWAQtWS18Hm3oNhiVDnHL6dtV2FT0=; b=R8yA/v/bBsLB8kP79vyfSm70LPzi5yMfil3C3iT2nRxk2HlM4K7FYG3gDk3Pzszag7 DTuuPSp1fegpjH5ahDFJE1hz17OVm/cP8r6EUnG6GP28xazHPZUyc1KeRGbR6h1OGiBn fESBpJ0ped8fYXuYPSCtUVjnlfVy95PpiZ3M2Z+Rkr8A2rkXGNe1IHrTqgxq8FxUM/rU Bt1/H/UJEnwAXp01L1N8Dii5jx2DzuRwxfJ0ORawph8vSWACJCvPaF6hMiJQ2WKD5vM5 PDVe0IuAMFPd/twEhjWZn9LYTHY4EIwqRPFoNOEBoiZCh/z3XuSVdjIOAfspfsBxiSUQ aWsw== X-Gm-Message-State: AOJu0YyMqEZTJszaUQs0sXyd8P0eOyr0aDwmSgIjmSuO0XqNXaOFXIfo 0NhsW4SMAyUeJBYCKaHqD03pGg== X-Google-Smtp-Source: AGHT+IHW18nnB/s9RA3g/jUWkB6UPHCRrp8oDT+tOd/kuFUO6qEPaRR51gXsleWneVuG1qQ4GiRAtQ== X-Received: by 2002:a05:6a00:856:b0:6be:23dd:d62c with SMTP id q22-20020a056a00085600b006be23ddd62cmr17008556pfk.2.1698771589360; Tue, 31 Oct 2023 09:59:49 -0700 (PDT) Received: from fedora ([38.142.2.14]) by smtp.gmail.com with ESMTPSA id n24-20020aa78a58000000b006bfb91ac2afsm1536092pfa.140.2023.10.31.09.59.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 31 Oct 2023 09:59:49 -0700 (PDT) Date: Tue, 31 Oct 2023 09:59:44 -0700 From: Stephen Hemminger To: Shinae Woo Cc: dev@dpdk.org Subject: Re: [PATCH] linux/igb_uio: make module parameters visible in sysfs Message-ID: <20231031095944.17f7d3a8@fedora> In-Reply-To: <20220821231950.5957-1-shinae@alkira.net> References: <20220821231950.5957-1-shinae@alkira.net> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Sun, 21 Aug 2022 16:19:50 -0700 Shinae Woo wrote: > diff --git a/linux/igb_uio/igb_uio.c b/linux/igb_uio/igb_uio.c > index 33e0e02..c927ae6 100644 > --- a/linux/igb_uio/igb_uio.c > +++ b/linux/igb_uio/igb_uio.c > @@ -44,7 +44,7 @@ struct rte_uio_pci_dev { > }; > > static int wc_activate; > -static char *intr_mode; > +static char *intr_mode = RTE_INTR_MODE_MSIX_NAME; Since intr_mode is now initialized you can remove the code that checks for it being NULL. diff --git a/linux/igb_uio/igb_uio.c b/linux/igb_uio/igb_uio.c index aea67da..11141d4 100644 --- a/linux/igb_uio/igb_uio.c +++ b/linux/igb_uio/igb_uio.c @@ -44,7 +44,7 @@ struct rte_uio_pci_dev { }; static int wc_activate; -static char *intr_mode; +static char *intr_mode = RTE_INTR_MODE_MSIX_NAME; static enum rte_intr_mode igbuio_intr_mode_preferred = RTE_INTR_MODE_MSIX; /* sriov sysfs */ static ssize_t @@ -591,11 +591,6 @@ igbuio_pci_remove(struct pci_dev *dev) static int igbuio_config_intr_mode(char *intr_str) { - if (!intr_str) { - pr_info("Use MSIX interrupt by default\n"); - return 0; - } - if (!strcmp(intr_str, RTE_INTR_MODE_MSIX_NAME)) { igbuio_intr_mode_preferred = RTE_INTR_MODE_MSIX; pr_info("Use MSIX interrupt\n");