From: Stephen Hemminger <stephen@networkplumber.org>
To: Ferruh Yigit <ferruh.yigit@amd.com>
Cc: dev@dpdk.org, "techboard@dpdk.org" <techboard@dpdk.org>
Subject: Re: [PATCH v6 0/3] net/tap: build and fix for BPF program
Date: Thu, 2 Nov 2023 09:52:34 -0700 [thread overview]
Message-ID: <20231102095234.0e351fff@fedora> (raw)
In-Reply-To: <62d85cfd-596e-4efc-a084-e14fab932956@amd.com>
On Thu, 2 Nov 2023 15:11:10 +0000
Ferruh Yigit <ferruh.yigit@amd.com> wrote:
> > Stephen Hemminger (2):
> > net/tap: support infrastructure to build the BPF filter
> > net/tap; rebuild and update the BPF flow program
> >
>
> Thanks Stephen for fixing this.
>
>
> But considering it was broken for a while and nobody complained, and
> initial developers seems lost interest and it is relatively hard code to
> maintain, do we still want to keep this support.
>
> Can we probe again motivation and benefit of eBPF support in tap PMD,
> and if it is still relevant?
The use case was allowing an rte_flow match to a set of queues and have
the BPF program do RSS across set of rte_flow queues.
Simple non-rte_flow usage of TAP doesn't need this in most cases.
The kernel will do RSS already to multi-queue tap.
The motivation was to allow use of rte_flow in the failsafe/tap/mlx model.
This is the legacy model for use in Hyper-V/Azure. Not aware of any
application using this.
The bug fix came from Oracle, perhaps they have more context.
This fix set came from looking at old unmerged but ok patches in patchwork.
WARNING: multiple messages have this Message-ID
From: Stephen Hemminger <stephen@networkplumber.org>
To: Ferruh Yigit <ferruh.yigit@amd.com>
Cc: dev@dpdk.org, "techboard@dpdk.org" <techboard@dpdk.org>
Subject: Re: [PATCH v6 0/3] net/tap: build and fix for BPF program
Date: Thu, 2 Nov 2023 09:52:42 -0700 [thread overview]
Message-ID: <20231102095234.0e351fff@fedora> (raw)
Message-ID: <20231102165242.N-OXwso9K_R0ZnMNu8SYqjMVCHDNUIaqw4SJSH-2PG8@z> (raw)
In-Reply-To: <62d85cfd-596e-4efc-a084-e14fab932956@amd.com>
On Thu, 2 Nov 2023 15:11:10 +0000
Ferruh Yigit <ferruh.yigit@amd.com> wrote:
> > Stephen Hemminger (2):
> > net/tap: support infrastructure to build the BPF filter
> > net/tap; rebuild and update the BPF flow program
> >
>
> Thanks Stephen for fixing this.
>
>
> But considering it was broken for a while and nobody complained, and
> initial developers seems lost interest and it is relatively hard code to
> maintain, do we still want to keep this support.
>
> Can we probe again motivation and benefit of eBPF support in tap PMD,
> and if it is still relevant?
The use case was allowing an rte_flow match to a set of queues and have
the BPF program do RSS across set of rte_flow queues.
Simple non-rte_flow usage of TAP doesn't need this in most cases.
The kernel will do RSS already to multi-queue tap.
The motivation was to allow use of rte_flow in the failsafe/tap/mlx model.
This is the legacy model for use in Hyper-V/Azure. Not aware of any
application using this.
The bug fix came from Oracle, perhaps they have more context.
This fix set came from looking at old unmerged but ok patches in patchwork.
next prev parent reply other threads:[~2023-11-02 16:58 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-16 21:25 [RFC] MAINTAINERS: add status information Stephen Hemminger
2023-07-19 16:07 ` [PATCH v2] " Stephen Hemminger
2023-07-20 17:21 ` [PATCH v3] " Stephen Hemminger
2023-07-20 17:45 ` [PATCH v2 ] tap: fix build of TAP BPF program Stephen Hemminger
2023-07-20 23:25 ` [PATCH v3] " Stephen Hemminger
2023-07-21 13:05 ` Ferruh Yigit
2023-07-21 15:43 ` Stephen Hemminger
2023-07-23 2:21 ` Stephen Hemminger
2023-07-26 16:31 ` Stephen Hemminger
2023-07-22 16:32 ` [PATCH v4] " Stephen Hemminger
2023-10-31 22:08 ` [PATCH 0/3] net/tap: update and fix the " Stephen Hemminger
2023-10-31 22:08 ` [PATCH 1/3] net/tap: support infrastructure to build the BPF filter Stephen Hemminger
2023-10-31 22:08 ` [PATCH 2/3] net/tap: Fixed RSS algorithm to support fragmented packets Stephen Hemminger
2023-10-31 22:08 ` [PATCH 3/3] net/tap; rebuild and update the BPF flow program Stephen Hemminger
2023-10-31 22:42 ` [PATCH v5 0/3] net/tap: build and fix for BPF program Stephen Hemminger
2023-10-31 22:42 ` [PATCH v5 1/3] net/tap: support infrastructure to build the BPF filter Stephen Hemminger
2023-10-31 22:42 ` [PATCH v5 2/3] net/tap: Fixed RSS algorithm to support fragmented packets Stephen Hemminger
2023-10-31 22:42 ` [PATCH v5 3/3] net/tap; rebuild and update the BPF flow program Stephen Hemminger
2023-11-01 18:02 ` [PATCH v6 0/3] net/tap: build and fix for BPF program Stephen Hemminger
2023-11-01 18:02 ` [PATCH v6 1/3] net/tap: support infrastructure to build the BPF filter Stephen Hemminger
2023-11-01 18:02 ` [PATCH v6 2/3] net/tap: Fixed RSS algorithm to support fragmented packets Stephen Hemminger
2023-11-01 18:02 ` [PATCH v6 3/3] net/tap; rebuild and update the BPF flow program Stephen Hemminger
2023-11-02 15:13 ` Ferruh Yigit
2023-11-02 16:53 ` Stephen Hemminger
2023-11-02 18:25 ` Ferruh Yigit
2023-11-02 21:00 ` Ferruh Yigit
2023-11-02 21:56 ` Stephen Hemminger
2023-11-02 15:11 ` [PATCH v6 0/3] net/tap: build and fix for BPF program Ferruh Yigit
2023-11-02 16:52 ` Stephen Hemminger [this message]
2023-11-02 16:52 ` Stephen Hemminger
2023-11-02 18:35 ` Ferruh Yigit
2023-11-02 18:39 ` Stephen Hemminger
2023-11-02 15:21 ` Ferruh Yigit
2023-11-03 3:57 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231102095234.0e351fff@fedora \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@amd.com \
--cc=techboard@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).