From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id ECF9F432BB; Mon, 6 Nov 2023 18:16:23 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3E8A940E4A; Mon, 6 Nov 2023 18:16:09 +0100 (CET) Received: from mail-ej1-f47.google.com (mail-ej1-f47.google.com [209.85.218.47]) by mails.dpdk.org (Postfix) with ESMTP id D995140DD8 for ; Mon, 6 Nov 2023 18:16:07 +0100 (CET) Received: by mail-ej1-f47.google.com with SMTP id a640c23a62f3a-99357737980so711128166b.2 for ; Mon, 06 Nov 2023 09:16:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pantheon.tech; s=google; t=1699290967; x=1699895767; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=U6/AvRBkllFQ+XgMDx3380G1DrnvTmtIBIE/1+tA3H8=; b=H60mpiGrhHWh3/7wVS1R1rRLqzAlpuuYQmgdtVVF9XPEZWDY4CU6L4VJQfm/JpAlev Y0zh8tV9iHVjNXozbMP0CVr0JwhXwZWWtoLqRE/3lxl/1r9ez7tfcWHaOnVbjI2HjBj4 HsbjEnoWJryMU7c+FTjXZwHKK9pir2R5fvmSl3R7xg86u4MkQqfEzsO1IZNtmHJbub+4 rQfuPvBnxssqBmmCHrXbH4TXIfqPMDYc4e8bhRjxDJSM7Km1Urz4LhfxljeAV4tWAYnK 0U0TjuKBZCfrcPJkf64fkLfKW3joqCsSjGaituD+x2yAo95lQdLAvXC8chm1+S6e1WmB mPaw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699290967; x=1699895767; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=U6/AvRBkllFQ+XgMDx3380G1DrnvTmtIBIE/1+tA3H8=; b=CRUJBWUVxfHnjhbAZt/t1RtsjtQ246UHeOtYm6er4Sp8SrbwEKPf3CiPn9siCJL+qn IOaQhewwaEsLCPZK1NWArsKUZa7PQsy9UJS4izL0qjFQxXmj1y9Cv9AfB8v0K+JpCjDC 6e86H1Y9Ua1RJaD3wUM66dA8dzDTxCZjrOoX5I7ZpJDmhWGecZBuSJqGfdpfC1cACL2a mnRTvq7Vm9Yx9L2UOeayBgBQUnSY61T6myfzdl7UXapAulippGcxmReJ2CR460Wz3y80 8QNUv1Idgg6UVw62RUu/1+FXZuxtZl+rGSQsRthBcu+4pcK1CLjdjS16PhAMz43CEEgG Mu5g== X-Gm-Message-State: AOJu0Yw3yFFmA5fmZmufuypL/pT4ieJhnFoVUTSscS1uBCq7WhpO8Sfr rdpEsxQjFLKzekjficmxFz1Xcw== X-Google-Smtp-Source: AGHT+IHQUZLUHPfUNVjYty5xWYC83j6NcEZIfKF7pQNdOfBrnX7DWabsUTaFvXd/dh2VyUB6R4oPvA== X-Received: by 2002:a17:906:fe09:b0:994:555a:e49f with SMTP id wy9-20020a170906fe0900b00994555ae49fmr12921433ejb.31.1699290967616; Mon, 06 Nov 2023 09:16:07 -0800 (PST) Received: from jlinkes-PT-Latitude-5530.. (ip-46.34.243.197.o2inet.sk. [46.34.243.197]) by smtp.gmail.com with ESMTPSA id s10-20020a170906354a00b009b947aacb4bsm47016eja.191.2023.11.06.09.16.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Nov 2023 09:16:07 -0800 (PST) From: =?UTF-8?q?Juraj=20Linke=C5=A1?= To: thomas@monjalon.net, Honnappa.Nagarahalli@arm.com, bruce.richardson@intel.com, jspewock@iol.unh.edu, probb@iol.unh.edu, paul.szczepanek@arm.com, yoan.picchi@foss.arm.com Cc: dev@dpdk.org, =?UTF-8?q?Juraj=20Linke=C5=A1?= Subject: [PATCH v5 02/23] dts: add docstring checker Date: Mon, 6 Nov 2023 18:15:40 +0100 Message-Id: <20231106171601.160749-3-juraj.linkes@pantheon.tech> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20231106171601.160749-1-juraj.linkes@pantheon.tech> References: <20230831100407.59865-1-juraj.linkes@pantheon.tech> <20231106171601.160749-1-juraj.linkes@pantheon.tech> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Python docstrings are the in-code way to document the code. The docstring checker of choice is pydocstyle which we're executing from Pylama, but the current latest versions are not complatible due to [0], so pin the pydocstyle version to the latest working version. [0] https://github.com/klen/pylama/issues/232 Signed-off-by: Juraj Linkeš --- dts/poetry.lock | 12 ++++++------ dts/pyproject.toml | 6 +++++- 2 files changed, 11 insertions(+), 7 deletions(-) diff --git a/dts/poetry.lock b/dts/poetry.lock index f7b3b6d602..a734fa71f0 100644 --- a/dts/poetry.lock +++ b/dts/poetry.lock @@ -489,20 +489,20 @@ files = [ [[package]] name = "pydocstyle" -version = "6.3.0" +version = "6.1.1" description = "Python docstring style checker" optional = false python-versions = ">=3.6" files = [ - {file = "pydocstyle-6.3.0-py3-none-any.whl", hash = "sha256:118762d452a49d6b05e194ef344a55822987a462831ade91ec5c06fd2169d019"}, - {file = "pydocstyle-6.3.0.tar.gz", hash = "sha256:7ce43f0c0ac87b07494eb9c0b462c0b73e6ff276807f204d6b53edc72b7e44e1"}, + {file = "pydocstyle-6.1.1-py3-none-any.whl", hash = "sha256:6987826d6775056839940041beef5c08cc7e3d71d63149b48e36727f70144dc4"}, + {file = "pydocstyle-6.1.1.tar.gz", hash = "sha256:1d41b7c459ba0ee6c345f2eb9ae827cab14a7533a88c5c6f7e94923f72df92dc"}, ] [package.dependencies] -snowballstemmer = ">=2.2.0" +snowballstemmer = "*" [package.extras] -toml = ["tomli (>=1.2.3)"] +toml = ["toml"] [[package]] name = "pyflakes" @@ -837,4 +837,4 @@ jsonschema = ">=4,<5" [metadata] lock-version = "2.0" python-versions = "^3.10" -content-hash = "0b1e4a1cb8323e17e5ee5951c97e74bde6e60d0413d7b25b1803d5b2bab39639" +content-hash = "3501e97b3dadc19fe8ae179fe21b1edd2488001da9a8e86ff2bca0b86b99b89b" diff --git a/dts/pyproject.toml b/dts/pyproject.toml index 6762edfa6b..3943c87c87 100644 --- a/dts/pyproject.toml +++ b/dts/pyproject.toml @@ -25,6 +25,7 @@ PyYAML = "^6.0" types-PyYAML = "^6.0.8" fabric = "^2.7.1" scapy = "^2.5.0" +pydocstyle = "6.1.1" [tool.poetry.group.dev.dependencies] mypy = "^0.961" @@ -39,10 +40,13 @@ requires = ["poetry-core>=1.0.0"] build-backend = "poetry.core.masonry.api" [tool.pylama] -linters = "mccabe,pycodestyle,pyflakes" +linters = "mccabe,pycodestyle,pydocstyle,pyflakes" format = "pylint" max_line_length = 88 # https://black.readthedocs.io/en/stable/the_black_code_style/current_style.html#line-length +[tool.pylama.linter.pydocstyle] +convention = "google" + [tool.mypy] python_version = "3.10" enable_error_code = ["ignore-without-code"] -- 2.34.1