From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 002E8432C9; Tue, 7 Nov 2023 18:00:23 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AB14A402D4; Tue, 7 Nov 2023 18:00:23 +0100 (CET) Received: from mail-pl1-f179.google.com (mail-pl1-f179.google.com [209.85.214.179]) by mails.dpdk.org (Postfix) with ESMTP id A140A402A1 for ; Tue, 7 Nov 2023 18:00:21 +0100 (CET) Received: by mail-pl1-f179.google.com with SMTP id d9443c01a7336-1cc3bc5df96so43413645ad.2 for ; Tue, 07 Nov 2023 09:00:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1699376421; x=1699981221; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=HC6KvMMsZ94+d82S3eN5rHF6q71rC8L6ZQm7wAfp2iA=; b=j4AkaELJo63tPhDVmwf0XxRvOdUHAXXYiVkNeQhzN/AR8p+ItIHBQBZCE3j3CuOC/w IUjRYVuoAKqDWK1A2oyFJC6K5JfgAUaBcvZIbj7NKcpKpwPpF6sbmwmQ+Rj4pPa0lwCj enFSoBVrRvnV1Ao5paaBLxH3wtvpzfvEKFcoEfkHdsXH7TmICaimenl+DdpQ7a9VeQzz D9zqtj46Dlg9Une+ldjkQfMrlhudJLZIkV5qIE96YBX4VEL1Am0q0VRjgt6Gz1VJz9Vj x3B14/PUgb7PmX+pzJRQfgRNBpjZFq9pMe7Ja/N8Lr7PTNKYEskFxZQmV7TOixG+zQc6 AxGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699376421; x=1699981221; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=HC6KvMMsZ94+d82S3eN5rHF6q71rC8L6ZQm7wAfp2iA=; b=B3ntcMYRGItaNJQXsUH5iH4/x/osqIoqDFiudd2NqokZ424/2gJaPyi5Va3FJjnT95 fVHqo5AsZ+RJORgI5tEQ3uYsIFuwqQ9kbx/oKREIOh3fi50NYNk9YNtJlHlAGrhXI2XF paPVQBo8MkvaftV8XFEmFieJPmpjiOuuvYB68oncF9Jo59M4KDeKivypjho6Xkx9LqfD +ed0uFxkxm5nhuQXadou+mlkhWSFaFOb0U2Goz4jUGGGpOf2NsZmO8MnuPxqu93TR2xP mQwS3LtIs5FbF/dJtqNuPbOXGjHcX2dwfoO3Kjo6h1JUy6g0O+AxAEYjCPM5x41yoZQe Fntg== X-Gm-Message-State: AOJu0YyVs+vXHyjVUJveTZHanBUwDHlX4EZys5GnACbXLHMDXL52iQq0 nxfWctl7onJnCTtBcsrJL5B3ng== X-Google-Smtp-Source: AGHT+IE3pu+DtuabaaQe4m1aiWa8NkXwPdwP0gR7Xz0xHLxQn8rQydzirhNOxUvW7CokBBPHvpM/zQ== X-Received: by 2002:a17:903:11cf:b0:1ca:362b:166c with SMTP id q15-20020a17090311cf00b001ca362b166cmr30917798plh.61.1699376420668; Tue, 07 Nov 2023 09:00:20 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id v11-20020a170902d68b00b001bde6fa0a39sm63935ply.167.2023.11.07.09.00.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Nov 2023 09:00:20 -0800 (PST) Date: Tue, 7 Nov 2023 09:00:18 -0800 From: Stephen Hemminger To: Morten =?UTF-8?B?QnLDuHJ1cA==?= Cc: "David Marchand" , , Subject: Re: [PATCH] dumpcap: fix mbuf pool ring type Message-ID: <20231107090018.3687b2a8@hermes.local> In-Reply-To: <98CBD80474FA8B44BF855DF32C47DC35E9EFE8@smartserver.smartshare.dk> References: <20230804161604.61050-1-stephen@networkplumber.org> <98CBD80474FA8B44BF855DF32C47DC35D87C27@smartserver.smartshare.dk> <20231106112331.690cc454@hermes.local> <98CBD80474FA8B44BF855DF32C47DC35E9EFE6@smartserver.smartshare.dk> <20231106183618.79ab6f93@hermes.local> <98CBD80474FA8B44BF855DF32C47DC35E9EFE8@smartserver.smartshare.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, 7 Nov 2023 08:22:37 +0100 Morten Br=C3=B8rup wrote: > > > Or are you saying that if they want to use dumpcap, they must choose = =20 > > a thread safe pool type for their application (regardless if the > > application is single-threaded or not)? > >=20 > > There is no command line of EAL nature in dumpcap. > > This is intentional. > > QED: overriding default pool type is not going to be a possible =20 >=20 > The preferred mbuf pool type can configured in the primary process by EAL= params. If so configured, it is stored in a memzone named "mbuf_user_pool_= ops". > And if it is set there, the secondary process will also use it as its pre= ferred mbuf pool type. I notice that no other app or example is using the create_by_ops except pdu= mp/pcapng/dumpcap. ~/DPDK/main/examples $ git grep rte_pktmbuf_pool_create_by_ops ~/DPDK/main/app $ git grep rte_pktmbuf_pool_create_by_ops dumpcap/main.c: mp =3D rte_pktmbuf_pool_create_by_ops(pool_name, num_mbufs, pdump/main.c: mbuf_pool =3D rte_pktmbuf_pool_create_by_op= s(mempool_name, test/test_pcapng.c: mp =3D rte_pktmbuf_pool_create_by_ops("pcapng_test_= pool", IOV_MAX + NUM_PACKETS,