* [PATCH] mbuf: remove use of now unnecessary extension keyword
@ 2023-11-07 22:14 Tyler Retzlaff
2023-11-07 23:07 ` Tyler Retzlaff
0 siblings, 1 reply; 2+ messages in thread
From: Tyler Retzlaff @ 2023-11-07 22:14 UTC (permalink / raw)
To: dev; +Cc: Tyler Retzlaff
Remove the use of __extension__ on nameless struct and union members
they are no longer necessary as they are standard in C11
Signed-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>
---
lib/mbuf/rte_mbuf_core.h | 3 ---
1 file changed, 3 deletions(-)
diff --git a/lib/mbuf/rte_mbuf_core.h b/lib/mbuf/rte_mbuf_core.h
index 5688683..d335ed8 100644
--- a/lib/mbuf/rte_mbuf_core.h
+++ b/lib/mbuf/rte_mbuf_core.h
@@ -525,7 +525,6 @@ struct rte_mbuf {
*/
union {
uint32_t packet_type; /**< L2/L3/L4 and tunnel information. */
- __extension__
struct {
uint8_t l2_type:4; /**< (Outer) L2 type. */
uint8_t l3_type:4; /**< (Outer) L3 type. */
@@ -537,7 +536,6 @@ struct rte_mbuf {
* RTE_PTYPE_TUNNEL_ESP tunnel type is set
* on both Tx and Rx.
*/
- __extension__
struct {
uint8_t inner_l2_type:4;
/**< Inner L2 type. */
@@ -614,7 +612,6 @@ struct rte_mbuf {
/* fields to support TX offloads */
union {
uint64_t tx_offload; /**< combined for easy fetch */
- __extension__
struct {
uint64_t l2_len:RTE_MBUF_L2_LEN_BITS;
/**< L2 (MAC) Header Length for non-tunneling pkt.
--
1.8.3.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] mbuf: remove use of now unnecessary extension keyword
2023-11-07 22:14 [PATCH] mbuf: remove use of now unnecessary extension keyword Tyler Retzlaff
@ 2023-11-07 23:07 ` Tyler Retzlaff
0 siblings, 0 replies; 2+ messages in thread
From: Tyler Retzlaff @ 2023-11-07 23:07 UTC (permalink / raw)
To: dev
this series will be withdrawn since the keyword was also applied to the
bitfields.
sorry for the noise
On Tue, Nov 07, 2023 at 02:14:44PM -0800, Tyler Retzlaff wrote:
> Remove the use of __extension__ on nameless struct and union members
> they are no longer necessary as they are standard in C11
>
> Signed-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>
> ---
> lib/mbuf/rte_mbuf_core.h | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/lib/mbuf/rte_mbuf_core.h b/lib/mbuf/rte_mbuf_core.h
> index 5688683..d335ed8 100644
> --- a/lib/mbuf/rte_mbuf_core.h
> +++ b/lib/mbuf/rte_mbuf_core.h
> @@ -525,7 +525,6 @@ struct rte_mbuf {
> */
> union {
> uint32_t packet_type; /**< L2/L3/L4 and tunnel information. */
> - __extension__
> struct {
> uint8_t l2_type:4; /**< (Outer) L2 type. */
> uint8_t l3_type:4; /**< (Outer) L3 type. */
> @@ -537,7 +536,6 @@ struct rte_mbuf {
> * RTE_PTYPE_TUNNEL_ESP tunnel type is set
> * on both Tx and Rx.
> */
> - __extension__
> struct {
> uint8_t inner_l2_type:4;
> /**< Inner L2 type. */
> @@ -614,7 +612,6 @@ struct rte_mbuf {
> /* fields to support TX offloads */
> union {
> uint64_t tx_offload; /**< combined for easy fetch */
> - __extension__
> struct {
> uint64_t l2_len:RTE_MBUF_L2_LEN_BITS;
> /**< L2 (MAC) Header Length for non-tunneling pkt.
> --
> 1.8.3.1
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-11-07 23:07 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-11-07 22:14 [PATCH] mbuf: remove use of now unnecessary extension keyword Tyler Retzlaff
2023-11-07 23:07 ` Tyler Retzlaff
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).