From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 16161432CC; Wed, 8 Nov 2023 00:07:36 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DF315402C9; Wed, 8 Nov 2023 00:07:35 +0100 (CET) Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mails.dpdk.org (Postfix) with ESMTP id 1AF9E40041 for ; Wed, 8 Nov 2023 00:07:34 +0100 (CET) Received: by linux.microsoft.com (Postfix, from userid 1086) id 73C4A20B74C0; Tue, 7 Nov 2023 15:07:33 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 73C4A20B74C0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1699398453; bh=8eTolM3nyV3ENpybuEK3i9+pTyoC7/+U2YxmQgNob6c=; h=Date:From:To:Subject:References:In-Reply-To:From; b=Gp6KeLKujyQfXBSiLGJ1hShORMJOPha8gkHuuiTDoICuNRYV+DG+RURNirVreU0bj zPUsowf9a3PESLAVkvcM6faV0aF0vb7LOcQWJgOsmrlicySq8MykBq8wo/Wc0k87HG VI1uvN0QU4+C1+d8wbZNGEavR3dH2NVI25uEBx+Q= Date: Tue, 7 Nov 2023 15:07:33 -0800 From: Tyler Retzlaff To: dev@dpdk.org Subject: Re: [PATCH] mbuf: remove use of now unnecessary extension keyword Message-ID: <20231107230733.GA15565@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> References: <1699395284-8751-1-git-send-email-roretzla@linux.microsoft.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1699395284-8751-1-git-send-email-roretzla@linux.microsoft.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org this series will be withdrawn since the keyword was also applied to the bitfields. sorry for the noise On Tue, Nov 07, 2023 at 02:14:44PM -0800, Tyler Retzlaff wrote: > Remove the use of __extension__ on nameless struct and union members > they are no longer necessary as they are standard in C11 > > Signed-off-by: Tyler Retzlaff > --- > lib/mbuf/rte_mbuf_core.h | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/lib/mbuf/rte_mbuf_core.h b/lib/mbuf/rte_mbuf_core.h > index 5688683..d335ed8 100644 > --- a/lib/mbuf/rte_mbuf_core.h > +++ b/lib/mbuf/rte_mbuf_core.h > @@ -525,7 +525,6 @@ struct rte_mbuf { > */ > union { > uint32_t packet_type; /**< L2/L3/L4 and tunnel information. */ > - __extension__ > struct { > uint8_t l2_type:4; /**< (Outer) L2 type. */ > uint8_t l3_type:4; /**< (Outer) L3 type. */ > @@ -537,7 +536,6 @@ struct rte_mbuf { > * RTE_PTYPE_TUNNEL_ESP tunnel type is set > * on both Tx and Rx. > */ > - __extension__ > struct { > uint8_t inner_l2_type:4; > /**< Inner L2 type. */ > @@ -614,7 +612,6 @@ struct rte_mbuf { > /* fields to support TX offloads */ > union { > uint64_t tx_offload; /**< combined for easy fetch */ > - __extension__ > struct { > uint64_t l2_len:RTE_MBUF_L2_LEN_BITS; > /**< L2 (MAC) Header Length for non-tunneling pkt. > -- > 1.8.3.1