From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 728B4432D9;
	Wed,  8 Nov 2023 19:42:07 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 19CFA41133;
	Wed,  8 Nov 2023 19:42:07 +0100 (CET)
Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182])
 by mails.dpdk.org (Postfix) with ESMTP id A4795410EA
 for <dev@dpdk.org>; Wed,  8 Nov 2023 19:42:05 +0100 (CET)
Received: by linux.microsoft.com (Postfix, from userid 1086)
 id F307D20B74C0; Wed,  8 Nov 2023 10:42:04 -0800 (PST)
DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com F307D20B74C0
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;
 s=default; t=1699468925;
 bh=tUHAcKTWnYUkpFGd3i/iOvAbchrenpgU7KCr0t2lz5s=;
 h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
 b=QWA22LVlRQJU+s3BGAPJMG52pH5poVqFSpX3ggdApwKE3mLtgqS4FGxdGNEJt1ndm
 6z8wVKPAbbmcQCXp8/GR0JHXZrMFeN+BmoAs/bCGVTDOGcIZCV6cbxJDvwYXJupIPD
 Y1lsU7MEkOb/6A0PmKiLkT6L9ThV87aoqS6ydqFM=
Date: Wed, 8 Nov 2023 10:42:04 -0800
From: Tyler Retzlaff <roretzla@linux.microsoft.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: dev@dpdk.org, Bruce Richardson <bruce.richardson@intel.com>,
 Cristian Dumitrescu <cristian.dumitrescu@intel.com>,
 David Hunt <david.hunt@intel.com>,
 Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>,
 Ruifeng Wang <ruifeng.wang@arm.com>,
 Sameh Gobriel <sameh.gobriel@intel.com>,
 Vladimir Medvedkin <vladimir.medvedkin@intel.com>,
 Yipeng Wang <yipeng1.wang@intel.com>,
 Morten =?iso-8859-1?Q?Br=F8rup?= <mb@smartsharesystems.com>
Subject: Re: [PATCH v3 0/7] use abstracted bit count functions
Message-ID: <20231108184204.GA21615@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
References: <1698887132-5347-1-git-send-email-roretzla@linux.microsoft.com>
 <1699400300-22545-1-git-send-email-roretzla@linux.microsoft.com>
 <98CBD80474FA8B44BF855DF32C47DC35E9EFF0@smartserver.smartshare.dk>
 <2526782.TLnPLrj5Ze@thomas>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <2526782.TLnPLrj5Ze@thomas>
User-Agent: Mutt/1.5.21 (2010-09-15)
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

On Wed, Nov 08, 2023 at 05:57:01PM +0100, Thomas Monjalon wrote:
> 08/11/2023 09:34, Morten Brørup:
> > > From: Tyler Retzlaff [mailto:roretzla@linux.microsoft.com]
> > > Sent: Wednesday, 8 November 2023 00.38
> > > 
> > > The first set of conversions missed the long 'l' versions of the
> > > builtins that were being used. This series completes the conversion
> > > of remaining libraries from __builtin_ctzl, __builtin_clzl and
> > > __builtin_popcountl.
> > > 
> > > v3:
> > >   * add missing include of rte_bitops.h
> > >   * add 2 patches to cover use of __builtin_popcountl
> > > 
> > > v2:
> > >   * be explicit and use appropriate 32-bit and 64-bit leading
> > >     and trailing counting functions depending on the type of the
> > >     expression passed as an argument to the builtin.
> > 
> > Didn't notice v3 before ack'ing v2.
> > 
> > Series-acked-by: Morten Brørup <mb@smartsharesystems.com>
> 
> Squashed and applied, thanks.
> 
> Note: there are few builtin occurences in drivers.

yes, tests and drivers are on my list. i'm mostly addressing conversions
in libs right now.

> 
>