From: Gregory Etelson <getelson@nvidia.com>
To: <dev@dpdk.org>, <ferruh.yigit@amd.com>
Cc: <getelson@nvidia.com>, <mkashani@nvidia.com>,
Ori Kam <orika@nvidia.com>,
Aman Singh <aman.deep.singh@intel.com>,
Yuying Zhang <yuying.zhang@intel.com>
Subject: [PATCH v3] app/testpmd: fix indirect action list ID size
Date: Fri, 10 Nov 2023 09:04:37 +0200 [thread overview]
Message-ID: <20231110070437.517715-1-getelson@nvidia.com> (raw)
In-Reply-To: <20231108163445.422772-1-getelson@nvidia.com>
Testpmd maps indirect action lists handlers into application IDs.
Testpmd API defines indirect IDs as 32 bits values.
The patch fixes indirect IDs size in ACTION_INDIRECT_LIST_HANDLE
and ACTION_INDIRECT_LIST_CONF tokens
Fixes: 72a3dec7126f ("ethdev: add indirect flow list action")
Signed-off-by: Gregory Etelson <getelson@nvidia.com>
---
v2: define `id` as uintptr_t
v3: define indirect ID size as 32 bits
---
app/test-pmd/cmdline_flow.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c
index 0d521159e9..ce71818705 100644
--- a/app/test-pmd/cmdline_flow.c
+++ b/app/test-pmd/cmdline_flow.c
@@ -7383,13 +7383,13 @@ static const struct token token_list[] = {
.name = "handle",
.help = "indirect list handle",
.next = NEXT(next_ial, NEXT_ENTRY(INDIRECT_LIST_ACTION_ID2PTR_HANDLE)),
- .args = ARGS(ARGS_ENTRY_ARB(0, sizeof(uintptr_t))),
+ .args = ARGS(ARGS_ENTRY_ARB(0, sizeof(uint32_t))),
},
[ACTION_INDIRECT_LIST_CONF] = {
.name = "conf",
.help = "indirect list configuration",
.next = NEXT(next_ial, NEXT_ENTRY(INDIRECT_LIST_ACTION_ID2PTR_CONF)),
- .args = ARGS(ARGS_ENTRY_ARB(0, sizeof(uintptr_t))),
+ .args = ARGS(ARGS_ENTRY_ARB(0, sizeof(uint32_t))),
},
[INDIRECT_LIST_ACTION_ID2PTR_HANDLE] = {
.type = "UNSIGNED",
--
2.39.2
next prev parent reply other threads:[~2023-11-10 7:05 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-08 16:34 [PATCH] app/testpmd: fix indirect action list parameters parsing Gregory Etelson
2023-11-09 16:16 ` Ferruh Yigit
2023-11-09 18:22 ` Etelson, Gregory
2023-11-09 19:03 ` Ferruh Yigit
2023-11-09 19:57 ` Etelson, Gregory
2023-11-10 14:51 ` Ferruh Yigit
2023-11-10 17:41 ` Etelson, Gregory
2023-11-10 20:15 ` Ferruh Yigit
2023-11-10 21:22 ` Etelson, Gregory
2023-11-09 18:36 ` [PATCH v2] " Gregory Etelson
2023-11-09 19:41 ` Stephen Hemminger
2023-11-09 20:01 ` Bruce Richardson
2023-11-10 7:04 ` Gregory Etelson [this message]
2023-11-10 23:40 ` [PATCH v3] app/testpmd: fix indirect action list ID size Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231110070437.517715-1-getelson@nvidia.com \
--to=getelson@nvidia.com \
--cc=aman.deep.singh@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@amd.com \
--cc=mkashani@nvidia.com \
--cc=orika@nvidia.com \
--cc=yuying.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).