[PATCH v2] vhost: make experimental API's stable

[PATCH v2] vhost: make experimental API's stable

[Maxime Coquelin]

From: Stephen Hemminger <stephen@networkplumber.org>

Transistion API's added from 2008 to 2022 to stable, except
Vhost-async's which are likely to require changes to be adopted.

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>
---
 lib/vhost/rte_vhost.h        |  5 -----
 lib/vhost/rte_vhost_crypto.h |  1 -
 lib/vhost/version.map        | 17 +++++++----------
 3 files changed, 7 insertions(+), 16 deletions(-)

diff --git a/lib/vhost/rte_vhost.h b/lib/vhost/rte_vhost.h
index fec650b1db..db92f05344 100644
--- a/lib/vhost/rte_vhost.h
+++ b/lib/vhost/rte_vhost.h
@@ -509,7 +509,6 @@ rte_vhost_driver_get_vdpa_device(const char *path);
  * @return
  *  0 on success, -1 on failure
  */
-__rte_experimental
 int
 rte_vhost_driver_get_vdpa_dev_type(const char *path, uint32_t *type);
 
@@ -648,7 +647,6 @@ int rte_vhost_get_negotiated_features(int vid, uint64_t *features);
  * @return
  *  0 on success, -1 on failure
  */
-__rte_experimental
 int
 rte_vhost_get_negotiated_protocol_features(int vid,
 					   uint64_t *protocol_features);
@@ -960,7 +958,6 @@ int rte_vhost_vring_call(int vid, uint16_t vring_idx);
  * @return
  *  0 on success, -1 on failure, -EAGAIN for another retry
  */
-__rte_experimental
 int rte_vhost_vring_call_nonblock(int vid, uint16_t vring_idx);
 
 /**
@@ -987,7 +984,6 @@ uint32_t rte_vhost_rx_queue_count(int vid, uint16_t qid);
  * @return
  *  0 on success, -1 on failure
  */
-__rte_experimental
 int
 rte_vhost_get_monitor_addr(int vid, uint16_t queue_id,
 		struct rte_vhost_power_monitor_cond *pmc);
@@ -1102,7 +1098,6 @@ rte_vhost_get_vdpa_device(int vid);
  * @return
  *  0 on success, < 0 on failure
  */
-__rte_experimental
 int
 rte_vhost_backend_config_change(int vid, bool need_reply);
 
diff --git a/lib/vhost/rte_vhost_crypto.h b/lib/vhost/rte_vhost_crypto.h
index 2b01ecda08..71a30ba202 100644
--- a/lib/vhost/rte_vhost_crypto.h
+++ b/lib/vhost/rte_vhost_crypto.h
@@ -40,7 +40,6 @@ enum rte_vhost_crypto_zero_copy {
  * @return
  *  0 on success, -1 on failure
  */
-__rte_experimental
 int
 rte_vhost_crypto_driver_start(const char *path);
 
diff --git a/lib/vhost/version.map b/lib/vhost/version.map
index 5bc133dafd..25b52e47d2 100644
--- a/lib/vhost/version.map
+++ b/lib/vhost/version.map
@@ -10,9 +10,11 @@ DPDK_24 {
 	rte_vdpa_get_stats_names;
 	rte_vdpa_reset_stats;
 	rte_vhost_avail_entries;
+	rte_vhost_backend_config_change;
 	rte_vhost_clr_inflight_desc_packed;
 	rte_vhost_clr_inflight_desc_split;
 	rte_vhost_crypto_create;
+	rte_vhost_crypto_driver_start;
 	rte_vhost_crypto_fetch_requests;
 	rte_vhost_crypto_finalize_requests;
 	rte_vhost_crypto_free;
@@ -26,6 +28,7 @@ DPDK_24 {
 	rte_vhost_driver_get_features;
 	rte_vhost_driver_get_protocol_features;
 	rte_vhost_driver_get_queue_num;
+	rte_vhost_driver_get_vdpa_dev_type;
 	rte_vhost_driver_get_vdpa_device;
 	rte_vhost_driver_register;
 	rte_vhost_driver_set_features;
@@ -38,8 +41,10 @@ DPDK_24 {
 	rte_vhost_get_ifname;
 	rte_vhost_get_log_base;
 	rte_vhost_get_mem_table;
+	rte_vhost_get_monitor_addr;
 	rte_vhost_get_mtu;
 	rte_vhost_get_negotiated_features;
+	rte_vhost_get_negotiated_protocol_features;
 	rte_vhost_get_numa_node;
 	rte_vhost_get_vdpa_device;
 	rte_vhost_get_vhost_ring_inflight;
@@ -57,6 +62,7 @@ DPDK_24 {
 	rte_vhost_set_vring_base;
 	rte_vhost_va_from_guest_pa;
 	rte_vhost_vring_call;
+	rte_vhost_vring_call_nonblock;
 	rte_vhost_vring_stats_get;
 	rte_vhost_vring_stats_get_names;
 	rte_vhost_vring_stats_reset;
@@ -67,37 +73,28 @@ DPDK_24 {
 EXPERIMENTAL {
 	global:
 
-	rte_vhost_crypto_driver_start;
-	rte_vhost_backend_config_change;
+	# added in 20.08
 	rte_vhost_async_channel_register;
 	rte_vhost_async_channel_unregister;
 	rte_vhost_submit_enqueue_burst;
 	rte_vhost_poll_enqueue_completed;
 
-	# added in 21.05
-	rte_vhost_get_negotiated_protocol_features;
-
 	# added in 21.08
 	rte_vhost_async_get_inflight;
 	rte_vhost_async_channel_register_thread_unsafe;
 	rte_vhost_async_channel_unregister_thread_unsafe;
 	rte_vhost_clear_queue_thread_unsafe;
 
-	# added in 21.11
-	rte_vhost_get_monitor_addr;
-
 	# added in 22.03
 	rte_vhost_async_dma_configure;
 
 	# added in 22.07
 	rte_vhost_async_get_inflight_thread_unsafe;
 	rte_vhost_async_try_dequeue_burst;
-	rte_vhost_driver_get_vdpa_dev_type;
 	rte_vhost_clear_queue;
 
 	# added in 22.11
 	rte_vhost_async_dma_unconfigure;
-	rte_vhost_vring_call_nonblock;
 
 	# added in 23.07
 	rte_vhost_driver_set_max_queue_num;
-- 
2.41.0

Re: [PATCH v2] vhost: make experimental API's stable

[David Marchand]

On Fri, Nov 10, 2023 at 9:52 AM Maxime Coquelin
<maxime.coquelin@redhat.com> wrote:
>
> From: Stephen Hemminger <stephen@networkplumber.org>
>
> Transistion API's added from 2008 to 2022 to stable, except
> Vhost-async's which are likely to require changes to be adopted.
>
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>

I have one comment below, but this can probably be fixed when applying.

Reviewed-by: David Marchand <david.marchand@redhat.com>


> diff --git a/lib/vhost/rte_vhost_crypto.h b/lib/vhost/rte_vhost_crypto.h
> index 2b01ecda08..71a30ba202 100644
> --- a/lib/vhost/rte_vhost_crypto.h
> +++ b/lib/vhost/rte_vhost_crypto.h
> @@ -40,7 +40,6 @@ enum rte_vhost_crypto_zero_copy {
>   * @return
>   *  0 on success, -1 on failure
>   */
> -__rte_experimental
>  int
>  rte_vhost_crypto_driver_start(const char *path);
>

No need to include rte_compat.h in rte_vhost_crypto.h anymore: no
symbol is marked internal or experimental after this change.


-- 
David Marchand

Re: [PATCH v2] vhost: make experimental API's stable

[Maxime Coquelin]

On 11/13/23 10:52, David Marchand wrote:
> On Fri, Nov 10, 2023 at 9:52 AM Maxime Coquelin
> <maxime.coquelin@redhat.com> wrote:
>>
>> From: Stephen Hemminger <stephen@networkplumber.org>
>>
>> Transistion API's added from 2008 to 2022 to stable, except
>> Vhost-async's which are likely to require changes to be adopted.
>>
>> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
>> Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>
> 
> I have one comment below, but this can probably be fixed when applying.
> 
> Reviewed-by: David Marchand <david.marchand@redhat.com>
> 
> 
>> diff --git a/lib/vhost/rte_vhost_crypto.h b/lib/vhost/rte_vhost_crypto.h
>> index 2b01ecda08..71a30ba202 100644
>> --- a/lib/vhost/rte_vhost_crypto.h
>> +++ b/lib/vhost/rte_vhost_crypto.h
>> @@ -40,7 +40,6 @@ enum rte_vhost_crypto_zero_copy {
>>    * @return
>>    *  0 on success, -1 on failure
>>    */
>> -__rte_experimental
>>   int
>>   rte_vhost_crypto_driver_start(const char *path);
>>
> 
> No need to include rte_compat.h in rte_vhost_crypto.h anymore: no
> symbol is marked internal or experimental after this change.
> 
> 

Ack, I will fix it while applying.

Thanks,
Maxime

Re: [PATCH v2] vhost: make experimental API's stable

[Maxime Coquelin]

On 11/10/23 09:52, Maxime Coquelin wrote:
> From: Stephen Hemminger <stephen@networkplumber.org>
> 
> Transistion API's added from 2008 to 2022 to stable, except
> Vhost-async's which are likely to require changes to be adopted.
> 
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>
> ---
>   lib/vhost/rte_vhost.h        |  5 -----
>   lib/vhost/rte_vhost_crypto.h |  1 -
>   lib/vhost/version.map        | 17 +++++++----------
>   3 files changed, 7 insertions(+), 16 deletions(-)
> 

Applied to dpdk-next-virtio/for-net-next with removing rte_compat.h
inclusion from rte_vhost_crypto.h header.

Thanks,
Maxime