From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9387A4331C; Mon, 13 Nov 2023 17:34:51 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2E9F0402CF; Mon, 13 Nov 2023 17:34:51 +0100 (CET) Received: from mail-pf1-f179.google.com (mail-pf1-f179.google.com [209.85.210.179]) by mails.dpdk.org (Postfix) with ESMTP id E4CF84026C for ; Mon, 13 Nov 2023 17:34:49 +0100 (CET) Received: by mail-pf1-f179.google.com with SMTP id d2e1a72fcca58-6ba54c3ed97so4750238b3a.2 for ; Mon, 13 Nov 2023 08:34:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1699893289; x=1700498089; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=84aGPvMV6DADrfj2agaj/DigAT8AjFb+E92qgIlyhRU=; b=R2crjvd0+x2cgQqeca7fytB+Ym+hnJi09vJk8DQBdgLaXgxDr3ocnOoLTj5vUN+8ax RLuLIuQ2r4WEwWxiyI4DvtgeIcKhJJ7L/dizrrxDq4rPaaBmqSKzaqvoN3oUKMlDqodt WiOUAwljmXU8P/nfPNYGtf73b1zwBAH5tPMSubk4VtGEnXov+rGe5lJhiR+CrfqSrbtx Gv1gwfdRdahzKYMxaRZsJmlv0aS5RRGzfozybZrj4Uzy+KjQAHviJIT0VoS1JQt0zdc/ JKx394lfWx59tKZ/4HbQ9rfUTM4GXsK9Hw1w+Z42MQimLzd/ntHRF/1WDRw8mAOCAITx Hwfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699893289; x=1700498089; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=84aGPvMV6DADrfj2agaj/DigAT8AjFb+E92qgIlyhRU=; b=tZeLCh9BU9dI3SqY6JMYbIcIFRWyy1clj22lh7T0kBPuLPdz2yDUMfwwfrQByenbGO D8ogoFHruinS+745v2dTaUCWELZbDSVC7CtXVhNP6+lfdd4KF/BDSPehjEhfLJ5ZsjLb hpGqxv4UEP6GbFRb114cg6c3K4aLu21cdVwO/RPWMzkL5OcmdeGy0Oi8Ro1rbnP7wjB3 LCys05cE1rQrv1FdNGbTLl5YkPNoK9qHFvFzwN/nickKpNevTpY+LS3cJ727uxD8ye82 vhLWIGma4ELL+dFSiZz8RemYxjqTz7oa+CFgntG41m4fn31o/sae8YB3u4wpxI6zc9bz 6sAQ== X-Gm-Message-State: AOJu0Yz8Bb+k4yAVeHzUfRdqUXILXrD9pv4Z6XhUJCKIf2xXUu+3JHCv 9oghZ3FB4tF6CR83Pxf7GhATqA== X-Google-Smtp-Source: AGHT+IHMQEORegO1YxKErrTV6p/pkCcQ8liiuDLeWb4ldF0kOs/IcM1RCDmfhCRc7kmOactfxKlsXw== X-Received: by 2002:a05:6a20:8e12:b0:181:9b30:89d6 with SMTP id y18-20020a056a208e1200b001819b3089d6mr8866545pzj.27.1699893289028; Mon, 13 Nov 2023 08:34:49 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id 20-20020a17090a035400b00263b9e75aecsm4388790pjf.41.2023.11.13.08.34.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Nov 2023 08:34:48 -0800 (PST) Date: Mon, 13 Nov 2023 08:34:47 -0800 From: Stephen Hemminger To: Trevor Tao Cc: dev@dpdk.org Subject: Re: [PATCH v4 1/2] examples/l3fwd: relax RSS requirement with option Message-ID: <20231113083447.527c912b@hermes.local> In-Reply-To: <20231113160255.124385-2-taozj888@163.com> References: <20231113160255.124385-1-taozj888@163.com> <20231113160255.124385-2-taozj888@163.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, 13 Nov 2023 16:02:54 +0000 Trevor Tao wrote: > Now the port Rx mq_mode had been set to RTE_ETH_MQ_RX_RSS > by default, but some hw and/or virtual interface does not > support the RSS and offload mode presupposed, e.g., some > virtio interfaces in the cloud don't support > RSS and the error msg may like: > > virtio_dev_configure(): RSS support requested but not supported by > the device > Port0 dev_configure = -95 > > So to enable the l3fwd running in that environment, the Rx mode requirement > can be relaxed to reflect the hardware feature reality here, and the l3fwd > can run smoothly then. > > An option named "disable-rss" is added to disable the RX RSS explicitly, > and it's disabled by default. > > Signed-off-by: Trevor Tao Why is running with > 1 rx queue and RSS disabled useful? What happens is all packets arrive on 1st queue and you burn a thread polling an always empty queue. I would prefer not adding yet another command line option and just "do the right thing". If number of rx queues > 1, check that device supports RSS before using it. If device does not support RSS give an error and exit.