From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7A3F54331F; Mon, 13 Nov 2023 23:13:30 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 50F1B402B0; Mon, 13 Nov 2023 23:13:30 +0100 (CET) Received: from mail-pl1-f175.google.com (mail-pl1-f175.google.com [209.85.214.175]) by mails.dpdk.org (Postfix) with ESMTP id 9DF72402AB for ; Mon, 13 Nov 2023 23:13:29 +0100 (CET) Received: by mail-pl1-f175.google.com with SMTP id d9443c01a7336-1cc3bb32b5dso44121205ad.3 for ; Mon, 13 Nov 2023 14:13:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1699913608; x=1700518408; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=yFoaz+Dg1wnfvXaggi8B2j2jqoWqtXmT1Pctec+3zj8=; b=a2qOeAlhc8mhQDZ+fAMpYGTBZRJye/km40AH0ewYrfjD2KbSpbpqrir7SqrAKL25v8 7V0WStFkeEMUq5BNYiBTXAmxrpIfXuAlZd+R17ta5e1acSGMi9LSf8Twi9FppFtgYCEn YHnj9/uO9GNV2LA02XmVJQBlB7OT1cS1kpzl2NvAGaeYPQ1ZcARn4+6JzTLIeFGEoNwj krwoMJRn95iT9lZcDDle9bY8rQJ2BQG4YaFJUpRhdC4H6wg4Y2V5dOyyvqZTmOEDTNKK OetZv2pVCAJ+3GOa/+FATRWa39HYBV+nXAxP+JOoAzY6rUJhpVU2ogcA+KQ9bAGboRCG WWUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699913608; x=1700518408; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=yFoaz+Dg1wnfvXaggi8B2j2jqoWqtXmT1Pctec+3zj8=; b=Ajbrs2KPymzx4OH8F70oECFJKlKdJD/yDplA/X3LBiZUyUuUv2OE7j47rBcb82p/D4 OBf7I1xFe53TwYAVc6BXazrOptM/2PaZR9Jc2WxfDhDqgPpMENmybhS3selyUWSpBc3n uFFL1QTB0bYIBNEqfhGLZ9JD48LApUTcwGuK0QlCfgHbf9ILNPS2M5+1vD7y5/znR51+ uf+zEkCpEbKiVtV5AsGbQrzBq2BHI2dFCvK00rS0XlcAvmB/XA+OkRkRk7zHq3l/HtYc Y463vE3cvhfU8OZjmrQHQyq8c3V1Z9PgSq1aVBGIqjUSomDx90tBc0rKER0nuZMswhNf b2Pw== X-Gm-Message-State: AOJu0YzCBYj+aaEbPs6ZPOY5s7dGuk1yc9fEJVEH8TMhGi/GsQDUZItk 53X9iYIP6mTqyZcXRcYuHhdeDVnxN6TQl1MSst0= X-Google-Smtp-Source: AGHT+IGJUvecxYFvU5Z1u1v6+hkJ1vjBKN0upx4ShNFeGO9SBgXwdWGx6fchKsW+tB7KyaHaa/bm3A== X-Received: by 2002:a17:903:22c3:b0:1cc:ec22:5a40 with SMTP id y3-20020a17090322c300b001ccec225a40mr602640plg.26.1699913608367; Mon, 13 Nov 2023 14:13:28 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id g10-20020a170902740a00b001cc1dff5b86sm4462177pll.244.2023.11.13.14.13.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Nov 2023 14:13:28 -0800 (PST) Date: Mon, 13 Nov 2023 14:13:26 -0800 From: Stephen Hemminger To: dev@dpdk.org Cc: ivan.malov@oktetlabs.ru, Andrew Rybchenko , Ivan Malov Subject: Re: [PATCH v2 2/3] net/sfc: fix non-constant expression inr RTE_BUILD_BUG_ON() Message-ID: <20231113141326.0df15fd6@hermes.local> In-Reply-To: <20231113170605.408281-3-stephen@networkplumber.org> References: <20231111172153.57461-1-stephen@networkplumber.org> <20231113170605.408281-1-stephen@networkplumber.org> <20231113170605.408281-3-stephen@networkplumber.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, 13 Nov 2023 09:06:04 -0800 Stephen Hemminger wrote: > The macro RTE_MIN has some hidden assignments to provide type > safety which means the statement can not be fully evaluted in > first pass of compiler. Replace RTE_MIN() with equivalent macro. > > This will cause errors from checkpatch about multiple evaluations > of same expression in macro but it is ok in this case. > > Fixes: 4f936666d790 ("net/sfc: support TSO for EF100 native datapath") > Cc: ivan.malov@oktetlabs.ru > Signed-off-by: Stephen Hemminger Building with clang finds another issue. ../drivers/net/sfc/sfc_rx.c:158:3: error: expected expression RTE_BUILD_BUG_ON(RTE_MBUF_F_RX_IP_CKSUM_UNKNOWN != 0); yet lib/mbuf/rte_mbuf_core.h:#define RTE_MBUF_F_RX_IP_CKSUM_UNKNOWN 0