From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5BED54331D; Mon, 13 Nov 2023 18:09:30 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 45CCA40A7D; Mon, 13 Nov 2023 18:09:30 +0100 (CET) Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mails.dpdk.org (Postfix) with ESMTP id 14A6A4026C for <dev@dpdk.org>; Mon, 13 Nov 2023 18:09:29 +0100 (CET) Received: by linux.microsoft.com (Postfix, from userid 1086) id 41AB220B74C1; Mon, 13 Nov 2023 09:09:28 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 41AB220B74C1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1699895368; bh=C0g6cKYaOigjM4mQlp9OXjxq2/iaYdidRh09VFa8cQY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=f7Nx9Yi3BcXeQbWTab6LTre6MAtI3jY9H85mVynLrkHeq0iF6vhQoHRCjSm+S/Ve/ aqyYC3wSDx0vhVR7o88jPhpOv1GzNEIeYhZN6FuG/0xX3CIXZQYzr/qaoDPn9UDZK+ vQXINFMAvHKt3g7522eowgMeTlQfvBl6jE9QVmE4= Date: Mon, 13 Nov 2023 09:09:28 -0800 From: Tyler Retzlaff <roretzla@linux.microsoft.com> To: Jie Hai <haijie1@huawei.com> Cc: dev@dpdk.org, lihuisong@huawei.com, fengchengwen@huawei.com Subject: Re: [PATCH 00/21] replace strtok with strtok_r Message-ID: <20231113170928.GD13153@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> References: <20231113104550.2138654-1-haijie1@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231113104550.2138654-1-haijie1@huawei.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org On Mon, Nov 13, 2023 at 06:45:29PM +0800, Jie Hai wrote: > Multiple threads calling the same function may cause condition > race issues, which often leads to abnormal behavior and can cause > more serious vulnerabilities such as abnormal termination, denial > of service, and compromised data integrity. > > The strtok() is non-reentrant, it is better to replace it with a > reentrant function. could you please use strtok_s instead of strtok_r the former is part of the C11 standard the latter is not. thanks! > > Jie Hai (21): > app/graph: replace strtok with strtok_r > app/test-bbdev: replace strtok with strtok_r > app/test-compress-perf: replace strtok with strtok_r > app/test-crypto-perf: replace strtok with strtok_r > app/test-dma-perf: replace strtok with strtok_r > app/test-fib: replace strtok with strtok_r > app/dpdk-test-flow-perf: replace strtok with strtok_r > app/test-mldev: replace strtok with strtok_r > lib/dmadev: replace strtok with strtok_r > lib/eal: replace strtok with strtok_r > lib/ethdev: replace strtok with strtok_r > lib/eventdev: replace strtok with strtok_r > lib/telemetry: replace strtok with strtok_r > lib/telemetry: replace strtok with strtok_r > bus/fslmc: replace strtok with strtok_r > common/cnxk: replace strtok with strtok_r > event/cnxk: replace strtok with strtok_r > net/ark: replace strtok with strtok_r > raw/cnxk_gpio: replace strtok with strtok_r > examples/l2fwd-crypto: replace strtok with strtok_r > examples/vhost: replace strtok with strtok_r > > app/graph/graph.c | 5 ++- > app/graph/utils.c | 15 +++++--- > app/test-bbdev/test_bbdev_vector.c | 25 +++++++----- > .../comp_perf_options_parse.c | 16 ++++---- > app/test-crypto-perf/cperf_options_parsing.c | 16 ++++---- > .../cperf_test_vector_parsing.c | 10 +++-- > app/test-dma-perf/main.c | 13 ++++--- > app/test-fib/main.c | 10 ++--- > app/test-flow-perf/main.c | 22 ++++++----- > app/test-mldev/ml_options.c | 18 ++++----- > drivers/bus/fslmc/fslmc_bus.c | 5 ++- > drivers/bus/fslmc/portal/dpaa2_hw_dpio.c | 4 +- > drivers/common/cnxk/cnxk_telemetry_nix.c | 12 +++--- > drivers/event/cnxk/cnxk_eventdev.c | 10 +++-- > drivers/event/cnxk/cnxk_tim_evdev.c | 11 +++--- > drivers/net/ark/ark_pktchkr.c | 10 ++--- > drivers/net/ark/ark_pktgen.c | 10 ++--- > drivers/raw/cnxk_gpio/cnxk_gpio.c | 6 +-- > examples/l2fwd-crypto/main.c | 6 +-- > examples/vhost/main.c | 3 +- > lib/dmadev/rte_dmadev.c | 4 +- > lib/eal/common/eal_common_memory.c | 8 ++-- > lib/ethdev/rte_ethdev_telemetry.c | 6 ++- > lib/eventdev/rte_event_eth_rx_adapter.c | 38 +++++++++---------- > lib/eventdev/rte_eventdev.c | 18 ++++----- > lib/security/rte_security.c | 3 +- > lib/telemetry/telemetry.c | 5 ++- > 27 files changed, 169 insertions(+), 140 deletions(-) > > -- > 2.30.0