From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id A9A234331D;
	Mon, 13 Nov 2023 18:55:04 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 9B3B040DDA;
	Mon, 13 Nov 2023 18:55:04 +0100 (CET)
Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182])
 by mails.dpdk.org (Postfix) with ESMTP id 7FCDB4026F
 for <dev@dpdk.org>; Mon, 13 Nov 2023 18:54:54 +0100 (CET)
Received: by linux.microsoft.com (Postfix, from userid 1086)
 id D4FF420B74C1; Mon, 13 Nov 2023 09:54:53 -0800 (PST)
DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com D4FF420B74C1
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;
 s=default; t=1699898093;
 bh=vF3PDF/b83CmW7aSWB0qsNv37AXpJzniZB0NQBSVq7M=;
 h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
 b=Kj9tJU1DcBi6f9Pv/uMyRIzPL3vreeTXBut+1oNPPthZbA6pbmY/0W/661HT4ZX7Q
 H3gIM9ChEaSIlN3eD1SSBFuj2E5w45zB7TI3lvqsD32lIWBrORGv1/9pWFQ/vLIFK4
 YG0IQeG6Kobd2IACoWBAiqQn0pBsIkBs/4baZSwM=
Date: Mon, 13 Nov 2023 09:54:53 -0800
From: Tyler Retzlaff <roretzla@linux.microsoft.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: dev@dpdk.org, liang.j.ma@intel.com, Liang Ma <liangma@liangbit.com>,
 Peter Mccarthy <peter.mccarthy@intel.com>,
 =?iso-8859-1?Q?Se=E1n?= Harte <seanbh@gmail.com>
Subject: Re: [PATCH v2 1/3] event/opdl: fix non-constant compile time assertion
Message-ID: <20231113175453.GA32289@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
References: <20231111172153.57461-1-stephen@networkplumber.org>
 <20231113170605.408281-1-stephen@networkplumber.org>
 <20231113170605.408281-2-stephen@networkplumber.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20231113170605.408281-2-stephen@networkplumber.org>
User-Agent: Mutt/1.5.21 (2010-09-15)
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

On Mon, Nov 13, 2023 at 09:06:03AM -0800, Stephen Hemminger wrote:
> RTE_BUILD_BUG_ON() was being used with a non-constant value.
> The inline function rte_is_power_of_2() is not constant since
> inline expansion happens later in the compile process.
> Replace it with macro which will be constant.
> 
> Fixes: 4236ce9bf5bf ("event/opdl: add OPDL ring infrastructure library")
> Cc: liang.j.ma@intel.com
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---

Acked-by: Tyler Retzlaff <roretzla@linux.microsoft.com>