From: Stephen Hemminger <stephen@networkplumber.org>
To: Tomasz Duszynski <tduszynski@marvell.com>
Cc: <dev@dpdk.org>, Jakub Palider <jpalider@marvell.com>,
<jerinj@marvell.com>
Subject: Re: [PATCH] raw/cnxk_bphy: switch to dynamic logging
Date: Tue, 14 Nov 2023 16:15:46 -0800 [thread overview]
Message-ID: <20231114161546.00b3ad1e@hermes.local> (raw)
In-Reply-To: <20231114080446.3574237-1-tduszynski@marvell.com>
On Tue, 14 Nov 2023 09:04:46 +0100
Tomasz Duszynski <tduszynski@marvell.com> wrote:
> Dynamically allocated log type is a standard approach among all drivers.
> Switch to it.
>
> Signed-off-by: Tomasz Duszynski <tduszynski@marvell.com>
> ---
> drivers/raw/cnxk_bphy/cnxk_bphy.c | 32 +++++++++++++---------
> drivers/raw/cnxk_bphy/cnxk_bphy_cgx.c | 4 ++-
> drivers/raw/cnxk_bphy/cnxk_bphy_cgx.h | 7 +++++
> drivers/raw/cnxk_bphy/cnxk_bphy_cgx_test.c | 32 ++++++++++------------
> 4 files changed, 44 insertions(+), 31 deletions(-)
Good to see but there seems to be a lot of other places calling
plt_err(), plt_info(), plt_warn(), plt_print()
next prev parent reply other threads:[~2023-11-15 0:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-14 8:04 Tomasz Duszynski
2023-11-15 0:15 ` Stephen Hemminger [this message]
2023-11-23 20:36 ` [EXT] " Tomasz Duszynski
2023-11-24 7:56 ` David Marchand
2023-11-27 18:11 ` [PATCH v2] " Tomasz Duszynski
2023-12-06 14:09 ` Jerin Jacob
2024-02-21 1:59 ` Thomas Monjalon
2024-02-21 8:43 ` [EXT] " Tomasz Duszynski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231114161546.00b3ad1e@hermes.local \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=jerinj@marvell.com \
--cc=jpalider@marvell.com \
--cc=tduszynski@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).