From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CA86E43330; Wed, 15 Nov 2023 01:15:50 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 59C914027B; Wed, 15 Nov 2023 01:15:50 +0100 (CET) Received: from mail-ot1-f52.google.com (mail-ot1-f52.google.com [209.85.210.52]) by mails.dpdk.org (Postfix) with ESMTP id 98E5940261 for ; Wed, 15 Nov 2023 01:15:49 +0100 (CET) Received: by mail-ot1-f52.google.com with SMTP id 46e09a7af769-6ce2c5b2154so3837999a34.3 for ; Tue, 14 Nov 2023 16:15:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1700007349; x=1700612149; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=0hF02dqblCBzokeYBELidSfTxHYBuECHYse40UTTbU4=; b=vq9iKcKdVa3Hb7kTAW7sQaA4gr9jVKMcK1DhjJjMeky4pBNN3svX14qC3yPg/Inj+U 4sw5wp3cbfH2pOf4Cl52Mrffabm2DaotzO+KKSbKnxicGtJqi5VzGmDKFczEn215VCcf 7nTISI+DFTpjxT+qj2B8hSdSwBr53+3Ur4gY5j7uQuMg1a4Kk1E1bvbQObJFWS5fJHtc n26+LlriJ/idcFqZhTcc7clzcFe87GEcT0RqRkzRVMdZlgMAx7kjSFxYHFESBTVYTVWy ljCtnbELIKyzUY1hEXk3je2Yv2g5+Rz08vM/maX6KReq/n86YvKy2GNRQwD18cAEvhxo 9blQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700007349; x=1700612149; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=0hF02dqblCBzokeYBELidSfTxHYBuECHYse40UTTbU4=; b=bUq/xn9T1wPopz5C4PV2MWjr7Po7lsXtwqdFxS4e0ZfwdweR024LYt6oPltKAuoexZ ku0Qfj7m1CEbelgYkPInCL8L76EfPCXpIr647swjKqbDEBFPagThLcX15sP32pJekvOY WLSw+vd4Fkxw+ZXjzO11Wbsd/5VWwIpcxcMkKXNX85ewDgdPDepQa9ILk/JqJ9Zx9sUK fcwBrHN6RlTSoVlNq5+y836RqOySisu4h5x3XInv69iUPlSpk8Qkn17E/mMybc9uhqu7 c0JmX1xpvrdIeYNc+v1Av94ze/0hzQqZkmazLiBIqGEV5eOE74N2Upa2HrXbLSVm4fMi gRKg== X-Gm-Message-State: AOJu0Yw3kiGTumsqD6itru4R8T0U5WmH3wE8t66Abrae7BnYxJ9dnlcX 0C24CR8alg1ImeinzrqgG7hrZQ== X-Google-Smtp-Source: AGHT+IEp2W3PHnwGgzFMQeN5YyuMe5KWJfgantMx0VvXsAqhKPs9Hp/PVYe5k2kTTV4UhnnmEkTXfw== X-Received: by 2002:a9d:7d97:0:b0:6d3:e5c:768f with SMTP id j23-20020a9d7d97000000b006d30e5c768fmr3597704otn.11.1700007348895; Tue, 14 Nov 2023 16:15:48 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id e70-20020a636949000000b005b6f075da0dsm105816pgc.25.2023.11.14.16.15.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Nov 2023 16:15:48 -0800 (PST) Date: Tue, 14 Nov 2023 16:15:46 -0800 From: Stephen Hemminger To: Tomasz Duszynski Cc: , Jakub Palider , Subject: Re: [PATCH] raw/cnxk_bphy: switch to dynamic logging Message-ID: <20231114161546.00b3ad1e@hermes.local> In-Reply-To: <20231114080446.3574237-1-tduszynski@marvell.com> References: <20231114080446.3574237-1-tduszynski@marvell.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, 14 Nov 2023 09:04:46 +0100 Tomasz Duszynski wrote: > Dynamically allocated log type is a standard approach among all drivers. > Switch to it. > > Signed-off-by: Tomasz Duszynski > --- > drivers/raw/cnxk_bphy/cnxk_bphy.c | 32 +++++++++++++--------- > drivers/raw/cnxk_bphy/cnxk_bphy_cgx.c | 4 ++- > drivers/raw/cnxk_bphy/cnxk_bphy_cgx.h | 7 +++++ > drivers/raw/cnxk_bphy/cnxk_bphy_cgx_test.c | 32 ++++++++++------------ > 4 files changed, 44 insertions(+), 31 deletions(-) Good to see but there seems to be a lot of other places calling plt_err(), plt_info(), plt_warn(), plt_print()