From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B5AD94332D; Tue, 14 Nov 2023 19:22:14 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 422E4402B3; Tue, 14 Nov 2023 19:22:14 +0100 (CET) Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mails.dpdk.org (Postfix) with ESMTP id 489F54027B; Tue, 14 Nov 2023 19:22:13 +0100 (CET) Received: by linux.microsoft.com (Postfix, from userid 1086) id 8013120B74C1; Tue, 14 Nov 2023 10:22:12 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 8013120B74C1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1699986132; bh=6K1oYVGVmyfEG6cPVC3Ql+nFsAvI0Y0IsvCWalKTZ80=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=gr1+Ufa9RiDWxNylNND5bw9s+TAB2OZ74+GTo9yNYFjca4sP4KbLoMrP8RZ/SRr8G zp8c/jgBBpl4ZVCo/RZlLWPmXsANmsCdkGZ+sI9VE1T/ydo+YgARAveo7I8f9/D3d1 x+lDK5BxMEZxSVOkrjxmoPOVh2RMJ0Q82RG1CtX4= Date: Tue, 14 Nov 2023 10:22:12 -0800 From: Tyler Retzlaff To: "Etelson, Gregory" Cc: dev@dpdk.org, mkashani@nvidia.com, thomas@monjalon.net, stable@dpdk.org, Dmitry Kozlyuk , Narcisa Ana Maria Vasile , Dmitry Malloy , Pallavi Kadam Subject: Re: [PATCH] eal/windows: fix memory management macros usage Message-ID: <20231114182212.GA3681@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> References: <20231114170529.176665-1-getelson@nvidia.com> <20231114174637.GC23774@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Nov 14, 2023 at 08:16:22PM +0200, Etelson, Gregory wrote: > Hello Tyler, > > > > >since we are duplicating something that comes from something else that > >has been duplicated out of windows WDK here it might be a reasonable > >safety check to verify that our duplicated values match our > >expectations? > > MEM_COALESCE_PLACEHOLDERS, MEM_PRESERVE_PLACEHOLDER, > MEM_REPLACE_PLACEHOLDER and MEM_RESERVE_PLACEHOLDER > are defined in Win32 API. > > DPDK has no expectations about these values. DPDK needs them as > parameters to the VirtualX function calls. > It looks like the macros were added to EAL because they were missing > in mingw. > > Once compiler environment was fixed, the proper order was restored. yes, there is a lag between when names appear in the actual WDK and when mingw takes a the snapshot of the headers. so long as the copy they take is only from released WDK versions that align with an OS we shouldn't expect the values to change but if the duplicated names in dpdk were based upon an insider (preview version of SDK) value that later got changed there could be a misalignment. unlikely but possible. > > Regards, > Gregory > > > > > >#ifndef MEM_COALESCE_PLACEHOLDERS > >#define MEM_COALESCE_PLACEHOLDERS 0x00000001 > >#else > >static_assert(MEM_COALESCE_PLACEHOLDERS == 0x00000001, "...") > >#endif > > > >either way, this is straight forward. > > > >Acked-by: Tyler Retzlaff > > > >