From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4187E43380; Mon, 20 Nov 2023 17:41:14 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D16BD42DDE; Mon, 20 Nov 2023 17:41:13 +0100 (CET) Received: from mail-pf1-f182.google.com (mail-pf1-f182.google.com [209.85.210.182]) by mails.dpdk.org (Postfix) with ESMTP id E653B42DD2 for <dev@dpdk.org>; Mon, 20 Nov 2023 17:41:12 +0100 (CET) Received: by mail-pf1-f182.google.com with SMTP id d2e1a72fcca58-6cb9dd2ab56so947338b3a.3 for <dev@dpdk.org>; Mon, 20 Nov 2023 08:41:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1700498472; x=1701103272; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=UvkrG7MldHCKOqQlLt5r7z7mg7BaowttFQwSPQMkP08=; b=XovFE7C3qHPwENpYudTz4fD9Q1DN1fsyxMFd0XehlNSr4JmRFhSltz4IXYB+AcPb7Z hxx4D4XNjNepfsU9V3pDkhBpT7FKLfLj5nBHTS1zuB/Is+zjlObk7x2SHG8QAjQU2qSi lwMefAhJCUx+Cy6PqKMUypwd/waelGoJw9k60UbmIj7RM0wfVWWPjC0FNeHt5QbgQsOA H9ne4cA0+EI6dKIm+PzfmP9jyjUw2ezmKSjFwOpN9/3RjkDFDnLPCEDLiyxkQCaFdsKm vl/E6mL4qYruWwH3JaKDN7W/TbPCwIRLvcvG7Rx/C5mWtunhuDOKEQQr5MxLc9wETbW/ G66Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700498472; x=1701103272; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=UvkrG7MldHCKOqQlLt5r7z7mg7BaowttFQwSPQMkP08=; b=ZLCmjFk8o00e1yOhkd7HpzGfAYKlDiRkP0vzxRYyzPJS/7+Vp43QL3+0MP8SKEY0jZ HKslND3QMKHVHsaW7BN9r3PIyqGyzB1vTwDsKxHbVyz7jh2lM324KnMS+ZQWrLyBqErG 2Y6bDknvVsFkSVlRR1fZ0M43IHpQ3bbqQFNEhaWhfGEeBO5iAFJFJu2iJ7lsxmmon6Hb t5IR7dMa/YHapdYsEIG94UUOypUsKWkHbdwAPIk89ezggeHQWS4RALvMK9uWWAPwQKjR +Zegni8RtxPRvEzWEby2jAn/PWxI/6gV4UjgL6hAsX3z4ueXLMv8kbB3fz6WRE7431O4 W/ng== X-Gm-Message-State: AOJu0YytuAu/32TVgt4TjPHXPqx5Pfu5vyFlbPkl+5RXc9JOiO0gE5cG uAyxlIG/mOYquoUjWfw8bfjLkg== X-Google-Smtp-Source: AGHT+IFG/dLNIYL4xRPETx8eDX93Kl06SC27kWLqgmr1AfCu6Vu+/kBKpSbkdkSdfJ6TAhT7ePcRgw== X-Received: by 2002:a05:6a00:1d10:b0:6c2:bc81:2787 with SMTP id a16-20020a056a001d1000b006c2bc812787mr7874674pfx.6.1700498471991; Mon, 20 Nov 2023 08:41:11 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id a8-20020a62bd08000000b006c2d5a31ab9sm6310269pff.81.2023.11.20.08.41.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Nov 2023 08:41:11 -0800 (PST) Date: Mon, 20 Nov 2023 08:41:10 -0800 From: Stephen Hemminger <stephen@networkplumber.org> To: Robin Jarry <rjarry@redhat.com> Cc: dev@dpdk.org, Sunil Kumar Kori <skori@marvell.com> Subject: Re: [PATCH v2 3/3] usertools/rss: add CNXK well-known key Message-ID: <20231120084110.616e2059@hermes.local> In-Reply-To: <20231120162256.74399-6-rjarry@redhat.com> References: <20231023080710.240402-3-rjarry@redhat.com> <20231120162256.74399-4-rjarry@redhat.com> <20231120162256.74399-6-rjarry@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org On Mon, 20 Nov 2023 17:22:59 +0100 Robin Jarry <rjarry@redhat.com> wrote: > diff --git a/usertools/dpdk-rss-flows.py b/usertools/dpdk-rss-flows.py > index fd225a697f08..be9b3d760c03 100755 > --- a/usertools/dpdk-rss-flows.py > +++ b/usertools/dpdk-rss-flows.py > @@ -226,6 +226,23 @@ def reta_size(self, num_queues: int) -> int: > ), > reta_size=512, > ), > + "cnxk": DriverInfo( > + key=bytes( > + ( > + # fmt: off > + # roc_nix_rss_key_default_fill, see drivers/common/cnxk/roc_nix_rss.c > + # Marvell's cnxk NICs take 48 bytes keys > + 0xfe, 0xed, 0x0b, 0xad, 0xfe, 0xed, 0x0b, 0xad, > + 0xfe, 0xed, 0x0b, 0xad, 0xfe, 0xed, 0x0b, 0xad, > + 0xfe, 0xed, 0x0b, 0xad, 0xfe, 0xed, 0x0b, 0xad, > + 0xfe, 0xed, 0x0b, 0xad, 0xfe, 0xed, 0x0b, 0xad, > + 0xfe, 0xed, 0x0b, 0xad, 0xfe, 0xed, 0x0b, 0xad, > + 0xfe, 0xed, 0x0b, 0xad, 0xfe, 0xed, 0x0b, 0xad, > + # fmt: on > + ) > + ), > + reta_size=64, > + ), > } Maybe an enhancement in future to expose the default key better. Having it live in two places means adding new drivers has another thing to worry about (and not documented).