* [PATCH] ethdev: add trace for the new fields added in 23.11
@ 2023-11-21 8:18 Huisong Li
2023-11-21 8:29 ` fengchengwen
0 siblings, 1 reply; 4+ messages in thread
From: Huisong Li @ 2023-11-21 8:18 UTC (permalink / raw)
To: dev, ferruh.yigit, Thomas Monjalon, Andrew Rybchenko
Cc: liuyonglong, lihuisong
The 'max_rx_bufsize' and 'rss_algo_capa' in struct rte_eth_dev_info and
the 'algorithm' in struct rte_eth_rss_conf are introduced to 23.11.
This patch add the trace of these new fields in related trace point
interface.
In addition, the 'max_lro_pkt_size' in struct rte_eth_dev_info is also
important. So this patch also add it.
Signed-off-by: Huisong Li <lihuisong@huawei.com>
---
lib/ethdev/ethdev_trace.h | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/lib/ethdev/ethdev_trace.h b/lib/ethdev/ethdev_trace.h
index e367d29c3a..1b1ae0cfe8 100644
--- a/lib/ethdev/ethdev_trace.h
+++ b/lib/ethdev/ethdev_trace.h
@@ -32,6 +32,7 @@ RTE_TRACE_POINT(
rte_trace_point_emit_u32(dev_conf->link_speeds);
rte_trace_point_emit_u32(dev_conf->rxmode.mq_mode);
rte_trace_point_emit_u32(dev_conf->rxmode.mtu);
+ rte_trace_point_emit_u32(dev_conf->rxmode.max_lro_pkt_size);
rte_trace_point_emit_u64(dev_conf->rxmode.offloads);
rte_trace_point_emit_u32(dev_conf->txmode.mq_mode);
rte_trace_point_emit_u64(dev_conf->txmode.offloads);
@@ -556,7 +557,9 @@ RTE_TRACE_POINT(
rte_trace_point_emit_u16(dev_info->min_mtu);
rte_trace_point_emit_u16(dev_info->max_mtu);
rte_trace_point_emit_u32(dev_info->min_rx_bufsize);
+ rte_trace_point_emit_u32(dev_info->max_rx_bufsize);
rte_trace_point_emit_u32(dev_info->max_rx_pktlen);
+ rte_trace_point_emit_u32(dev_info->max_lro_pkt_size);
rte_trace_point_emit_u16(dev_info->max_rx_queues);
rte_trace_point_emit_u16(dev_info->max_tx_queues);
rte_trace_point_emit_u32(dev_info->max_mac_addrs);
@@ -566,6 +569,7 @@ RTE_TRACE_POINT(
rte_trace_point_emit_u64(dev_info->tx_queue_offload_capa);
rte_trace_point_emit_u16(dev_info->reta_size);
rte_trace_point_emit_u8(dev_info->hash_key_size);
+ rte_trace_point_emit_u32(dev_info->rss_algo_capa);
rte_trace_point_emit_u64(dev_info->flow_type_rss_offloads);
rte_trace_point_emit_u16(dev_info->rx_desc_lim.nb_max);
rte_trace_point_emit_u16(dev_info->rx_desc_lim.nb_min);
@@ -774,6 +778,7 @@ RTE_TRACE_POINT(
rte_trace_point_emit_ptr(rss_conf->rss_key);
rte_trace_point_emit_u8(rss_conf->rss_key_len);
rte_trace_point_emit_u64(rss_conf->rss_hf);
+ rte_trace_point_emit_u32(rss_conf->algorithm);
rte_trace_point_emit_int(ret);
)
@@ -785,6 +790,7 @@ RTE_TRACE_POINT(
rte_trace_point_emit_ptr(rss_conf->rss_key);
rte_trace_point_emit_u8(rss_conf->rss_key_len);
rte_trace_point_emit_u64(rss_conf->rss_hf);
+ rte_trace_point_emit_u32(rss_conf->algorithm);
rte_trace_point_emit_int(ret);
)
--
2.33.0
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ethdev: add trace for the new fields added in 23.11
2023-11-21 8:18 [PATCH] ethdev: add trace for the new fields added in 23.11 Huisong Li
@ 2023-11-21 8:29 ` fengchengwen
2023-11-21 12:12 ` Ferruh Yigit
0 siblings, 1 reply; 4+ messages in thread
From: fengchengwen @ 2023-11-21 8:29 UTC (permalink / raw)
To: Huisong Li, dev, ferruh.yigit, Thomas Monjalon, Andrew Rybchenko
Cc: liuyonglong
Acked-by: Chengwen Feng <fengchengwen@huawei.com>
On 2023/11/21 16:18, Huisong Li wrote:
> The 'max_rx_bufsize' and 'rss_algo_capa' in struct rte_eth_dev_info and
> the 'algorithm' in struct rte_eth_rss_conf are introduced to 23.11.
> This patch add the trace of these new fields in related trace point
> interface.
>
> In addition, the 'max_lro_pkt_size' in struct rte_eth_dev_info is also
> important. So this patch also add it.
>
> Signed-off-by: Huisong Li <lihuisong@huawei.com>
> ---
> lib/ethdev/ethdev_trace.h | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/lib/ethdev/ethdev_trace.h b/lib/ethdev/ethdev_trace.h
> index e367d29c3a..1b1ae0cfe8 100644
> --- a/lib/ethdev/ethdev_trace.h
> +++ b/lib/ethdev/ethdev_trace.h
> @@ -32,6 +32,7 @@ RTE_TRACE_POINT(
> rte_trace_point_emit_u32(dev_conf->link_speeds);
> rte_trace_point_emit_u32(dev_conf->rxmode.mq_mode);
> rte_trace_point_emit_u32(dev_conf->rxmode.mtu);
> + rte_trace_point_emit_u32(dev_conf->rxmode.max_lro_pkt_size);
> rte_trace_point_emit_u64(dev_conf->rxmode.offloads);
> rte_trace_point_emit_u32(dev_conf->txmode.mq_mode);
> rte_trace_point_emit_u64(dev_conf->txmode.offloads);
> @@ -556,7 +557,9 @@ RTE_TRACE_POINT(
> rte_trace_point_emit_u16(dev_info->min_mtu);
> rte_trace_point_emit_u16(dev_info->max_mtu);
> rte_trace_point_emit_u32(dev_info->min_rx_bufsize);
> + rte_trace_point_emit_u32(dev_info->max_rx_bufsize);
> rte_trace_point_emit_u32(dev_info->max_rx_pktlen);
> + rte_trace_point_emit_u32(dev_info->max_lro_pkt_size);
> rte_trace_point_emit_u16(dev_info->max_rx_queues);
> rte_trace_point_emit_u16(dev_info->max_tx_queues);
> rte_trace_point_emit_u32(dev_info->max_mac_addrs);
> @@ -566,6 +569,7 @@ RTE_TRACE_POINT(
> rte_trace_point_emit_u64(dev_info->tx_queue_offload_capa);
> rte_trace_point_emit_u16(dev_info->reta_size);
> rte_trace_point_emit_u8(dev_info->hash_key_size);
> + rte_trace_point_emit_u32(dev_info->rss_algo_capa);
> rte_trace_point_emit_u64(dev_info->flow_type_rss_offloads);
> rte_trace_point_emit_u16(dev_info->rx_desc_lim.nb_max);
> rte_trace_point_emit_u16(dev_info->rx_desc_lim.nb_min);
> @@ -774,6 +778,7 @@ RTE_TRACE_POINT(
> rte_trace_point_emit_ptr(rss_conf->rss_key);
> rte_trace_point_emit_u8(rss_conf->rss_key_len);
> rte_trace_point_emit_u64(rss_conf->rss_hf);
> + rte_trace_point_emit_u32(rss_conf->algorithm);
> rte_trace_point_emit_int(ret);
> )
>
> @@ -785,6 +790,7 @@ RTE_TRACE_POINT(
> rte_trace_point_emit_ptr(rss_conf->rss_key);
> rte_trace_point_emit_u8(rss_conf->rss_key_len);
> rte_trace_point_emit_u64(rss_conf->rss_hf);
> + rte_trace_point_emit_u32(rss_conf->algorithm);
> rte_trace_point_emit_int(ret);
> )
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ethdev: add trace for the new fields added in 23.11
2023-11-21 8:29 ` fengchengwen
@ 2023-11-21 12:12 ` Ferruh Yigit
2023-11-21 12:39 ` lihuisong (C)
0 siblings, 1 reply; 4+ messages in thread
From: Ferruh Yigit @ 2023-11-21 12:12 UTC (permalink / raw)
To: fengchengwen, Huisong Li, dev, Thomas Monjalon, Andrew Rybchenko
Cc: liuyonglong
On 11/21/2023 8:29 AM, fengchengwen wrote:
> On 2023/11/21 16:18, Huisong Li wrote:
>> The 'max_rx_bufsize' and 'rss_algo_capa' in struct rte_eth_dev_info and
>> the 'algorithm' in struct rte_eth_rss_conf are introduced to 23.11.
>> This patch add the trace of these new fields in related trace point
>> interface.
>>
>> In addition, the 'max_lro_pkt_size' in struct rte_eth_dev_info is also
>> important. So this patch also add it.
>>
>> Signed-off-by: Huisong Li <lihuisong@huawei.com>
>
> Acked-by: Chengwen Feng <fengchengwen@huawei.com>
>
Fixes: 75c7849a9dcc ("ethdev: add maximum Rx buffer size")
Fixes: 34ff088cc241 ("ethdev: set and query RSS hash algorithm")
Reviewed-by: Ferruh Yigit <ferruh.yigit@amd.com>
'max_lro_pkt_size' seems forgotten, and it is not a new field, so patch
adding it should be backported to old releases.
That is why I removed the 'max_lro_pkt_size' from this patch and updated
commit log accordingly, Will send a separate patch for it.
Applied to dpdk-next-net/main, thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] ethdev: add trace for the new fields added in 23.11
2023-11-21 12:12 ` Ferruh Yigit
@ 2023-11-21 12:39 ` lihuisong (C)
0 siblings, 0 replies; 4+ messages in thread
From: lihuisong (C) @ 2023-11-21 12:39 UTC (permalink / raw)
To: Ferruh Yigit
Cc: liuyonglong, fengchengwen, Thomas Monjalon, Andrew Rybchenko, dev
在 2023/11/21 20:12, Ferruh Yigit 写道:
> On 11/21/2023 8:29 AM, fengchengwen wrote:
>
>> On 2023/11/21 16:18, Huisong Li wrote:
>>> The 'max_rx_bufsize' and 'rss_algo_capa' in struct rte_eth_dev_info and
>>> the 'algorithm' in struct rte_eth_rss_conf are introduced to 23.11.
>>> This patch add the trace of these new fields in related trace point
>>> interface.
>>>
>>> In addition, the 'max_lro_pkt_size' in struct rte_eth_dev_info is also
>>> important. So this patch also add it.
>>>
>>> Signed-off-by: Huisong Li <lihuisong@huawei.com>
>> Acked-by: Chengwen Feng <fengchengwen@huawei.com>
>>
> Fixes: 75c7849a9dcc ("ethdev: add maximum Rx buffer size")
> Fixes: 34ff088cc241 ("ethdev: set and query RSS hash algorithm")
>
> Reviewed-by: Ferruh Yigit <ferruh.yigit@amd.com>
>
>
> 'max_lro_pkt_size' seems forgotten, and it is not a new field, so patch
> adding it should be backported to old releases.
> That is why I removed the 'max_lro_pkt_size' from this patch and updated
> commit log accordingly, Will send a separate patch for it.
Thanks so much for separating this patch for 'max_lro_pkt_size'. 😁
>
>
> Applied to dpdk-next-net/main, thanks.
> .
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-11-21 12:39 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-11-21 8:18 [PATCH] ethdev: add trace for the new fields added in 23.11 Huisong Li
2023-11-21 8:29 ` fengchengwen
2023-11-21 12:12 ` Ferruh Yigit
2023-11-21 12:39 ` lihuisong (C)
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).