From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 047F943390; Tue, 21 Nov 2023 17:46:46 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C99CB42E8E; Tue, 21 Nov 2023 17:46:45 +0100 (CET) Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) by mails.dpdk.org (Postfix) with ESMTP id 03C7040DCD for ; Tue, 21 Nov 2023 17:46:44 +0100 (CET) Received: by mail-pl1-f174.google.com with SMTP id d9443c01a7336-1cc3542e328so42848795ad.1 for ; Tue, 21 Nov 2023 08:46:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1700585203; x=1701190003; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=hcCprw59l44QI8vOwmHYfYm+1yLYsJr7h92VG79Z8+4=; b=S53clZPRR/q3e2MdoaAnhm161b2obRkCV9wt42K7mH1XqzMgraqNtaBcmn9qzmgOAY hbcEF7EA5Dq1tJmZnu+ubA3MOGscDJUX95Ij9Ajq58r7M8ACl14AnZljYbxQTTehRy4B Ka07T6f4ngDY2pvpahA6Yc0CV3ThCFJyHO3e4516Wrka0Sba6gFFEvGl/V4Xgqt8AM7y AWpzHp14jvmpA0GwOly1muyXUN1l59KERIR3jp4aqmMhqvh/+gfVgugsF38BJmfy1CwM 0mDbWqoZU0rAJYwME9eHnHkWFJY83v6ttVcV1Qs14iw9nLQdiF2A20xP1VBTrCoRbarQ /fuw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700585203; x=1701190003; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=hcCprw59l44QI8vOwmHYfYm+1yLYsJr7h92VG79Z8+4=; b=SYZ3sQVgJ48R1qR7eyMyE3mYjiiSDJwnCNDcZlnWNtEKBD0RAOZnx0ZRIG5gcKq+hV cM3O2XaNNj524A65Vzutas9X0CojTW6Q7n42EPeOD5i4MSfG35w/QT55BeDiRROIt4+K V8pomnatwiGC+wg2PlrmfRVmH0wqn0JDvtfMnx+gbbUXhDbB2Jrldy0V+Rrrv3Oa84Jt 42RQYe+km5rz5vRMCCDn1WM3yvVRin8/A/FYm5A1cJYybK+4/hA50ReE6vjbGA9PzwFT JwIq87heMw60e0WzxZoaSCk7N+rwHw2KsIF2Hzuk+QAS1D8atxtm4LYag4XTNH4CIm+v Mqhg== X-Gm-Message-State: AOJu0Ywu6H+qZjx//WM7ckdkGMI/pHU3Jq6pY0O8sbQILJB9NPgLsmSa qohBtX/du61eFKym0HQpbVnr+A== X-Google-Smtp-Source: AGHT+IEkn+DNy7/dRsJSujIy3uNt2/UwdEQ3/bccO3nSULoTdynilelRs8tK9AlKvNYMEN0i8g4cYA== X-Received: by 2002:a17:902:9896:b0:1cc:43a9:5ce9 with SMTP id s22-20020a170902989600b001cc43a95ce9mr9857840plp.58.1700585203120; Tue, 21 Nov 2023 08:46:43 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id a12-20020a170902ee8c00b001c74876f018sm8196819pld.18.2023.11.21.08.46.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Nov 2023 08:46:42 -0800 (PST) Date: Tue, 21 Nov 2023 08:46:41 -0800 From: Stephen Hemminger To: Hemant Agrawal Cc: "dev@dpdk.org" , Sachin Saxena , Gagandeep Singh Subject: Re: [PATCH v4 10/10] common/dpaxx: remove zero length array Message-ID: <20231121084641.39e7b39b@hermes.local> In-Reply-To: References: <20230113215205.125767-1-stephen@networkplumber.org> <20231120170942.197172-1-stephen@networkplumber.org> <20231120170942.197172-11-stephen@networkplumber.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, 21 Nov 2023 10:49:59 +0000 Hemant Agrawal wrote: > > struct ipsec_encap_pdb { > > uint32_t options; > > @@ -350,7 +349,6 @@ struct ipsec_encap_pdb { > > }; > > uint32_t spi; > > uint32_t ip_hdr_len; > > - uint8_t ip_hdr[0]; > [Hemant] This should be replaced with > uint8_t ip_hdr[]; > > }; > > That won't work because the structure is embedded in another struct and then clang will correctly report an error.