From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8EC2843391; Tue, 21 Nov 2023 18:04:28 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7AF5342E8E; Tue, 21 Nov 2023 18:04:28 +0100 (CET) Received: from mail-pj1-f49.google.com (mail-pj1-f49.google.com [209.85.216.49]) by mails.dpdk.org (Postfix) with ESMTP id 60EA540DCD for ; Tue, 21 Nov 2023 18:04:27 +0100 (CET) Received: by mail-pj1-f49.google.com with SMTP id 98e67ed59e1d1-2851967b945so1989785a91.1 for ; Tue, 21 Nov 2023 09:04:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1700586266; x=1701191066; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=CD9DwggaUk3DWgqHLv+m/mR8Ys1HbhRKzVzLtZ0Cgpg=; b=LNDM7jf684Mj8qEmP3GIEIE6D1CESN380dNJpzuajxxbDcXy8E39eGINL35bOS2fO6 PYN47VXe6+mpC+kAicqCt/ryo1PxaCcIOHUMjU0NE2oE51gw4Yg/zv3wMDpdeGfbxGUO KkBW4pVws+qGZ/0GMdrle/QF7zd5m+pUtYfrrtyyNcpjQeg2p1hK7l5npLmcbenJ2otU P8Ng63LX9SGPYDP5weJl92mlhAEXXYsb7saUGN7kLgWKAP42hMQSz3AisPZBFrk0IlLS rxUpPxXpXQB9EmC+KrGB6Qfq62A741zNaoQTbkPTWea9V5HHvyek/z3ewQXqRznqMIEp 9jig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700586266; x=1701191066; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=CD9DwggaUk3DWgqHLv+m/mR8Ys1HbhRKzVzLtZ0Cgpg=; b=L2/1YZX9+N7qEkAtKzh6627H8XRCHPrbcNv2g8KpvAYfvCv/ZvsBTojE3sEQvr2b8k tuXNsln6ZmP47ODSl7PnTZJTf2++wGFV9Me7ie9QexwAw6IT7wBxwJby2hUDvBY79Wks wU/fSLbIgB3L3Mz2leF/uYCovFLPgceBG8UnrIxvgQtK0HbcYj3qlvMV72xLDcDkXQdb qDcpJil2+2Hwwoyh4M6Jmxm+OaIINhcxqMvkV/cJ6A5HsHDs5KGDJ7YrHkYuylpJEk7x I56BwVIG9AHFZ+sME3RqiY7w6bLtsTtG4Jn1+hrWfuCph8hJ7EAfbkTdbZMnJzNuRcpG Dmnw== X-Gm-Message-State: AOJu0Yw/jOPMjCZfzSuApsA8zkuCxDowZYWaVYq421ME1EsYmzVwips1 +7CK9BChxrCV4PPTLoWYHlJSbA== X-Google-Smtp-Source: AGHT+IFOU38qYdhe9DYtJO9rWWDTyBsaDW9dgXxVFzBdgnkm8Qw5l6sUNZE+bR7CQlrfpbSA8cBtDQ== X-Received: by 2002:a17:90b:38d2:b0:280:299d:4b7e with SMTP id nn18-20020a17090b38d200b00280299d4b7emr4957663pjb.19.1700586266499; Tue, 21 Nov 2023 09:04:26 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id w33-20020a17090a6ba400b0028066f3c373sm10511284pjj.17.2023.11.21.09.04.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Nov 2023 09:04:25 -0800 (PST) Date: Tue, 21 Nov 2023 09:04:23 -0800 From: Stephen Hemminger To: Jerin Jacob Cc: Robin Jarry , dev@dpdk.org, skori@marvell.com, thomas@monjalon.net Subject: Re: [PATCH 1/2] usertools/rss: add driver abstractions Message-ID: <20231121090423.639655f4@hermes.local> In-Reply-To: References: <20231023080710.240402-3-rjarry@redhat.com> <20231121083855.6ae8e362@hermes.local> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, 21 Nov 2023 22:21:54 +0530 Jerin Jacob wrote: > > The tool should not need to have driver specific tables like this. > > DPDK is already riddled with enough driver specific quirks.. > > > > That shows a flaw in the rss design, which should have been fixed. > > Every NIC's implements standard Toeplitz hash algorithm for RSS hash generation. > Only the initial SEED is different. It is not DPDK property, all the > HW like is that as > there is no standardization on initial SEED for hash. The tool should be able to query the default key from driver, or the build infrastructure should extract and generate the table.