* [PATCH] net/i40e: remove redundant judgment in fdir parse
@ 2023-11-24 7:01 Kaiwen Deng
2023-12-14 2:12 ` Zhang, Qi Z
0 siblings, 1 reply; 2+ messages in thread
From: Kaiwen Deng @ 2023-11-24 7:01 UTC (permalink / raw)
To: dev
Cc: stable, qiming.yang, yidingx.zhou, Kaiwen Deng, Yuying Zhang,
Beilei Xing, Jingjing Wu
if (eth_spec && eth_mask &&
next_type == RTE_FLOW_ITEM_TYPE_END) {
...
if (next_type == RTE_FLOW_ITEM_TYPE_VLAN || ...) {
...
}
...
}
Clearly, that condition in the inner "if" is always "false".
This commit will remove the redundant judgment.
Fixes: 7d83c152a207 ("net/i40e: parse flow director filter")
Cc: stable@dpdk.org
Signed-off-by: Kaiwen Deng <kaiwenx.deng@intel.com>
---
drivers/net/i40e/i40e_flow.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/net/i40e/i40e_flow.c b/drivers/net/i40e/i40e_flow.c
index 877e49151e..92165c8422 100644
--- a/drivers/net/i40e/i40e_flow.c
+++ b/drivers/net/i40e/i40e_flow.c
@@ -1708,8 +1708,7 @@ i40e_flow_parse_fdir_pattern(struct rte_eth_dev *dev,
ether_type = rte_be_to_cpu_16(eth_spec->hdr.ether_type);
- if (next_type == RTE_FLOW_ITEM_TYPE_VLAN ||
- ether_type == RTE_ETHER_TYPE_IPV4 ||
+ if (ether_type == RTE_ETHER_TYPE_IPV4 ||
ether_type == RTE_ETHER_TYPE_IPV6 ||
ether_type == i40e_get_outer_vlan(dev)) {
rte_flow_error_set(error, EINVAL,
--
2.34.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* RE: [PATCH] net/i40e: remove redundant judgment in fdir parse
2023-11-24 7:01 [PATCH] net/i40e: remove redundant judgment in fdir parse Kaiwen Deng
@ 2023-12-14 2:12 ` Zhang, Qi Z
0 siblings, 0 replies; 2+ messages in thread
From: Zhang, Qi Z @ 2023-12-14 2:12 UTC (permalink / raw)
To: Deng, KaiwenX, dev
Cc: stable, Yang, Qiming, Zhou, YidingX, Deng, KaiwenX, Zhang,
Yuying, Xing, Beilei, Wu, Jingjing
> -----Original Message-----
> From: Kaiwen Deng <kaiwenx.deng@intel.com>
> Sent: Friday, November 24, 2023 3:01 PM
> To: dev@dpdk.org
> Cc: stable@dpdk.org; Yang, Qiming <qiming.yang@intel.com>; Zhou, YidingX
> <yidingx.zhou@intel.com>; Deng, KaiwenX <kaiwenx.deng@intel.com>; Zhang,
> Yuying <yuying.zhang@intel.com>; Xing, Beilei <beilei.xing@intel.com>; Wu,
> Jingjing <jingjing.wu@intel.com>
> Subject: [PATCH] net/i40e: remove redundant judgment in fdir parse
>
> if (eth_spec && eth_mask &&
> next_type == RTE_FLOW_ITEM_TYPE_END) {
> ...
> if (next_type == RTE_FLOW_ITEM_TYPE_VLAN || ...) {
> ...
> }
> ...
> }
>
> Clearly, that condition in the inner "if" is always "false".
>
> This commit will remove the redundant judgment.
>
> Fixes: 7d83c152a207 ("net/i40e: parse flow director filter")
> Cc: stable@dpdk.org
>
> Signed-off-by: Kaiwen Deng <kaiwenx.deng@intel.com>
Acked-by: Qi Zhang <qi.z.zhang@intel.com>
Applied to dpdk-next-net-intel.
Thanks
Qi
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-12-14 2:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-11-24 7:01 [PATCH] net/i40e: remove redundant judgment in fdir parse Kaiwen Deng
2023-12-14 2:12 ` Zhang, Qi Z
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).