From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CB82A433FD; Tue, 5 Dec 2023 03:13:43 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BA66440299; Tue, 5 Dec 2023 03:13:43 +0100 (CET) Received: from mail-oo1-f50.google.com (mail-oo1-f50.google.com [209.85.161.50]) by mails.dpdk.org (Postfix) with ESMTP id 9057440291 for ; Tue, 5 Dec 2023 03:13:41 +0100 (CET) Received: by mail-oo1-f50.google.com with SMTP id 006d021491bc7-58cecfb4412so3514216eaf.3 for ; Mon, 04 Dec 2023 18:13:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1701742421; x=1702347221; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ktvqRYTn4ozDjWOycQC4Rjgopfs9ESWkzMPwdSJz5Gc=; b=DXJddwPnLA8tynTkIryK9citwjLbvnDA0CdHglahizyhn1Mzue/7rdj6vI5gfjL2yu yeJHMqwsyTgxkIAi4PhB31sH3aGG3B+fL3X3DGu/8ttUXv9cZTCW/zEadv/VSd6gA4gR Y/yhQR0nlVTU3sqHakiZ645NvPqHbOqxNVarmBd8wiK8a8z0q+7sA0CsFMNM3ebJvmIA urfGlifxXXW2lZgN0bZk06mdcv17VTcEmDh02x5m5EIRpCj2bUgrCbl6Dk2hVtr9unMg nBOqphImPbUV48EaiYHNZLpRTtMH+KDLImaf7OQ1VLYb74LTjjpgHUUTO0Cz+tG5C+Ln HSQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701742421; x=1702347221; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ktvqRYTn4ozDjWOycQC4Rjgopfs9ESWkzMPwdSJz5Gc=; b=I+UkILgY50haLABVqOMQ2kJOIddep2WIr8PX1llq4Gji93CSMNbYN4BC9cK/Gac7xF 2Ihn0ula1vYXbTyds+eFWse5NPi9Y/fu5tN0knMFzBaHcVgPbLSTrYeP0WWPnwJMmlwI NgacJ0Lw9VtA3jDDlD4fUGz4zptqnldDS+9Hpz4Xp5+Xz6roAaYqPG3/5t3iGsc0RSEJ +n7q+O30Wbhkz2dIrvMk0zZSTGVGdut0n0R9eEJ2QOJqXjGcP/ao4ayhIjD+CXUz1TQp DZYGHtXiitQwfWSkyjfGtUQt4EifS0y0ZkN6nFhILQ3yxfecOgVXgPIwagBQxxXqXB6I Ifsw== X-Gm-Message-State: AOJu0YwuIrKqePSoPPtn9QANhYTMbmKttUQB3IvW/bukOi5rjUj6z16m NHSftf55gLF8M+EcSmIG5ud/hwfYu4a1FvjD+ek= X-Google-Smtp-Source: AGHT+IEHL6B+dq6KZgYW4qtHEUUmQTidDCZHDego5SJPVbCUTRaoTdbl9J/Pjv0mJf67Co31xiqGBA== X-Received: by 2002:a05:6358:5285:b0:16e:12c:16b8 with SMTP id g5-20020a056358528500b0016e012c16b8mr7489734rwa.7.1701742420503; Mon, 04 Dec 2023 18:13:40 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id p26-20020a62b81a000000b0069346777241sm355958pfe.97.2023.12.04.18.13.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Dec 2023 18:13:40 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger Subject: [PATCH 00/18] Convert static log types in libraries to dynamic Date: Mon, 4 Dec 2023 18:09:38 -0800 Message-ID: <20231205021330.260017-1-stephen@networkplumber.org> X-Mailer: git-send-email 2.42.0 In-Reply-To: <20230329234049.11071-1-stephen@networkplumber.org> References: <20230329234049.11071-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org This patchset removes most of the uses of static LOGTYPE's in DPDK libraries. It starts with the easy one and goes on to the more complex ones. There are several options on how to treat the old static types: leave them there, mark as deprecated, or remove them. This version removes them since there is no guarantee in current DPDK policies that says they can't be removed. Note: there is one patch in this series that will get flagged incorrectly as an ABI change. v14 - rebase on 24.03-rc0 skip port, table and pipeline libraries since lots of to be deprecated code. v13 - rebase because log now moved. v12 - rebase and add table and pipeline libraries v11 - fix include check on arm cross build v10 - add necessary rte_compat.h in thash_gfni stub for arm v9 - fix handling of crc32 alg in lib/hash. make it an internal global variable. fix gfni stubs for case where they are not used. Stephen Hemminger (18): gso: don't log message on non TCP/UDP eal: drop no longer used GSO logtype log: drop unused RTE_LOGTYPE_TIMER efd: convert RTE_LOGTYPE_EFD to dynamic type mbuf: convert RTE_LOGTYPE_MBUF to dynamic type acl: convert RTE_LOGTYPE_ACL to dynamic type examples/power: replace use of RTE_LOGTYPE_POWER examples/l3fwd-power: replace use of RTE_LOGTYPE_POWER power: convert RTE_LOGTYPE_POWER to dynamic type ring: convert RTE_LOGTYPE_RING to dynamic type mempool: convert RTE_LOGTYPE_MEMPOOL to dynamic type lpm: convert RTE_LOGTYPE_LPM to dynamic types sched: convert RTE_LOGTYPE_SCHED to dynamic type examples/ipsec-secgw: replace RTE_LOGTYPE_PORT app/test: remove use of RTE_LOGTYPE_PIPELINE hash: mover rte_thash_gfni stubs out of header file hash: move rte_hash_set_alg out of header file hash: convert RTE_LOGTYPE_HASH to dynamic type app/test/test_acl.c | 2 +- app/test/test_table_acl.c | 50 ++++++++++++------------- app/test/test_table_pipeline.c | 40 ++++++++++---------- examples/distributor/main.c | 2 +- examples/ipsec-secgw/sa.c | 6 +-- examples/l3fwd-power/main.c | 17 +++++---- lib/acl/acl.h | 1 + lib/acl/acl_bld.c | 3 ++ lib/acl/acl_gen.c | 1 + lib/acl/acl_log.h | 6 +++ lib/acl/rte_acl.c | 3 ++ lib/acl/tb_mem.c | 3 +- lib/efd/rte_efd.c | 4 ++ lib/fib/fib_log.h | 4 ++ lib/fib/rte_fib.c | 3 ++ lib/fib/rte_fib6.c | 2 + lib/gso/rte_gso.c | 4 +- lib/gso/rte_gso.h | 1 + lib/hash/meson.build | 9 ++++- lib/hash/rte_crc_arm64.h | 8 ++-- lib/hash/rte_crc_x86.h | 10 ++--- lib/hash/rte_cuckoo_hash.c | 5 +++ lib/hash/rte_fbk_hash.c | 5 +++ lib/hash/rte_hash_crc.c | 68 ++++++++++++++++++++++++++++++++++ lib/hash/rte_hash_crc.h | 48 ++---------------------- lib/hash/rte_thash.c | 3 ++ lib/hash/rte_thash_gfni.c | 50 +++++++++++++++++++++++++ lib/hash/rte_thash_gfni.h | 23 +++--------- lib/hash/version.map | 9 +++++ lib/log/log.c | 13 ------- lib/log/rte_log.h | 26 ++++++------- lib/lpm/lpm_log.h | 4 ++ lib/lpm/rte_lpm.c | 3 ++ lib/lpm/rte_lpm6.c | 1 + lib/mbuf/mbuf_log.h | 4 ++ lib/mbuf/rte_mbuf.c | 4 ++ lib/mbuf/rte_mbuf_dyn.c | 2 + lib/mbuf/rte_mbuf_pool_ops.c | 2 + lib/mempool/rte_mempool.c | 2 + lib/mempool/rte_mempool.h | 8 ++++ lib/mempool/version.map | 3 ++ lib/power/power_common.c | 2 + lib/power/power_common.h | 2 + lib/power/power_kvm_vm.c | 1 + lib/power/rte_power.c | 1 + lib/power/rte_power_uncore.c | 1 + lib/rib/rib_log.h | 4 ++ lib/rib/rte_rib.c | 3 ++ lib/rib/rte_rib6.c | 3 ++ lib/ring/rte_ring.c | 3 ++ lib/sched/rte_pie.c | 1 + lib/sched/rte_sched.c | 5 +++ lib/sched/rte_sched_log.h | 4 ++ 53 files changed, 329 insertions(+), 163 deletions(-) create mode 100644 lib/acl/acl_log.h create mode 100644 lib/fib/fib_log.h create mode 100644 lib/hash/rte_hash_crc.c create mode 100644 lib/hash/rte_thash_gfni.c create mode 100644 lib/lpm/lpm_log.h create mode 100644 lib/mbuf/mbuf_log.h create mode 100644 lib/rib/rib_log.h create mode 100644 lib/sched/rte_sched_log.h -- 2.42.0