From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E55004369E; Thu, 7 Dec 2023 23:41:15 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7C33940295; Thu, 7 Dec 2023 23:41:15 +0100 (CET) Received: from mail-pf1-f181.google.com (mail-pf1-f181.google.com [209.85.210.181]) by mails.dpdk.org (Postfix) with ESMTP id 6869C4027A for ; Thu, 7 Dec 2023 23:41:14 +0100 (CET) Received: by mail-pf1-f181.google.com with SMTP id d2e1a72fcca58-6ce939ecfc2so1054412b3a.2 for ; Thu, 07 Dec 2023 14:41:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1701988873; x=1702593673; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=NVvzxnbXPZBUVR7aLZ/oxh6WYRys15/QbwVdeUz+xnA=; b=r5S/hIkpSbjRO9vHspzj85wPQM9ucg7lXRlHv66GM66jtgVe2fypXKLH+T48unceF0 e8O8X4X058PadwXtDLHHBH4isYyGoPhSm2bhRfhji2unUDhjOqlVEclkmbIENTIyQAKA QQTGn5o6kGBkAiZwgNkT2qN2vNl0WUnoWePS1ip0TQagqCfOtv9JOMOKDtHEILfgc/55 4UqVvXL50TdlKURA5UwGH/K06aAFeiRpHkqOk0sNDf4DQQf2DTPMoQh/LE1r4dwnzmPe Rj5nJLjw2dUzvJ0qH64pNYWXAA164OoMZ6nbp0PPrMZcXD7f9Al3lYNgTkUSBMogB4wr TgFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701988873; x=1702593673; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=NVvzxnbXPZBUVR7aLZ/oxh6WYRys15/QbwVdeUz+xnA=; b=s4jatVhZk6TLu1e569u4N6CKRuUvTITbNc5n45iW5kOyzLUBdT0rKPDNhTBo7wmr9N DMxwkwNzeT5Gan1ndFSUDLpMcFmRDvpyc3eUJsASiv4OZCuJNXKzC86FG9ekxcyiWf76 BUnGXoqDrBSwG9Frw8tBzlpfC8K4NYkW4abGWzOyjXC4WgO9BrilUXZozweAXwma7hLi B7qIAKchfcblHN2DJOLtYi8ir8Yx+3jwzr83wQTlXrTkHM5cu1NdVRSWUIELKe05/xaU TqD8WBfUH7RjjeW4BigDgDHrLnvqFHOcdxvcoBs/WWLtklYkTOXzaBa8jGxcuQqvGw3C kF6g== X-Gm-Message-State: AOJu0YydfHFl/L7Kt5uUD5JbX3lfAUiQHIVnOCr5lejJpfWoEJyoAX2m UTDze8l5HYBJfrPcE1L6vyuKzw== X-Google-Smtp-Source: AGHT+IFJxzw6IOCZPEMrJvPpsrb6mEZ1n2PpdxzDzdB17rt+XICqYYX2+1UClIgXSXjYIMq+mKcgmA== X-Received: by 2002:a05:6a00:4c10:b0:6cd:f91e:dfe4 with SMTP id ea16-20020a056a004c1000b006cdf91edfe4mr3913119pfb.2.1701988873466; Thu, 07 Dec 2023 14:41:13 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id u17-20020aa78491000000b006cb98a269f1sm289840pfn.125.2023.12.07.14.41.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 Dec 2023 14:41:13 -0800 (PST) Date: Thu, 7 Dec 2023 14:41:11 -0800 From: Stephen Hemminger To: Joyce Kong Cc: thomas@monjalon.net, ruifeng.wang@arm.com, bruce.richardson@intel.com, dev@dpdk.org, nd@arm.com, stable@dpdk.org Subject: Re: [PATCH v4 1/2] config: correct cpu instruction set for cross build Message-ID: <20231207144111.7b9405fd@hermes.local> In-Reply-To: <20231205035259.3516625-2-joyce.kong@arm.com> References: <20230822074743.3243015-1-joyce.kong@arm.com> <20231205035259.3516625-1-joyce.kong@arm.com> <20231205035259.3516625-2-joyce.kong@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, 5 Dec 2023 03:52:58 +0000 Joyce Kong wrote: > The platform value would be 'native' only when not cross build. > Move the operation about modifying cpu_instruction_set while > platform equals 'native' to the not cross build branch. > > Fixes: bf66003b51ec ("build: use platform for generic and native builds") > Cc: stable@dpdk.org > > Signed-off-by: Joyce Kong > Reviewed-by: Ruifeng Wang Looks right, what is the impact on existing users doing current cross builds? Acked-by: Stephen Hemminger