From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 479D84368D;
	Thu,  7 Dec 2023 20:43:45 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 323F042F04;
	Thu,  7 Dec 2023 20:43:45 +0100 (CET)
Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182])
 by mails.dpdk.org (Postfix) with ESMTP id 6586342E7B
 for <dev@dpdk.org>; Thu,  7 Dec 2023 20:43:44 +0100 (CET)
Received: by linux.microsoft.com (Postfix, from userid 1086)
 id B9C4920B74C0; Thu,  7 Dec 2023 11:43:43 -0800 (PST)
DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com B9C4920B74C0
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;
 s=default; t=1701978223;
 bh=nI8AtCbbkWg3xXthUU3lQG97vytxk3OWrAdWS25Vscc=;
 h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
 b=pyRKKNcnmSrCyo1CfgYPJrZzj51bFRJdEmawJ6+DlWxVCUGTcXeFLoaxGoXv8jqUn
 dorVvHQGpfuJirutb+KMKULJI9coLesUiXTPkxaLX+KiGglnHc0R6tyxWHPUw8708i
 QRj/2QCv8xrjJ2IYXQSsUJ0YX/6S0onnx5Do2aN4=
Date: Thu, 7 Dec 2023 11:43:43 -0800
From: Tyler Retzlaff <roretzla@linux.microsoft.com>
To: dev@dpdk.org
Cc: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>,
 Pallavi Kadam <pallavi.kadam@intel.com>
Subject: Re: [PATCH] eal: initialize shared plugins on Windows
Message-ID: <20231207194343.GB17449@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
References: <1701976851-17275-1-git-send-email-roretzla@linux.microsoft.com>
 <1701976851-17275-2-git-send-email-roretzla@linux.microsoft.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1701976851-17275-2-git-send-email-roretzla@linux.microsoft.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

On Thu, Dec 07, 2023 at 11:20:51AM -0800, Tyler Retzlaff wrote:
> When EAL is built with MSVC it is possible to dynamically load plugins
> on Windows. Hook eal_plugins_init into rte_eal_init if built with MSVC
> and provide code to load plugins on Windows.
> 
> Signed-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>
> ---
>  lib/eal/common/eal_common_options.c | 92 ++++++++++++++++++++++++++++++-------
>  lib/eal/windows/eal.c               |  8 ++++
>  2 files changed, 84 insertions(+), 16 deletions(-)
> 
> diff --git a/lib/eal/common/eal_common_options.c b/lib/eal/common/eal_common_options.c
> index a6d21f1..3f9a030 100644
> --- a/lib/eal/common/eal_common_options.c
> +++ b/lib/eal/common/eal_common_options.c
> @@ -18,9 +18,7 @@
>  #include <libgen.h>
>  #endif
>  #include <sys/stat.h>
> -#ifndef RTE_EXEC_ENV_WINDOWS
>  #include <dirent.h>
> -#endif
>  
>  #include <rte_string_fns.h>
>  #include <rte_eal.h>
> @@ -74,7 +72,7 @@
>  	{OPT_HELP,              0, NULL, OPT_HELP_NUM             },
>  	{OPT_HUGE_DIR,          1, NULL, OPT_HUGE_DIR_NUM         },
>  	{OPT_HUGE_UNLINK,       2, NULL, OPT_HUGE_UNLINK_NUM      },
> -	{OPT_IOVA_MODE,	        1, NULL, OPT_IOVA_MODE_NUM        },
> +	{OPT_IOVA_MODE,		1, NULL, OPT_IOVA_MODE_NUM        },

accidentally converted 8 spaces to a tab here, will submit a new version
to remove the change from this series (or maintainer can adjust).

thanks