From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C5864436AC; Fri, 8 Dec 2023 18:00:49 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7C82B43001; Fri, 8 Dec 2023 18:00:49 +0100 (CET) Received: from mail-pj1-f44.google.com (mail-pj1-f44.google.com [209.85.216.44]) by mails.dpdk.org (Postfix) with ESMTP id 8125A40A75 for ; Fri, 8 Dec 2023 18:00:48 +0100 (CET) Received: by mail-pj1-f44.google.com with SMTP id 98e67ed59e1d1-2888c80994bso1863010a91.0 for ; Fri, 08 Dec 2023 09:00:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1702054848; x=1702659648; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=ijqsj1mvvaQTRnGh6Ssv83suDPeGYcmkT4ogdk/1v+I=; b=EbFVDenawbR6hcqilqFrg9a2XQFahpYzxfix/dYyZ/EX7XN1ZlSNwLAcF95mERe9l7 qA7RQkGWQiiAUKnvuiR1Upgo11wxL2uit2gLz2Hm6EJmyaX+QWuxonk/z0lo68hPbvv6 h9dfdHxvHy1dA47MYZIIhQVRHHZuvOfmwX9094FrAA2H2SvOm4W49UB7cvV+Jolcd5rG SxhEMKO2DpI57w31lWmIpwDPu7ymiHyvdMF5uSpQCEMjByhO+hruhLd+QEL6fYFVdQz7 HaPUU7OAyMHifMIqAo4bNZk9UsuwbMLzAHgAq4fgr9kSwiJGEaUi3fll6YyBeyEarJl5 pBYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702054848; x=1702659648; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ijqsj1mvvaQTRnGh6Ssv83suDPeGYcmkT4ogdk/1v+I=; b=jY4mI4vuLDyAhXdQOovNqlsr+ATvlqan2OW29lBklrqqaMPdjRSJKJ9WvdMwhjW84t 4S98LoEmwOwjhJY9uw2MGamFhOAL1hRv6m50Q2p4lJO88uxI1OIsBzA1Wq/hJ/1kvoWH aEMQ3n7I743TFhhIxrU9yR3iJXUwpbYpY0qOrFzbMMIjKKVwb+/7rVq5G30wmJaxbHj8 jWABWEcCz8vuMFEf1QNx6vpv+QA4VQaJXygkaWb4UQsmAopFYs3gJlkIMZoPTrU0LKkk sEXjFo75hU42OIzWdyCQvuJ6D92dZaRT3bB2bLqofRln4wF7QaxDxzbO2axpQ2LBErAB +aqw== X-Gm-Message-State: AOJu0Yy2mUr7IOW8C7i2oun7y6c1kut7fH80fjbvdWvqRr2YW7V7ttTg T69YzzLOUan8yT16/nmgoEBZsg== X-Google-Smtp-Source: AGHT+IGe1k0q6bG8D5ymkEIiXMexEOMmmSm/0qgpEJNhvgKOmYkl21+wLHg2t2S+PioSmgFOpUfFAA== X-Received: by 2002:a17:90b:23d3:b0:286:9279:716a with SMTP id md19-20020a17090b23d300b002869279716amr397066pjb.28.1702054847700; Fri, 08 Dec 2023 09:00:47 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id l17-20020a17090aaa9100b0028593e9eaadsm3552283pjq.31.2023.12.08.09.00.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Dec 2023 09:00:47 -0800 (PST) Date: Fri, 8 Dec 2023 09:00:44 -0800 From: Stephen Hemminger To: David Marchand Cc: dev@dpdk.org, thomas@monjalon.net, ferruh.yigit@amd.com, bruce.richardson@intel.com, mb@smartsharesystems.com, stable@dpdk.org, Akhil Goyal , Fan Zhang , Andrew Rybchenko , Amit Prakash Shukla , Jerin Jacob , Naga Harish K S V Subject: Re: [RFC v2 03/14] lib: use dedicated logtypes Message-ID: <20231208090044.376d3820@hermes.local> In-Reply-To: <20231208145950.2184940-4-david.marchand@redhat.com> References: <20231117131824.1977792-1-david.marchand@redhat.com> <20231208145950.2184940-1-david.marchand@redhat.com> <20231208145950.2184940-4-david.marchand@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, 8 Dec 2023 15:59:37 +0100 David Marchand wrote: > No printf! > When a dedicated log helper exists, use it. > And no usurpation please: a library should log under its logtype > (see the eventdev rx adapter update for example). > > Note: the RTE_ETH_VALID_PORTID_OR_GOTO_ERR_RET macro is renamed for > consistency with the rest of eventdev (private) macros. > > Cc: stable@dpdk.org > > Signed-off-by: David Marchand Reviewed-by: Stephen Hemminger