From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4318C436AC; Fri, 8 Dec 2023 18:16:46 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 30E9843001; Fri, 8 Dec 2023 18:16:46 +0100 (CET) Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) by mails.dpdk.org (Postfix) with ESMTP id ED75742FF3 for ; Fri, 8 Dec 2023 18:16:44 +0100 (CET) Received: by mail-pl1-f181.google.com with SMTP id d9443c01a7336-1d04d286bc0so17864725ad.3 for ; Fri, 08 Dec 2023 09:16:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1702055804; x=1702660604; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=kNpFJCgUJpm4eH+gKIpJflzRxSlq78WdxKYIEWqW/xE=; b=J+fdtNImNH/0j16QtywW8Tn7jZgd2De9gLN9G1ybvAE7y834bg9mt9YnUHOl3TYpeW dKL/JyGPWvN6hPH03t1WQpaD5FpsUX9g4gsIBSVkbGMG9Zc3t+DqpYDcLuJfbl7otLbp VioetWjIGAKFMdSNMrl+rIOk9jt7UWl/w4kTc+E2tmb3uggmNWSRiqvs6IzejfSGfP2u Kdn7JOKJoAWHkGemthGN4bV7IABmZYC4V747p5sr54fG2PPI2z4SJ/cjYlNB4cjQEeWz iAi2ZiG5B8HVQEwLgxIEmxl98YoDCgrHPcdsReZlKlCgHSBLD651WPiNaFzqKvYpG3zS XwSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702055804; x=1702660604; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=kNpFJCgUJpm4eH+gKIpJflzRxSlq78WdxKYIEWqW/xE=; b=VHSus5ehZhIXyQqGShyLFYyhdzENnzUDtfl2pWCWJ9xN1U/MO7xV3MWq+JS0hn0D2t PfQInKbIkWleHbKQIZFlnl3e1C3PUtSL5JePfPP5o2PHFkeQy6MXMEHNHmEX4n2TzASm 1adLeL9swPPMdcbj/WvX04kTl/+ezwdeD8O4rZ3bPsysz3FlVj01O/ZKZPzd7vwHLA/o euiqAvrgccY9wqT+fsi16RS059n4iKWAKWfFTBTLBeDlAHwkhqhAEOjrJ8jisJItehlY 7PN0Sv1R9P95nQF3SWE9W155zsg8I7q0nKtNggA0n8HrvlTSp2zQnX/dT4Ybi6M1RPyO aC8A== X-Gm-Message-State: AOJu0YyL5wkx5PbwKILnbf84z2dSPxYcsascChgEcFjWR1yGP8mL4o27 oknCh+TimhN8jrnN5Mn7GvTzwA== X-Google-Smtp-Source: AGHT+IEJoDIb3t7lHV7lNFc8aym3xrFm5FKo4BEb6F+vzaBDbzgMY1EEihRqg2MONq9nZJKc/kVOoQ== X-Received: by 2002:a17:902:ea06:b0:1d0:9b2d:566b with SMTP id s6-20020a170902ea0600b001d09b2d566bmr381513plg.6.1702055804191; Fri, 08 Dec 2023 09:16:44 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id y18-20020a170902b49200b001cfc2e0a82fsm1936731plr.26.2023.12.08.09.16.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Dec 2023 09:16:44 -0800 (PST) Date: Fri, 8 Dec 2023 09:16:41 -0800 From: Stephen Hemminger To: David Marchand Cc: dev@dpdk.org, thomas@monjalon.net, ferruh.yigit@amd.com, bruce.richardson@intel.com, mb@smartsharesystems.com, Konstantin Ananyev , Anatoly Burakov , Harman Kalra , Jerin Jacob , Sunil Kumar Kori , Harry van Haaren , Stanislaw Kardach , Dmitry Kozlyuk , Narcisa Ana Maria Vasile , Dmitry Malloy , Pallavi Kadam , Byron Marohn , Yipeng Wang , Vladimir Medvedkin , Sameh Gobriel , Reshma Pattan , Andrew Rybchenko , Cristian Dumitrescu , David Hunt , Sivaprasad Tummala , Honnappa Nagarahalli , Volodymyr Fialko , Maxime Coquelin , Chenbo Xia Subject: Re: [RFC v2 12/14] lib: convert to per line logging Message-ID: <20231208091641.1f4a9f48@hermes.local> In-Reply-To: <20231208145950.2184940-13-david.marchand@redhat.com> References: <20231117131824.1977792-1-david.marchand@redhat.com> <20231208145950.2184940-1-david.marchand@redhat.com> <20231208145950.2184940-13-david.marchand@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, 8 Dec 2023 15:59:46 +0100 David Marchand wrote: > Convert many libraries that call RTE_LOG(... "\n", ...) to RTE_LOG_LINE. > > Note: > - for acl and sched libraries that still has some debug multilines > messages, a direct call to RTE_LOG is used: this will make it easier to > notice such special cases, > > Signed-off-by: David Marchand > --- > lib/acl/acl_bld.c | 28 +-- > lib/acl/acl_gen.c | 8 +- > lib/acl/rte_acl.c | 8 +- > lib/acl/tb_mem.c | 4 +- > lib/eal/common/eal_common_bus.c | 22 +- > lib/eal/common/eal_common_class.c | 4 +- > lib/eal/common/eal_common_config.c | 2 +- > lib/eal/common/eal_common_debug.c | 6 +- > lib/eal/common/eal_common_dev.c | 80 +++---- > lib/eal/common/eal_common_devargs.c | 18 +- > lib/eal/common/eal_common_dynmem.c | 34 +-- > lib/eal/common/eal_common_fbarray.c | 12 +- > lib/eal/common/eal_common_interrupts.c | 38 ++-- > lib/eal/common/eal_common_lcore.c | 26 +-- > lib/eal/common/eal_common_memalloc.c | 12 +- > lib/eal/common/eal_common_memory.c | 66 +++--- > lib/eal/common/eal_common_memzone.c | 24 +-- > lib/eal/common/eal_common_options.c | 236 ++++++++++---------- > lib/eal/common/eal_common_proc.c | 112 +++++----- > lib/eal/common/eal_common_tailqs.c | 12 +- > lib/eal/common/eal_common_thread.c | 12 +- > lib/eal/common/eal_common_timer.c | 6 +- > lib/eal/common/eal_common_trace_utils.c | 2 +- > lib/eal/common/eal_trace.h | 4 +- > lib/eal/common/hotplug_mp.c | 54 ++--- > lib/eal/common/malloc_elem.c | 6 +- > lib/eal/common/malloc_heap.c | 40 ++-- > lib/eal/common/malloc_mp.c | 72 +++---- > lib/eal/common/rte_keepalive.c | 2 +- > lib/eal/common/rte_malloc.c | 10 +- > lib/eal/common/rte_service.c | 8 +- > lib/eal/freebsd/eal.c | 74 +++---- > lib/eal/freebsd/eal_alarm.c | 2 +- > lib/eal/freebsd/eal_dev.c | 8 +- > lib/eal/freebsd/eal_hugepage_info.c | 22 +- > lib/eal/freebsd/eal_interrupts.c | 60 +++--- > lib/eal/freebsd/eal_lcore.c | 2 +- > lib/eal/freebsd/eal_memalloc.c | 10 +- > lib/eal/freebsd/eal_memory.c | 34 +-- > lib/eal/freebsd/eal_thread.c | 2 +- > lib/eal/freebsd/eal_timer.c | 10 +- > lib/eal/linux/eal.c | 122 +++++------ > lib/eal/linux/eal_alarm.c | 2 +- > lib/eal/linux/eal_dev.c | 40 ++-- > lib/eal/linux/eal_hugepage_info.c | 38 ++-- > lib/eal/linux/eal_interrupts.c | 116 +++++----- > lib/eal/linux/eal_lcore.c | 4 +- > lib/eal/linux/eal_memalloc.c | 120 +++++------ > lib/eal/linux/eal_memory.c | 208 +++++++++--------- > lib/eal/linux/eal_thread.c | 4 +- > lib/eal/linux/eal_timer.c | 10 +- > lib/eal/linux/eal_vfio.c | 270 +++++++++++------------ > lib/eal/linux/eal_vfio_mp_sync.c | 4 +- > lib/eal/riscv/rte_cycles.c | 4 +- > lib/eal/unix/eal_filesystem.c | 14 +- > lib/eal/unix/eal_firmware.c | 2 +- > lib/eal/unix/eal_unix_memory.c | 8 +- > lib/eal/unix/rte_thread.c | 34 +-- > lib/eal/windows/eal.c | 36 ++-- > lib/eal/windows/eal_alarm.c | 12 +- > lib/eal/windows/eal_debug.c | 8 +- > lib/eal/windows/eal_dev.c | 8 +- > lib/eal/windows/eal_hugepages.c | 10 +- > lib/eal/windows/eal_interrupts.c | 10 +- > lib/eal/windows/eal_lcore.c | 6 +- > lib/eal/windows/eal_memalloc.c | 50 ++--- > lib/eal/windows/eal_memory.c | 20 +- > lib/eal/windows/eal_windows.h | 4 +- > lib/eal/windows/include/rte_windows.h | 4 +- > lib/eal/windows/rte_thread.c | 28 +-- > lib/efd/rte_efd.c | 58 ++--- > lib/fib/rte_fib.c | 14 +- > lib/fib/rte_fib6.c | 14 +- > lib/hash/rte_cuckoo_hash.c | 52 ++--- > lib/hash/rte_fbk_hash.c | 4 +- > lib/hash/rte_hash_crc.c | 12 +- > lib/hash/rte_thash.c | 20 +- > lib/hash/rte_thash_gfni.c | 8 +- > lib/ip_frag/rte_ip_frag_common.c | 8 +- > lib/latencystats/rte_latencystats.c | 41 ++-- > lib/log/log.c | 6 +- > lib/lpm/rte_lpm.c | 12 +- > lib/lpm/rte_lpm6.c | 10 +- > lib/mbuf/rte_mbuf.c | 14 +- > lib/mbuf/rte_mbuf_dyn.c | 14 +- > lib/mbuf/rte_mbuf_pool_ops.c | 4 +- > lib/mempool/rte_mempool.c | 24 +-- > lib/mempool/rte_mempool.h | 2 +- > lib/mempool/rte_mempool_ops.c | 10 +- > lib/pipeline/rte_pipeline.c | 228 ++++++++++---------- > lib/port/rte_port_ethdev.c | 18 +- > lib/port/rte_port_eventdev.c | 18 +- > lib/port/rte_port_fd.c | 24 +-- > lib/port/rte_port_frag.c | 14 +- > lib/port/rte_port_ras.c | 12 +- > lib/port/rte_port_ring.c | 18 +- > lib/port/rte_port_sched.c | 12 +- > lib/port/rte_port_source_sink.c | 48 ++--- > lib/port/rte_port_sym_crypto.c | 18 +- > lib/power/guest_channel.c | 38 ++-- > lib/power/power_acpi_cpufreq.c | 106 ++++----- > lib/power/power_amd_pstate_cpufreq.c | 120 +++++------ > lib/power/power_common.c | 10 +- > lib/power/power_cppc_cpufreq.c | 118 +++++----- > lib/power/power_intel_uncore.c | 68 +++--- > lib/power/power_kvm_vm.c | 22 +- > lib/power/power_pstate_cpufreq.c | 144 ++++++------- > lib/power/rte_power.c | 22 +- > lib/power/rte_power_pmd_mgmt.c | 34 +-- > lib/power/rte_power_uncore.c | 14 +- > lib/rcu/rte_rcu_qsbr.c | 2 +- > lib/reorder/rte_reorder.c | 32 +-- > lib/rib/rte_rib.c | 10 +- > lib/rib/rte_rib6.c | 10 +- > lib/ring/rte_ring.c | 24 +-- > lib/sched/rte_pie.c | 18 +- > lib/sched/rte_sched.c | 274 ++++++++++++------------ > lib/table/rte_table_acl.c | 72 +++---- > lib/table/rte_table_array.c | 16 +- > lib/table/rte_table_hash_cuckoo.c | 22 +- > lib/table/rte_table_hash_ext.c | 22 +- > lib/table/rte_table_hash_key16.c | 38 ++-- > lib/table/rte_table_hash_key32.c | 38 ++-- > lib/table/rte_table_hash_key8.c | 38 ++-- > lib/table/rte_table_hash_lru.c | 22 +- > lib/table/rte_table_lpm.c | 42 ++-- > lib/table/rte_table_lpm_ipv6.c | 44 ++-- > lib/table/rte_table_stub.c | 4 +- > lib/vhost/fd_man.c | 8 +- > 129 files changed, 2278 insertions(+), 2279 deletions(-) Coccinelle script for later fixups? Acked-by: Stephen Hemminger