From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A841B436AC; Fri, 8 Dec 2023 18:18:32 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7C9C143001; Fri, 8 Dec 2023 18:18:32 +0100 (CET) Received: from mail-pf1-f172.google.com (mail-pf1-f172.google.com [209.85.210.172]) by mails.dpdk.org (Postfix) with ESMTP id 4A72042FF3 for ; Fri, 8 Dec 2023 18:18:31 +0100 (CET) Received: by mail-pf1-f172.google.com with SMTP id d2e1a72fcca58-6ceb27ec331so1702955b3a.1 for ; Fri, 08 Dec 2023 09:18:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1702055910; x=1702660710; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=ODkRZlt927kyWXTVZZOd367Rki4/ztmk20eAmKYkZOc=; b=mw2znaCdCUay661uG5zownZaIPBaswdtHawYkAsj8u+a7UjQ6tbePKFy6wr6kOIVZm 7Ebq+f6UxFN5TycuXlwF3ovJR10Q6+Mdzmo+tObTD7av8sSYyJJjWCx9WTh2DolY0IsC t/3zJXZXHZT/EB3sG6E3CNkifMUACnJCc4xlAVdv5u4rdRGazxdqH8gJiz7F6sfqnc/0 iwVD+OBCn9qBDS47+oAwuON47KhqF94xnNvtogDteObl+1PXJMqY6M2OwAnCRlvOOisi yUNUNXa2s5vfj5jEjel4HF+gNTD+/hUqZDEwSh/lpZzgoxjQsRszsqHsbqBi5QNK7y9O u7cQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702055910; x=1702660710; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ODkRZlt927kyWXTVZZOd367Rki4/ztmk20eAmKYkZOc=; b=IKiT4q0vhKddcIBfBcqrU4AUj8xG7jkET2GoheTYg1dplm9kr8l6nUK3gMO5LcplFJ F4539klC9okqVpG9rVP5zzbZytd6LTWmj5eEKg/GwGLTeXlo7fMasiL0HblaaiJX276V RtpxA2IT7EhPLYy5nRSVvCC824WqPYmmd8hx7aJtKc+p960p1jgSpEl+E4Y7NSVP2RMB VjHwapWdpkbrJ4eWouZkh1lNQ39kOIyZWihn6quvDW9AEOXqZ3+oxQBfp2jGwPgP7A4w 51jYFgNzBz7KpJaJjvlM4do7NfYON3wwX3RdRRWBNM2iwzCNsJ42uhWZIogNHKA0WspH usNA== X-Gm-Message-State: AOJu0YxnEq0pspAlOyRg4eEXpLL6B+ExWyNkaTgIP47dwgcBaJUcj+Lu 9p+4VW1JzVljlId94gRyFZmXcg== X-Google-Smtp-Source: AGHT+IH990YMMvjd87EezXiFTyglcBd7dnJ/hOglPGyWdah1oLivZr7fkYfUE6Qe2Slr9m2cl2mBlw== X-Received: by 2002:a05:6a00:2d07:b0:6ce:b7cb:5770 with SMTP id fa7-20020a056a002d0700b006ceb7cb5770mr348519pfb.49.1702055910376; Fri, 08 Dec 2023 09:18:30 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id y20-20020a056a00191400b006cbadbf20ddsm1807191pfi.187.2023.12.08.09.18.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Dec 2023 09:18:30 -0800 (PST) Date: Fri, 8 Dec 2023 09:18:28 -0800 From: Stephen Hemminger To: David Marchand Cc: dev@dpdk.org, thomas@monjalon.net, ferruh.yigit@amd.com, bruce.richardson@intel.com, mb@smartsharesystems.com, Konstantin Ananyev , Ruifeng Wang , Andrew Rybchenko , Ori Kam , Yipeng Wang , Sameh Gobriel , Reshma Pattan , Anatoly Burakov , David Hunt , Sivaprasad Tummala , Ciara Power , Maxime Coquelin , Chenbo Xia Subject: Re: [RFC v2 13/14] lib: replace logging helpers Message-ID: <20231208091828.3ed4c465@hermes.local> In-Reply-To: <20231208145950.2184940-14-david.marchand@redhat.com> References: <20231117131824.1977792-1-david.marchand@redhat.com> <20231208145950.2184940-1-david.marchand@redhat.com> <20231208145950.2184940-14-david.marchand@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, 8 Dec 2023 15:59:47 +0100 David Marchand wrote: > diff --git a/lib/bpf/bpf_impl.h b/lib/bpf/bpf_impl.h > index b483569071..30d83d2b40 100644 > --- a/lib/bpf/bpf_impl.h > +++ b/lib/bpf/bpf_impl.h > @@ -27,9 +27,10 @@ int __rte_bpf_jit_x86(struct rte_bpf *bpf); > int __rte_bpf_jit_arm64(struct rte_bpf *bpf); > > extern int rte_bpf_logtype; > +#define RTE_LOGTYPE_BPF rte_bpf_logtype > > -#define RTE_BPF_LOG(lvl, fmt, args...) \ > - rte_log(RTE_LOG_## lvl, rte_bpf_logtype, fmt, ##args) > +#define BPF_LOG(lvl, fmt, args...) \ > + RTE_LOG(lvl, BPF, fmt "\n", ##args) Not sure about this. There were some cases where bpf_XXX function names clashed with those in libpcap. That is probably why the RTE_BPF_LOG was chosen.