From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id DF4FD436AE;
	Fri,  8 Dec 2023 22:27:52 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 96748432E2;
	Fri,  8 Dec 2023 22:27:51 +0100 (CET)
Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182])
 by mails.dpdk.org (Postfix) with ESMTP id 030D740144
 for <dev@dpdk.org>; Fri,  8 Dec 2023 22:27:49 +0100 (CET)
Received: by linux.microsoft.com (Postfix, from userid 1086)
 id 3CDCA20B74C0; Fri,  8 Dec 2023 13:27:49 -0800 (PST)
DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 3CDCA20B74C0
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;
 s=default; t=1702070869;
 bh=NmkKGu0+NQ/IZkqupZyQoWoxrVa+EDP3noclJ73utxI=;
 h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
 b=kbCTyDkB0y/7yKvNtEuA7xg8jFxS/5JLfxMEgh0OfNqL3txRAcMiDhPnCSF+/VXdy
 YxSSkbSCsnbCrbGZT7or66BaRn6117Wen+alPKIPQI6mNKj2Tb/ZZXB7tif6IxG3vz
 gNOooMTD9vcC54ZP2Rk+EmlxHfuiQ9wpggS8qKDM=
Date: Fri, 8 Dec 2023 13:27:49 -0800
From: Tyler Retzlaff <roretzla@linux.microsoft.com>
To: David Marchand <david.marchand@redhat.com>
Cc: dev@dpdk.org, thomas@monjalon.net, ferruh.yigit@amd.com,
 bruce.richardson@intel.com, stephen@networkplumber.org,
 mb@smartsharesystems.com,
 Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
Subject: Re: [RFC v2 09/14] rcu: introduce a logging helper
Message-ID: <20231208212749.GH5699@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
References: <20231117131824.1977792-1-david.marchand@redhat.com>
 <20231208145950.2184940-1-david.marchand@redhat.com>
 <20231208145950.2184940-10-david.marchand@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20231208145950.2184940-10-david.marchand@redhat.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

On Fri, Dec 08, 2023 at 03:59:43PM +0100, David Marchand wrote:
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---

Reviewed-by: Tyler Retzlaff <roretzla@linux.microsoft.com>

>  lib/rcu/rte_rcu_qsbr.c | 62 ++++++++++++++++--------------------------
>  lib/rcu/rte_rcu_qsbr.h |  1 +
>  2 files changed, 24 insertions(+), 39 deletions(-)
> 
> diff --git a/lib/rcu/rte_rcu_qsbr.c b/lib/rcu/rte_rcu_qsbr.c
> index 41a44be4b9..5b6530788a 100644
> --- a/lib/rcu/rte_rcu_qsbr.c
> +++ b/lib/rcu/rte_rcu_qsbr.c
> @@ -19,6 +19,9 @@
>  #include "rte_rcu_qsbr.h"
>  #include "rcu_qsbr_pvt.h"
>  
> +#define RCU_LOG(level, fmt, args...) \
> +	RTE_LOG(level, RCU, "%s(): " fmt "\n", __func__, ## args)
> +

Since you are looking in the area for all the versions of gcc/clang we
use able to support the non-standard __VA_ARGS__ that discard the comma?

I know that some versions of gcc do and if it does I would like to move
to using __VA_ARGS__ instead of args so we can use the same thing with
msvc.