From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EBDE4436C9; Mon, 11 Dec 2023 21:15:51 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D1849402AF; Mon, 11 Dec 2023 21:15:51 +0100 (CET) Received: from mail-pf1-f176.google.com (mail-pf1-f176.google.com [209.85.210.176]) by mails.dpdk.org (Postfix) with ESMTP id 6F2EB4021E for ; Mon, 11 Dec 2023 21:15:50 +0100 (CET) Received: by mail-pf1-f176.google.com with SMTP id d2e1a72fcca58-6ceb93fb381so3394470b3a.0 for ; Mon, 11 Dec 2023 12:15:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1702325749; x=1702930549; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=naKkMJOO8s/ARQHwIYwycnBbXD9QDtEX0AwLS4b9U6M=; b=gI6/Vu+SnhSJ2a50ifRVLjy020+i3Cr/nmSMTKmuzpQbxTZBw5nLwdZSlGC0/I7VGE a6tKX7Gi6cpbw66rAqCjDzI79sKzVJcN4u5PYZNWWr2XrgtDMjjKUyxEfp8CV288PP/K +QG4nTSUNMKL5eKyJF3P4fj0SxlozlsRCG67GFCkjcf2Mlda2OcwnOreR5w9veqQlWnr 6o9DWJsNTC3WYXt7hm1cf4Zso2xa6G7rRZAUgKmZIXAoc+gXUg1Ywa3l2ujqLrigRhFt Me2apDFm5m6oiCyuAPxauzSybGrdGgkqxmaS54xioeVN/Z6nQhrTbwhgNSCjXV88MkwP OZbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702325749; x=1702930549; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=naKkMJOO8s/ARQHwIYwycnBbXD9QDtEX0AwLS4b9U6M=; b=LfyGXZjEEXky3ZS1yb2m2XMOI8zHrOZlCJsx1FktT295yznJGMOVtOW8ojNWqc24Ze XNxIKyM5hdwRWtU0UQDUQ7BQkT3IXQT4gsItZsgPbxv1PDDwvzCj8AnAbUBtrPr8r/rm auaWmcaWwCrkyRWV/iVaR3VUPvMgEHgn608cci4sn3JgwLzFNcupVvvbBxmRGgAbbUCb TWC4ljTwOBAI0zs9ufKiSjAloW+Fg0McAZTi4jhgIw8PJ/I0TttrZrkGIhzYMxFbZyYG i8iguUJ8IpkwfZ9tUL+VKoApN5PNHOremVvFKNiWdnudBQ1JWvNX2zOe0k7CRtQFGjWA Ez0w== X-Gm-Message-State: AOJu0YyRohluN42rbvuORzqeECrqYvSdpqisrgllqeKfDbfuyAfknGHq 4fF1Gza8eYSdr2i3YToPRNnasQ== X-Google-Smtp-Source: AGHT+IHrWrXquZ3PtE2oA07DCTxO3S+2jFBGTx9s9bGCARwREB3x5Dpo5F7pgtGsOck3vMdKXQ6y2Q== X-Received: by 2002:a05:6a00:1412:b0:6ce:2731:47b9 with SMTP id l18-20020a056a00141200b006ce273147b9mr6284261pfu.25.1702325749457; Mon, 11 Dec 2023 12:15:49 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id k13-20020aa792cd000000b006ce273562fasm6687286pfa.40.2023.12.11.12.15.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Dec 2023 12:15:49 -0800 (PST) Date: Mon, 11 Dec 2023 12:15:47 -0800 From: Stephen Hemminger To: Tyler Retzlaff Cc: dev@dpdk.org Subject: Re: [PATCH 0/3] replace use of EAL logtype Message-ID: <20231211121547.0bbe500b@hermes.local> In-Reply-To: <20231211191931.GB16826@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> References: <20231211172437.61958-1-stephen@networkplumber.org> <20231211191931.GB16826@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, 11 Dec 2023 11:19:31 -0800 Tyler Retzlaff wrote: > On Mon, Dec 11, 2023 at 09:23:22AM -0800, Stephen Hemminger wrote: > > There are some places EAL logtype is being used in testpmd > > and examples where it should not be. Lets reserve EAL > > logtype to only be used by DPDK internals. > > > > Stephen Hemminger (3): > > testpmd: replace EAL logtype with fprintf > > examples/l2fwd-keepalive: don't use EAL logtype > > examples/vm_power_manager: do not use EAL logtype > > > > app/test-pmd/testpmd.c | 33 +++++++++++--------------------- > > examples/l2fwd-keepalive/shm.c | 21 +++++++------------- > > examples/vm_power_manager/main.c | 11 ++++------- > > are the log types under ALLOW_INTERNAL_API? if not should they be? and > if they are should examples be defining ALLOW_INTERNAL_API? > > just curious. > No they never were under ALLOW_INTERNAL_API. They should have been, but a little late now to change.