From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id D783C436C9;
	Mon, 11 Dec 2023 20:19:34 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 86A08410F6;
	Mon, 11 Dec 2023 20:19:34 +0100 (CET)
Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182])
 by mails.dpdk.org (Postfix) with ESMTP id 953DE402EF
 for <dev@dpdk.org>; Mon, 11 Dec 2023 20:19:32 +0100 (CET)
Received: by linux.microsoft.com (Postfix, from userid 1086)
 id AA26320B74C0; Mon, 11 Dec 2023 11:19:31 -0800 (PST)
DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com AA26320B74C0
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;
 s=default; t=1702322371;
 bh=qiZ7XNS6FHGOWwAAApGcR1SvRQB8DpksB0L1dSg8/w4=;
 h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
 b=YTBgV94X5CPUZwPVvdv3wPCVlxxqpTXunD83i7KiLygjw7VCsVNr+wBATMCfPrcRz
 bX0hrV3dM/uV7vlMzN1ChTXOxpYx7xJI9AQAj9g6uVtATMlyIh+cUg9YuwXiDpj5iG
 anV7ZR3byv7aFnCn25A+N1mfO0qTsrcK1zPlfOxM=
Date: Mon, 11 Dec 2023 11:19:31 -0800
From: Tyler Retzlaff <roretzla@linux.microsoft.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: dev@dpdk.org
Subject: Re: [PATCH 0/3] replace use of EAL logtype
Message-ID: <20231211191931.GB16826@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
References: <20231211172437.61958-1-stephen@networkplumber.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20231211172437.61958-1-stephen@networkplumber.org>
User-Agent: Mutt/1.5.21 (2010-09-15)
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

On Mon, Dec 11, 2023 at 09:23:22AM -0800, Stephen Hemminger wrote:
> There are some places EAL logtype is being used in testpmd
> and examples where it should not be. Lets reserve EAL
> logtype to only be used by DPDK internals.
> 
> Stephen Hemminger (3):
>   testpmd: replace EAL logtype with fprintf
>   examples/l2fwd-keepalive: don't use EAL logtype
>   examples/vm_power_manager: do not use EAL logtype
> 
>  app/test-pmd/testpmd.c           | 33 +++++++++++---------------------
>  examples/l2fwd-keepalive/shm.c   | 21 +++++++-------------
>  examples/vm_power_manager/main.c | 11 ++++-------

are the log types under ALLOW_INTERNAL_API? if not should they be? and
if they are should examples be defining ALLOW_INTERNAL_API?

just curious.