From: Stephen Hemminger <stephen@networkplumber.org>
To: Artemy Kovalyov <artemyko@nvidia.com>
Cc: <dev@dpdk.org>, Thomas Monjalon <thomas@monjalon.net>,
Anatoly Burakov <anatoly.burakov@intel.com>
Subject: Re: [PATCH 1/5] app/test-pm: add multiprocess test
Date: Tue, 12 Dec 2023 09:09:12 -0800 [thread overview]
Message-ID: <20231212090912.268d3cd8@hermes.local> (raw)
In-Reply-To: <20231212042517.164353-2-artemyko@nvidia.com>
On Tue, 12 Dec 2023 06:25:12 +0200
Artemy Kovalyov <artemyko@nvidia.com> wrote:
> +rte_atomic32_t g_count;
> +
> +static int
> +done(const struct rte_mp_msg *msg __rte_unused, const void *arg __rte_unused)
> +{
> + rte_atomic32_dec(&g_count);
> + return 0;
> +}
Local variable, should be static.
Also, assert may not be the ideal way to report test failures.
The preferred way would be to use RTE_TEST_ASSERT() and RTE_TEST_ASSERT_EQUAL()
next prev parent reply other threads:[~2023-12-12 17:09 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-12 4:25 [PATCH 0/5] addressing races in concurrent process startup Artemy Kovalyov
2023-12-12 4:25 ` [PATCH 1/5] app/test-pm: add multiprocess test Artemy Kovalyov
2023-12-12 17:09 ` Stephen Hemminger [this message]
2023-12-17 3:53 ` [PATCH v2 1/5] app/test-mp: " Artemy Kovalyov
2024-03-06 20:20 ` David Marchand
2024-03-07 6:59 ` [PATCH 0/5] addressing races in concurrent process startup Artemy Kovalyov
2024-03-07 7:01 ` Artemy Kovalyov
2024-03-07 7:01 ` [PATCH v2 1/5] app/test-mp: add multiprocess test Artemy Kovalyov
2024-03-13 16:05 ` Burakov, Anatoly
2024-03-07 7:01 ` [PATCH v2 2/5] eal: fix multiprocess hotplug race Artemy Kovalyov
2024-03-13 16:05 ` Burakov, Anatoly
2024-03-07 7:01 ` [PATCH v2 3/5] ipc: fix mp channel closure to prevent message loss Artemy Kovalyov
2024-03-13 16:06 ` Burakov, Anatoly
2024-03-07 7:01 ` [PATCH v2 4/5] eal: fix first time primary autodetect Artemy Kovalyov
2024-03-13 16:06 ` Burakov, Anatoly
2024-03-07 7:01 ` [PATCH v2 5/5] eal: fix memzone fbarray cleanup Artemy Kovalyov
2024-03-13 16:17 ` Burakov, Anatoly
2023-12-12 4:25 ` [PATCH 2/5] eal: fix multiprocess hotplug race Artemy Kovalyov
2023-12-12 4:25 ` [PATCH 3/5] ipc: fix mp channel closure to prevent message loss Artemy Kovalyov
2023-12-12 4:25 ` [PATCH 4/5] eal: fix first time primary autodetect Artemy Kovalyov
2023-12-12 4:25 ` [PATCH 5/5] eal: fix memzone fbarray cleanup Artemy Kovalyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231212090912.268d3cd8@hermes.local \
--to=stephen@networkplumber.org \
--cc=anatoly.burakov@intel.com \
--cc=artemyko@nvidia.com \
--cc=dev@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).