From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C3D28436D4; Tue, 12 Dec 2023 18:09:17 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 71E1042E5D; Tue, 12 Dec 2023 18:09:17 +0100 (CET) Received: from mail-pl1-f177.google.com (mail-pl1-f177.google.com [209.85.214.177]) by mails.dpdk.org (Postfix) with ESMTP id 7A69942E4F for ; Tue, 12 Dec 2023 18:09:15 +0100 (CET) Received: by mail-pl1-f177.google.com with SMTP id d9443c01a7336-1d069b1d127so34737355ad.0 for ; Tue, 12 Dec 2023 09:09:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1702400954; x=1703005754; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=iv5SYUwphJCYVcVaH4AwlEhJGkHDrLg9ltLwGv1g+SU=; b=xF1CYuSR6iclOCfzH3obARxVWxYIE4qk3LLa4cyb1ySuE6VxYXoJNYmP6LC3OgvP9O gwLj5dO1zg9E1LsaomIYZkLqQC4PL99Pp+H0rQ+0MAznobOo0klD23IUztl/e9EaV6rz bpgx6jn9w9VpRVSc1pEIjuojMX3n4Hlr8xV1MX0thqxLc4mYyFgDGUVfzWUwi5OaqWxU 9yjXzPs906UJNgG45FVVkwI7V/JqgkuhLFcKzm80pB1rEXkgKDUxZx03k1DS5qzhunf2 q3DzXsw3jR2IVX9S+36WcN240vbrI/HHD5Rhs0lcWSoiyogwUKvQFl5jabsho6D1kKUu Qjug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702400954; x=1703005754; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=iv5SYUwphJCYVcVaH4AwlEhJGkHDrLg9ltLwGv1g+SU=; b=AJHLEFP0GxJcrdX7foqxSsi63v4CjBzA3vdYzfJD0O+e8WwUy8fezqD2Dh1iH6W6N1 llSkjhdQV/lOvr9oPkeqUCPm6JHGe/OITR0aNEvLh5aSm6qWHCjD0eJbO6P99By5Dib+ loFd4uIaqA60JTAY8NDkdezBpq+lA+ZasWMR3dfoEb23uU2CaECeBRhEYCisC1/m/aBv pXlCQSFxA4YjlF5gvSmX39kKyO5Yv/CbpMhyj1CB4L+yQ4G9xYIfoXcCd93mHK/QcLof vJTwyDYe/XcpFPJ4aq21sUv5zJ4VaWNt//nwBwID8hpeS66RKrqy91G67d+FrHylVg9f gTeg== X-Gm-Message-State: AOJu0YyiZSnoq83gBLZu5r5cwDUz0ZtYATXYmMf05kYi7ZmYwbqslb3z TOjY9dpDRw/eXd4ehcqASpD9XQ== X-Google-Smtp-Source: AGHT+IEyBCoeP/Pq6hRCV3iR2yPVIPm+n873GJhnDmrDyBL9oi7N5AJ0yFtTRAK0UdtpPeAY5Ro+OQ== X-Received: by 2002:a17:903:40c7:b0:1d3:46f4:7f2f with SMTP id t7-20020a17090340c700b001d346f47f2fmr432099pld.2.1702400954437; Tue, 12 Dec 2023 09:09:14 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id g12-20020a170902fe0c00b001d0c134dc2dsm185708plj.77.2023.12.12.09.09.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Dec 2023 09:09:14 -0800 (PST) Date: Tue, 12 Dec 2023 09:09:12 -0800 From: Stephen Hemminger To: Artemy Kovalyov Cc: , Thomas Monjalon , Anatoly Burakov Subject: Re: [PATCH 1/5] app/test-pm: add multiprocess test Message-ID: <20231212090912.268d3cd8@hermes.local> In-Reply-To: <20231212042517.164353-2-artemyko@nvidia.com> References: <20231212042517.164353-1-artemyko@nvidia.com> <20231212042517.164353-2-artemyko@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, 12 Dec 2023 06:25:12 +0200 Artemy Kovalyov wrote: > +rte_atomic32_t g_count; > + > +static int > +done(const struct rte_mp_msg *msg __rte_unused, const void *arg __rte_unused) > +{ > + rte_atomic32_dec(&g_count); > + return 0; > +} Local variable, should be static. Also, assert may not be the ideal way to report test failures. The preferred way would be to use RTE_TEST_ASSERT() and RTE_TEST_ASSERT_EQUAL()