* [PATCH] crytodev: make logtype internal
@ 2023-12-12 16:41 Stephen Hemminger
2023-12-21 9:28 ` David Marchand
0 siblings, 1 reply; 2+ messages in thread
From: Stephen Hemminger @ 2023-12-12 16:41 UTC (permalink / raw)
To: dev; +Cc: Stephen Hemminger, Akhil Goyal, Fan Zhang
The logtype does not need to be exported as API.
Fixes: be618b81545e ("cryptodev: convert to dynamic logtype")
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
lib/cryptodev/version.map | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/cryptodev/version.map b/lib/cryptodev/version.map
index 54360a5da538..bde369eb27a6 100644
--- a/lib/cryptodev/version.map
+++ b/lib/cryptodev/version.map
@@ -44,7 +44,6 @@ DPDK_24 {
rte_cryptodev_get_sec_ctx;
rte_cryptodev_info_get;
rte_cryptodev_is_valid_dev;
- rte_cryptodev_logtype;
rte_cryptodev_name_get;
rte_cryptodev_queue_pair_count;
rte_cryptodev_queue_pair_setup;
@@ -91,6 +90,7 @@ INTERNAL {
cryptodev_fp_ops_reset;
cryptodev_fp_ops_set;
+ rte_cryptodev_logtype;
rte_cryptodev_allocate_driver;
rte_cryptodev_pmd_allocate;
rte_cryptodev_pmd_callback_process;
--
2.42.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] crytodev: make logtype internal
2023-12-12 16:41 [PATCH] crytodev: make logtype internal Stephen Hemminger
@ 2023-12-21 9:28 ` David Marchand
0 siblings, 0 replies; 2+ messages in thread
From: David Marchand @ 2023-12-21 9:28 UTC (permalink / raw)
To: Stephen Hemminger, Akhil Goyal; +Cc: dev, Fan Zhang, Thomas Monjalon
On Tue, Dec 12, 2023 at 5:41 PM Stephen Hemminger
<stephen@networkplumber.org> wrote:
>
> The logtype does not need to be exported as API.
The CDEV_* macros are exported in the public header.
If some external users use them and we take this patch, the user
binary will point at a symbol for which we have no safety barrier (wrt
symbol removal / changes).
Moving those macros to cryptodev_pmd.h is a prerequisite.
--
David Marchand
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-12-21 9:28 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-12-12 16:41 [PATCH] crytodev: make logtype internal Stephen Hemminger
2023-12-21 9:28 ` David Marchand
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).