From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AADF9436D5; Tue, 12 Dec 2023 20:11:19 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9944442E64; Tue, 12 Dec 2023 20:11:19 +0100 (CET) Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mails.dpdk.org (Postfix) with ESMTP id 60A2B42E63 for ; Tue, 12 Dec 2023 20:11:18 +0100 (CET) Received: by linux.microsoft.com (Postfix, from userid 1086) id A9EA720B74C0; Tue, 12 Dec 2023 11:11:17 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com A9EA720B74C0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1702408277; bh=17wExXFaID0xcAJsSeqgO+jYk3+Tj1t03RUweyYjEYI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=c3AZUn7bgADOEFv4VKhbeuae1Sus62sSJleW928KwQBUhQpjAHa51Sfqp+ZtqPu5J pjKO0S8Wa5xgNNZyOhh33wGRawgaYjfX9C8TeXd7J3HIMXCMVZUeCAr5ZChq8jnWlD K30Yk22YnDyTJmbWO6cXpsBbyGV5FIbDN2zTLAiE= Date: Tue, 12 Dec 2023 11:11:17 -0800 From: Tyler Retzlaff To: David Marchand Cc: dev@dpdk.org, thomas@monjalon.net, ferruh.yigit@amd.com, bruce.richardson@intel.com, stephen@networkplumber.org, mb@smartsharesystems.com, Honnappa Nagarahalli Subject: Re: [RFC v2 09/14] rcu: introduce a logging helper Message-ID: <20231212191117.GA1160@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> References: <20231117131824.1977792-1-david.marchand@redhat.com> <20231208145950.2184940-1-david.marchand@redhat.com> <20231208145950.2184940-10-david.marchand@redhat.com> <20231208212749.GH5699@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Dec 12, 2023 at 04:00:35PM +0100, David Marchand wrote: > On Fri, Dec 8, 2023 at 10:27 PM Tyler Retzlaff > wrote: > > > > On Fri, Dec 08, 2023 at 03:59:43PM +0100, David Marchand wrote: > > > Signed-off-by: David Marchand > > > --- > > > > Reviewed-by: Tyler Retzlaff > > > > > lib/rcu/rte_rcu_qsbr.c | 62 ++++++++++++++++-------------------------- > > > lib/rcu/rte_rcu_qsbr.h | 1 + > > > 2 files changed, 24 insertions(+), 39 deletions(-) > > > > > > diff --git a/lib/rcu/rte_rcu_qsbr.c b/lib/rcu/rte_rcu_qsbr.c > > > index 41a44be4b9..5b6530788a 100644 > > > --- a/lib/rcu/rte_rcu_qsbr.c > > > +++ b/lib/rcu/rte_rcu_qsbr.c > > > @@ -19,6 +19,9 @@ > > > #include "rte_rcu_qsbr.h" > > > #include "rcu_qsbr_pvt.h" > > > > > > +#define RCU_LOG(level, fmt, args...) \ > > > + RTE_LOG(level, RCU, "%s(): " fmt "\n", __func__, ## args) > > > + > > > > Since you are looking in the area for all the versions of gcc/clang we > > use able to support the non-standard __VA_ARGS__ that discard the comma? > > I suspect there is some typo (maybe s/for all/are all/ ?). > Can you please clarify? > > > > > > I know that some versions of gcc do and if it does I would like to move > > to using __VA_ARGS__ instead of args so we can use the same thing with > > msvc. > > If the request is to translate the ## args stuff to __VA_ARGS__, I > would prefer this is done in a separate series and not to mix with > this already huge series. Yes. I was asking if translation was possible from ## args to __VA_ARGS__. I was also asking if you could help do the translation. I didn't mean to suggest it should be done in this series. Ty > > > -- > David Marchand