From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0CBCB436E3; Wed, 13 Dec 2023 16:09:13 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3DCD6402C3; Wed, 13 Dec 2023 16:09:12 +0100 (CET) Received: from mail-pj1-f41.google.com (mail-pj1-f41.google.com [209.85.216.41]) by mails.dpdk.org (Postfix) with ESMTP id 607DE4021D for ; Wed, 13 Dec 2023 16:09:10 +0100 (CET) Received: by mail-pj1-f41.google.com with SMTP id 98e67ed59e1d1-28aeb049942so476476a91.2 for ; Wed, 13 Dec 2023 07:09:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1702480149; x=1703084949; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=ojdw9+B6cHbrSlPRWLuLtKNAb6ChwrmBOsn8ZnQG/gU=; b=rrXFncXqKgBZaUPr2Y/F+GryOwUXyZWxp0SY7yhlLb3mX9vBdeiCqCKqcfiTQTrPm+ 4NYMccrhaJJtGV4gxSNOjJnkCmkXMRjbuv3NSifJqkuh7ZqRzQQxZm+DpfMTC20O8ves fMb8+afLT7e50TxnL3fHl0imEsqOaSIOxjbBaAM2vDYIB38r7lFk3YwW1SPF7WJ6PpeL c1pjjG4inpd3REAYsLNntyT+K82VdlRJMWRwszb7C6/vOL3PJ7Ukw0e/rJZJZVy9K9+7 1cwftlfqfUf+yM+D9fMr62wXN9TiVIcRg1umTtCh+vS0mGzUVhRjH4HXrupVlfCdzuMX 6HZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702480149; x=1703084949; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ojdw9+B6cHbrSlPRWLuLtKNAb6ChwrmBOsn8ZnQG/gU=; b=Bqf1wEnaS9VUVTQaPgvdNpGlvot27EqmPm01dcl1cPhuD4LqqY0ThDXW8aKoZeYkWL jvBzmT5NDr7cO9id+BysuOf4bQ4KvJRA0HlwhTNNIQDgmrwCKadvXPlkFrLMgXeePLZt qMMFSpEdO0vSlJndEsSk+I7kRMk1J6QNFwXHaJ324CxrZ6i1r0M40sxCT8oQ6foKVbYH oXozH3bSb4rMqewBNadlINMBaqiN1ZIRHbknPuTW3gWp3F3RF40aarw2zdRjj9sNOsHp rPRct8oB4xHucYnbU4uY8L064Kg7mc5oOfBmgc8uo5sTxEnJoDgAdmGAJpDtUMG9K70z YBgg== X-Gm-Message-State: AOJu0YzezioClWvczPJ0nsY9jrClEY6qNjuoX+H9qnKFIqcCF0+udUNU mbq7PoOr2uW70UIujL3ReT4JZA== X-Google-Smtp-Source: AGHT+IHQylBB1OaU1N5c+sSQguv3EKqvg4Jl90Mga+WinyhchnFWb3Y6D/4kJe8HnBau+w6tjoRKRQ== X-Received: by 2002:a17:90a:d683:b0:286:6cc1:3f06 with SMTP id x3-20020a17090ad68300b002866cc13f06mr6016567pju.61.1702480149384; Wed, 13 Dec 2023 07:09:09 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id g8-20020a17090adb0800b0028aefb5fa05sm902436pjv.40.2023.12.13.07.09.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Dec 2023 07:09:09 -0800 (PST) Date: Wed, 13 Dec 2023 07:09:07 -0800 From: Stephen Hemminger To: David Marchand Cc: dev@dpdk.org Subject: Re: [PATCH v2 00/25] Replace use of RTE_LOGTYPE_PMD Message-ID: <20231213070907.0fd50f45@hermes.local> In-Reply-To: References: <20231213014408.612051-1-stephen@networkplumber.org> <20231213041920.729403-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, 13 Dec 2023 09:00:48 +0100 David Marchand wrote: > On Wed, Dec 13, 2023 at 5:19=E2=80=AFAM Stephen Hemminger > wrote: > > > > The generic RTE_LOGTYPE_PMD is a leftover and should be removed. > > As a first step, fix many drivers to not use it, and add a > > helper for the RTE_LOG_DP(). =20 >=20 > I don't see why we need a new rte_log_dp helper. > The #define RTE_LOGTYPE_XXX trick should work fine with RTE_LOG_DP(). > What else is missing? The problem is RTE_LOG_DP() usage today takes suffixes. So the param log type can only be one of the pre-defined fixed values. Changing the macro in one patch would be a huge patch. It seemed best to have RTE_LOG_DP() stay like RTE_LOG() and introduce rte_log_dp() to match rte_log().