* [dpdk-dev] [PATCH 1/2] common/cnxk: support PPPoE flow item type in ROC API
@ 2023-12-14 7:17 psatheesh
2023-12-14 7:17 ` [dpdk-dev] [PATCH 2/2] net/cnxk: support PPPoE flow item type psatheesh
2023-12-14 14:33 ` [dpdk-dev] [PATCH v2 1/2] common/cnxk: support PPPoE flow item type in ROC API psatheesh
0 siblings, 2 replies; 6+ messages in thread
From: psatheesh @ 2023-12-14 7:17 UTC (permalink / raw)
To: Nithin Dabilpuram, Kiran Kumar K, Sunil Kumar Kori, Satha Rao
Cc: dev, Satheesh Paul
From: Satheesh Paul <psatheesh@marvell.com>
Added ROC API changes to parse RTE_FLOW_ITEM_TYPE_PPPOES
rte_flow item type.
Signed-off-by: Satheesh Paul <psatheesh@marvell.com>
Reviewed-by: Kiran Kumar K <kirankumark@marvell.com>
---
drivers/common/cnxk/roc_npc.h | 1 +
drivers/common/cnxk/roc_npc_parse.c | 5 +++++
2 files changed, 6 insertions(+)
diff --git a/drivers/common/cnxk/roc_npc.h b/drivers/common/cnxk/roc_npc.h
index 459fa33de9..cb59db2220 100644
--- a/drivers/common/cnxk/roc_npc.h
+++ b/drivers/common/cnxk/roc_npc.h
@@ -33,6 +33,7 @@ enum roc_npc_item_type {
ROC_NPC_ITEM_TYPE_VXLAN_GPE,
ROC_NPC_ITEM_TYPE_IPV6_EXT,
ROC_NPC_ITEM_TYPE_GRE_KEY,
+ ROC_NPC_ITEM_TYPE_PPPOES,
ROC_NPC_ITEM_TYPE_HIGIG2,
ROC_NPC_ITEM_TYPE_CPT_HDR,
ROC_NPC_ITEM_TYPE_L3_CUSTOM,
diff --git a/drivers/common/cnxk/roc_npc_parse.c b/drivers/common/cnxk/roc_npc_parse.c
index ecd1b3e13b..9ceb707ebb 100644
--- a/drivers/common/cnxk/roc_npc_parse.c
+++ b/drivers/common/cnxk/roc_npc_parse.c
@@ -525,6 +525,11 @@ npc_parse_lb(struct npc_parse_state *pst)
info.len = pattern->size;
lt = NPC_LT_LB_STAG_QINQ;
lflags = NPC_F_STAG_CTAG;
+ } else if (pst->pattern->type == ROC_NPC_ITEM_TYPE_PPPOES) {
+ info.hw_mask = NULL;
+ info.len = pattern->size;
+ info.hw_hdr_len = 2;
+ lt = NPC_LT_LB_PPPOE;
} else if (pst->pattern->type == ROC_NPC_ITEM_TYPE_RAW) {
raw_spec = pst->pattern->spec;
if (raw_spec->relative)
--
2.39.2
^ permalink raw reply [flat|nested] 6+ messages in thread
* [dpdk-dev] [PATCH 2/2] net/cnxk: support PPPoE flow item type
2023-12-14 7:17 [dpdk-dev] [PATCH 1/2] common/cnxk: support PPPoE flow item type in ROC API psatheesh
@ 2023-12-14 7:17 ` psatheesh
2023-12-14 13:42 ` [EXT] [dpdk-dev] [PATCH 2/2] net/cnxk: support Pepo " Jerin Jacob Kollanukkaran
2023-12-14 14:33 ` [dpdk-dev] [PATCH v2 1/2] common/cnxk: support PPPoE flow item type in ROC API psatheesh
1 sibling, 1 reply; 6+ messages in thread
From: psatheesh @ 2023-12-14 7:17 UTC (permalink / raw)
To: Nithin Dabilpuram, Kiran Kumar K, Sunil Kumar Kori, Satha Rao
Cc: dev, Satheesh Paul
From: Satheesh Paul <psatheesh@marvell.com>
Support to parse RTE_FLOW_ITEM_TYPE_PPPOES rte_flow item
type for cnxk device.
Signed-off-by: Satheesh Paul <psatheesh@marvell.com>
Reviewed-by: Kiran Kumar K <kirankumark@marvell.com>
---
doc/guides/nics/features/cnxk.ini | 1 +
doc/guides/nics/features/cnxk_vec.ini | 1 +
doc/guides/nics/features/cnxk_vf.ini | 1 +
drivers/net/cnxk/cnxk_flow.c | 7 ++++---
4 files changed, 7 insertions(+), 3 deletions(-)
diff --git a/doc/guides/nics/features/cnxk.ini b/doc/guides/nics/features/cnxk.ini
index ac7de9a0f0..cc7deaeaa9 100644
--- a/doc/guides/nics/features/cnxk.ini
+++ b/doc/guides/nics/features/cnxk.ini
@@ -71,6 +71,7 @@ ipv6_routing_ext = Y
mark = Y
mpls = Y
nvgre = Y
+pppoes = Y
raw = Y
sctp = Y
tcp = Y
diff --git a/doc/guides/nics/features/cnxk_vec.ini b/doc/guides/nics/features/cnxk_vec.ini
index e2cac64e4b..6086b3d73f 100644
--- a/doc/guides/nics/features/cnxk_vec.ini
+++ b/doc/guides/nics/features/cnxk_vec.ini
@@ -65,6 +65,7 @@ ipv6_frag_ext = Y
mark = Y
mpls = Y
nvgre = Y
+pppoes = Y
raw = Y
sctp = Y
tcp = Y
diff --git a/doc/guides/nics/features/cnxk_vf.ini b/doc/guides/nics/features/cnxk_vf.ini
index b03e8b35c3..53aa2a3d0c 100644
--- a/doc/guides/nics/features/cnxk_vf.ini
+++ b/doc/guides/nics/features/cnxk_vf.ini
@@ -62,6 +62,7 @@ ipv6_routing_ext = Y
mark = Y
mpls = Y
nvgre = Y
+pppoes = Y
raw = Y
sctp = Y
tcp = Y
diff --git a/drivers/net/cnxk/cnxk_flow.c b/drivers/net/cnxk/cnxk_flow.c
index 08ab75e2bb..2eee44ed09 100644
--- a/drivers/net/cnxk/cnxk_flow.c
+++ b/drivers/net/cnxk/cnxk_flow.c
@@ -62,11 +62,12 @@ const struct cnxk_rte_flow_term_info term[] = {
[RTE_FLOW_ITEM_TYPE_IPV6_ROUTING_EXT] = {ROC_NPC_ITEM_TYPE_IPV6_ROUTING_EXT,
sizeof(struct rte_flow_item_ipv6_routing_ext)},
[RTE_FLOW_ITEM_TYPE_TX_QUEUE] = {ROC_NPC_ITEM_TYPE_TX_QUEUE,
- sizeof(struct rte_flow_item_tx_queue)}};
+ sizeof(struct rte_flow_item_tx_queue)},
+ [RTE_FLOW_ITEM_TYPE_PPPOES] = {ROC_NPC_ITEM_TYPE_PPPOES,
+ sizeof(struct rte_flow_item_pppoe)}};
static int
-npc_rss_action_validate(struct rte_eth_dev *eth_dev,
- const struct rte_flow_attr *attr,
+npc_rss_action_validate(struct rte_eth_dev *eth_dev, const struct rte_flow_attr *attr,
const struct rte_flow_action *act)
{
const struct rte_flow_action_rss *rss;
--
2.39.2
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [EXT] [dpdk-dev] [PATCH 2/2] net/cnxk: support Pepo flow item type
2023-12-14 7:17 ` [dpdk-dev] [PATCH 2/2] net/cnxk: support PPPoE flow item type psatheesh
@ 2023-12-14 13:42 ` Jerin Jacob Kollanukkaran
0 siblings, 0 replies; 6+ messages in thread
From: Jerin Jacob Kollanukkaran @ 2023-12-14 13:42 UTC (permalink / raw)
To: Satheesh Paul Antonysamy, Nithin Kumar Dabilpuram,
Kiran Kumar Kokkilagadda, Sunil Kumar Kori,
Satha Koteswara Rao Kottidi
Cc: dev, Satheesh Paul Antonysamy
> -----Original Message-----
> From: psatheesh@marvell.com <psatheesh@marvell.com>
> Sent: Thursday, December 14, 2023 12:48 PM
> To: Nithin Kumar Dabilpuram <ndabilpuram@marvell.com>; Kiran Kumar
> Kokkilagadda <kirankumark@marvell.com>; Sunil Kumar Kori
> <skori@marvell.com>; Satha Koteswara Rao Kottidi
> <skoteshwar@marvell.com>
> Cc: dev@dpdk.org; Satheesh Paul Antonysamy <psatheesh@marvell.com>
> Subject: [EXT] [dpdk-dev] [PATCH 2/2] net/cnxk: support PPPoE flow item type
>
> External Email
>
> ----------------------------------------------------------------------
> From: Satheesh Paul <psatheesh@marvell.com>
>
> Support to parse RTE_FLOW_ITEM_TYPE_PPPOES rte_flow item type for cnxk
> device.
>
> Signed-off-by: Satheesh Paul <psatheesh@marvell.com>
> Reviewed-by: Kiran Kumar K <kirankumark@marvell.com>
Please update the release notes for this new feature.
> ---
> doc/guides/nics/features/cnxk.ini | 1 +
> doc/guides/nics/features/cnxk_vec.ini | 1 +
> doc/guides/nics/features/cnxk_vf.ini | 1 +
> drivers/net/cnxk/cnxk_flow.c | 7 ++++---
> 4 files changed, 7 insertions(+), 3 deletions(-)
>
> diff --git a/doc/guides/nics/features/cnxk.ini
> b/doc/guides/nics/features/cnxk.ini
> index ac7de9a0f0..cc7deaeaa9 100644
> --- a/doc/guides/nics/features/cnxk.ini
> +++ b/doc/guides/nics/features/cnxk.ini
> @@ -71,6 +71,7 @@ ipv6_routing_ext = Y
> mark = Y
> mpls = Y
> nvgre = Y
> +pppoes = Y
> raw = Y
> sctp = Y
> tcp = Y
> diff --git a/doc/guides/nics/features/cnxk_vec.ini
> b/doc/guides/nics/features/cnxk_vec.ini
> index e2cac64e4b..6086b3d73f 100644
> --- a/doc/guides/nics/features/cnxk_vec.ini
> +++ b/doc/guides/nics/features/cnxk_vec.ini
> @@ -65,6 +65,7 @@ ipv6_frag_ext = Y
> mark = Y
> mpls = Y
> nvgre = Y
> +pppoes = Y
> raw = Y
> sctp = Y
> tcp = Y
> diff --git a/doc/guides/nics/features/cnxk_vf.ini
> b/doc/guides/nics/features/cnxk_vf.ini
> index b03e8b35c3..53aa2a3d0c 100644
> --- a/doc/guides/nics/features/cnxk_vf.ini
> +++ b/doc/guides/nics/features/cnxk_vf.ini
> @@ -62,6 +62,7 @@ ipv6_routing_ext = Y
> mark = Y
> mpls = Y
> nvgre = Y
> +pppoes = Y
> raw = Y
> sctp = Y
> tcp = Y
> diff --git a/drivers/net/cnxk/cnxk_flow.c b/drivers/net/cnxk/cnxk_flow.c index
> 08ab75e2bb..2eee44ed09 100644
> --- a/drivers/net/cnxk/cnxk_flow.c
> +++ b/drivers/net/cnxk/cnxk_flow.c
> @@ -62,11 +62,12 @@ const struct cnxk_rte_flow_term_info term[] = {
> [RTE_FLOW_ITEM_TYPE_IPV6_ROUTING_EXT] =
> {ROC_NPC_ITEM_TYPE_IPV6_ROUTING_EXT,
> sizeof(struct
> rte_flow_item_ipv6_routing_ext)},
> [RTE_FLOW_ITEM_TYPE_TX_QUEUE] =
> {ROC_NPC_ITEM_TYPE_TX_QUEUE,
> - sizeof(struct rte_flow_item_tx_queue)}};
> + sizeof(struct rte_flow_item_tx_queue)},
> + [RTE_FLOW_ITEM_TYPE_PPPOES] = {ROC_NPC_ITEM_TYPE_PPPOES,
> + sizeof(struct rte_flow_item_pppoe)}};
>
> static int
> -npc_rss_action_validate(struct rte_eth_dev *eth_dev,
> - const struct rte_flow_attr *attr,
> +npc_rss_action_validate(struct rte_eth_dev *eth_dev, const struct
> +rte_flow_attr *attr,
> const struct rte_flow_action *act)
> {
> const struct rte_flow_action_rss *rss;
> --
> 2.39.2
^ permalink raw reply [flat|nested] 6+ messages in thread
* [dpdk-dev] [PATCH v2 1/2] common/cnxk: support PPPoE flow item type in ROC API
2023-12-14 7:17 [dpdk-dev] [PATCH 1/2] common/cnxk: support PPPoE flow item type in ROC API psatheesh
2023-12-14 7:17 ` [dpdk-dev] [PATCH 2/2] net/cnxk: support PPPoE flow item type psatheesh
@ 2023-12-14 14:33 ` psatheesh
2023-12-14 14:33 ` [dpdk-dev] [PATCH v2 2/2] net/cnxk: support PPPoE flow item type psatheesh
1 sibling, 1 reply; 6+ messages in thread
From: psatheesh @ 2023-12-14 14:33 UTC (permalink / raw)
To: Nithin Dabilpuram, Kiran Kumar K, Sunil Kumar Kori, Satha Rao
Cc: dev, Satheesh Paul
From: Satheesh Paul <psatheesh@marvell.com>
Added ROC API changes to parse RTE_FLOW_ITEM_TYPE_PPPOES
rte_flow item type.
Signed-off-by: Satheesh Paul <psatheesh@marvell.com>
Reviewed-by: Kiran Kumar K <kirankumark@marvell.com>
---
v2:
* Updated release notes.
drivers/common/cnxk/roc_npc.h | 1 +
drivers/common/cnxk/roc_npc_parse.c | 5 +++++
2 files changed, 6 insertions(+)
diff --git a/drivers/common/cnxk/roc_npc.h b/drivers/common/cnxk/roc_npc.h
index 459fa33de9..cb59db2220 100644
--- a/drivers/common/cnxk/roc_npc.h
+++ b/drivers/common/cnxk/roc_npc.h
@@ -33,6 +33,7 @@ enum roc_npc_item_type {
ROC_NPC_ITEM_TYPE_VXLAN_GPE,
ROC_NPC_ITEM_TYPE_IPV6_EXT,
ROC_NPC_ITEM_TYPE_GRE_KEY,
+ ROC_NPC_ITEM_TYPE_PPPOES,
ROC_NPC_ITEM_TYPE_HIGIG2,
ROC_NPC_ITEM_TYPE_CPT_HDR,
ROC_NPC_ITEM_TYPE_L3_CUSTOM,
diff --git a/drivers/common/cnxk/roc_npc_parse.c b/drivers/common/cnxk/roc_npc_parse.c
index ecd1b3e13b..9ceb707ebb 100644
--- a/drivers/common/cnxk/roc_npc_parse.c
+++ b/drivers/common/cnxk/roc_npc_parse.c
@@ -525,6 +525,11 @@ npc_parse_lb(struct npc_parse_state *pst)
info.len = pattern->size;
lt = NPC_LT_LB_STAG_QINQ;
lflags = NPC_F_STAG_CTAG;
+ } else if (pst->pattern->type == ROC_NPC_ITEM_TYPE_PPPOES) {
+ info.hw_mask = NULL;
+ info.len = pattern->size;
+ info.hw_hdr_len = 2;
+ lt = NPC_LT_LB_PPPOE;
} else if (pst->pattern->type == ROC_NPC_ITEM_TYPE_RAW) {
raw_spec = pst->pattern->spec;
if (raw_spec->relative)
--
2.39.2
^ permalink raw reply [flat|nested] 6+ messages in thread
* [dpdk-dev] [PATCH v2 2/2] net/cnxk: support PPPoE flow item type
2023-12-14 14:33 ` [dpdk-dev] [PATCH v2 1/2] common/cnxk: support PPPoE flow item type in ROC API psatheesh
@ 2023-12-14 14:33 ` psatheesh
2023-12-15 5:04 ` Jerin Jacob
0 siblings, 1 reply; 6+ messages in thread
From: psatheesh @ 2023-12-14 14:33 UTC (permalink / raw)
To: Nithin Dabilpuram, Kiran Kumar K, Sunil Kumar Kori, Satha Rao
Cc: dev, Satheesh Paul
From: Satheesh Paul <psatheesh@marvell.com>
Support to parse RTE_FLOW_ITEM_TYPE_PPPOES rte_flow item
type for cnxk device.
Signed-off-by: Satheesh Paul <psatheesh@marvell.com>
Reviewed-by: Kiran Kumar K <kirankumark@marvell.com>
---
doc/guides/nics/features/cnxk.ini | 1 +
doc/guides/nics/features/cnxk_vec.ini | 1 +
doc/guides/nics/features/cnxk_vf.ini | 1 +
doc/guides/rel_notes/release_24_03.rst | 3 +++
drivers/net/cnxk/cnxk_flow.c | 7 ++++---
5 files changed, 10 insertions(+), 3 deletions(-)
diff --git a/doc/guides/nics/features/cnxk.ini b/doc/guides/nics/features/cnxk.ini
index ac7de9a0f0..cc7deaeaa9 100644
--- a/doc/guides/nics/features/cnxk.ini
+++ b/doc/guides/nics/features/cnxk.ini
@@ -71,6 +71,7 @@ ipv6_routing_ext = Y
mark = Y
mpls = Y
nvgre = Y
+pppoes = Y
raw = Y
sctp = Y
tcp = Y
diff --git a/doc/guides/nics/features/cnxk_vec.ini b/doc/guides/nics/features/cnxk_vec.ini
index e2cac64e4b..6086b3d73f 100644
--- a/doc/guides/nics/features/cnxk_vec.ini
+++ b/doc/guides/nics/features/cnxk_vec.ini
@@ -65,6 +65,7 @@ ipv6_frag_ext = Y
mark = Y
mpls = Y
nvgre = Y
+pppoes = Y
raw = Y
sctp = Y
tcp = Y
diff --git a/doc/guides/nics/features/cnxk_vf.ini b/doc/guides/nics/features/cnxk_vf.ini
index b03e8b35c3..53aa2a3d0c 100644
--- a/doc/guides/nics/features/cnxk_vf.ini
+++ b/doc/guides/nics/features/cnxk_vf.ini
@@ -62,6 +62,7 @@ ipv6_routing_ext = Y
mark = Y
mpls = Y
nvgre = Y
+pppoes = Y
raw = Y
sctp = Y
tcp = Y
diff --git a/doc/guides/rel_notes/release_24_03.rst b/doc/guides/rel_notes/release_24_03.rst
index 41b0eb8f1d..866dd60fbf 100644
--- a/doc/guides/rel_notes/release_24_03.rst
+++ b/doc/guides/rel_notes/release_24_03.rst
@@ -62,6 +62,9 @@ New Features
* Added optimized SSE Rx routines.
* Added optimized AVX2 Rx routines.
+* **Updated Marvell cnxk net driver.**
+
+ * Added support for ``RTE_FLOW_ITEM_TYPE_PPPOES`` flow item.
Removed Items
-------------
diff --git a/drivers/net/cnxk/cnxk_flow.c b/drivers/net/cnxk/cnxk_flow.c
index 08ab75e2bb..2eee44ed09 100644
--- a/drivers/net/cnxk/cnxk_flow.c
+++ b/drivers/net/cnxk/cnxk_flow.c
@@ -62,11 +62,12 @@ const struct cnxk_rte_flow_term_info term[] = {
[RTE_FLOW_ITEM_TYPE_IPV6_ROUTING_EXT] = {ROC_NPC_ITEM_TYPE_IPV6_ROUTING_EXT,
sizeof(struct rte_flow_item_ipv6_routing_ext)},
[RTE_FLOW_ITEM_TYPE_TX_QUEUE] = {ROC_NPC_ITEM_TYPE_TX_QUEUE,
- sizeof(struct rte_flow_item_tx_queue)}};
+ sizeof(struct rte_flow_item_tx_queue)},
+ [RTE_FLOW_ITEM_TYPE_PPPOES] = {ROC_NPC_ITEM_TYPE_PPPOES,
+ sizeof(struct rte_flow_item_pppoe)}};
static int
-npc_rss_action_validate(struct rte_eth_dev *eth_dev,
- const struct rte_flow_attr *attr,
+npc_rss_action_validate(struct rte_eth_dev *eth_dev, const struct rte_flow_attr *attr,
const struct rte_flow_action *act)
{
const struct rte_flow_action_rss *rss;
--
2.39.2
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [PATCH v2 2/2] net/cnxk: support PPPoE flow item type
2023-12-14 14:33 ` [dpdk-dev] [PATCH v2 2/2] net/cnxk: support PPPoE flow item type psatheesh
@ 2023-12-15 5:04 ` Jerin Jacob
0 siblings, 0 replies; 6+ messages in thread
From: Jerin Jacob @ 2023-12-15 5:04 UTC (permalink / raw)
To: psatheesh
Cc: Nithin Dabilpuram, Kiran Kumar K, Sunil Kumar Kori, Satha Rao, dev
On Thu, Dec 14, 2023 at 8:03 PM <psatheesh@marvell.com> wrote:
>
> From: Satheesh Paul <psatheesh@marvell.com>
>
> Support to parse RTE_FLOW_ITEM_TYPE_PPPOES rte_flow item
> type for cnxk device.
>
> Signed-off-by: Satheesh Paul <psatheesh@marvell.com>
> Reviewed-by: Kiran Kumar K <kirankumark@marvell.com>
Series applied to dpdk-next-net-mrvl/for-main. Thanks
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2023-12-15 5:04 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-12-14 7:17 [dpdk-dev] [PATCH 1/2] common/cnxk: support PPPoE flow item type in ROC API psatheesh
2023-12-14 7:17 ` [dpdk-dev] [PATCH 2/2] net/cnxk: support PPPoE flow item type psatheesh
2023-12-14 13:42 ` [EXT] [dpdk-dev] [PATCH 2/2] net/cnxk: support Pepo " Jerin Jacob Kollanukkaran
2023-12-14 14:33 ` [dpdk-dev] [PATCH v2 1/2] common/cnxk: support PPPoE flow item type in ROC API psatheesh
2023-12-14 14:33 ` [dpdk-dev] [PATCH v2 2/2] net/cnxk: support PPPoE flow item type psatheesh
2023-12-15 5:04 ` Jerin Jacob
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).